23d405ad86
Expose /resetMetrics handle in apiserver
2015-06-23 11:12:45 +02:00
debd42a07d
Cleaning up apiserver method signatures
...
A lot of the changes in apiserver could have been represented more
cleanly - this returns the signatures to their older behavior (and
unbreaks OpenShift).
2015-06-18 15:13:41 -04:00
b68ddbaf75
Don't pretty-print by default. Saves an allocation (or more) and a copy.
2015-06-08 21:31:58 -07:00
30a89968a4
Initial proxy tunnelling.
2015-06-05 14:54:20 -07:00
448867073d
Pipe minRequestTimeout as an arg to the apiserver
2015-06-03 08:44:14 -07:00
9e486be743
Merge pull request #8795 from a-robinson/latency
...
Remove the clientID field from the apiserver request latency metric
2015-05-28 16:55:11 -07:00
36d54b2094
Remove /Validate endpoint
2015-05-26 10:49:18 -07:00
0339f68273
Remove the clientID field from the apiserver request latency metric.
2015-05-25 20:31:25 -07:00
8a5445d3db
Randomize apiserver watch timeouts
2015-05-21 20:52:33 -07:00
6b3a6e6b98
Make copyright ownership statement generic
...
Instead of saying "Google Inc." (which is not always correct) say "The
Kubernetes Authors", which is generic.
2015-05-01 17:49:56 -04:00
c1c24f645c
Add summary metrics to apiserver for easier debugging and future use in performance tests
2015-04-28 14:27:18 +02:00
159a58ddfb
Merge pull request #7169 from fgrzadkowski/requests_by_clients
...
Break request metrics in apiserver by client.
2015-04-24 13:37:50 +02:00
8b755c805b
Break request metrics in apiserver by client.
2015-04-24 13:16:14 +02:00
120904df5f
Fixing serviceErrorHandler to use apiVersion specific codec
2015-04-23 14:32:05 -07:00
951a125751
Add "componentstatus" to API for easier cluster health check.
2015-04-17 11:58:23 -07:00
fafcf79d5d
Allow more retries in density test
2015-04-17 12:35:56 +02:00
f9132dc572
Registering serviceErrorHandler with go-restful
2015-04-16 14:59:44 -07:00
efc7f86baf
Add GetterWithOptions and allow stream flushing
...
In addition to Getter interface, API Installer now supports a
GetterWithOptions interface that takes an additional options object when
getting a resource. A flag is now returned from rest.ResourceStreamer
that indicates whether the streamed response should be
flushed when written back to the client. This is to support log
streaming.
2015-04-07 07:46:30 -04:00
f15e34a1bf
Revert "Merge pull request #6309 from GoogleCloudPlatform/revert-6243-kubelet-ssl"
...
This reverts commit 96a0a0d6182af9b54147
2015-04-02 10:44:37 -07:00
32a1c052dc
Revert "Configure the kubelet to use HTTPS"
2015-04-01 13:59:31 -07:00
58bc792e68
Configure the master to connect to the kubelet using HTTPS.
2015-04-01 09:09:29 -07:00
870da687d0
Add more extensive tests to apiserver for variations in version
...
Formalize v1beta1 and v1beta3 style APIs in our test cases.
2015-03-27 15:03:58 -04:00
1618c39a46
Convert List query parameters via object conversion
...
Convert url.Values -> an object, with appropriate versioning. ListOptions
should also expose parameter names to swagger.
2015-03-27 15:03:57 -04:00
fc3609fb5b
Allow InputStreams to be returned by requests
...
Add additional metadata to restful services.
2015-03-24 17:25:45 -04:00
d46087db50
Move REST* interfaces into pkg/api/rest
...
Dependency chain is now api -> api/rest -> apiserver. Makes the
interfaces much cleaner to read, and cleans up some inconsistenties
that crept in along the way.
2015-03-23 16:52:21 -04:00
ffcf7b1866
Increased default timeout in APIServer to 2 minutes
...
This should for #5431
2015-03-14 06:54:31 +01:00
4b16a87096
Simplify api_installer and setup methods
2015-03-09 14:39:31 -04:00
05ea93f985
Merge pull request #5147 from a-robinson/func
...
Re-add the defer statements around the monitor() calls in the apiserver.
2015-03-06 15:31:45 -08:00
60f0e9d673
Fix the broken calls to the monitor() by having it take arguments as pointers.
...
This is needed for the changes to various labels from later in the function
to be picked up.
2015-03-06 23:16:44 +00:00
0d5fe5d078
Use a prometheus Histogram rather than a Summary for tracking apiserver latency.
2015-03-02 02:15:16 +00:00
905a3f7909
Updating the handlers to accept full request path rather than a trimmed one
2015-02-24 00:37:20 -08:00
083ce268e0
Put user in context, map requests to context above resthandler layer
2015-02-12 20:58:04 -05:00
8f6e3607a9
Add monitoring as a filter
2015-02-11 17:07:23 -05:00
d167c11b59
Remove layers of indirection between apiinstaller and resthandler
...
Make the RESTHandler feel more go-restful, set the stage for adding
new types of subresource collections.
2015-02-11 16:26:06 -05:00
d39262d743
Consolidate the prometheus Counters into a shared CounterVec and remove
...
the "code" label from the latencies SummaryVec.
2015-02-10 22:47:56 +00:00
2463cff79c
Basic initial instrumentation of the apiserver. This links in the
...
prometheus library for monitoring, which exports some basic resource
usage metrics by default, like number of goroutines, open file
descriptors, resident and virtual memory, etc. I've also started adding
in request counters and latency histograms, but have only added them to two
of our HTTP handlers. If this looks reasonable, I'll add them to the rest
in a second PR.
2015-02-10 20:44:28 +00:00
1c9216a45e
clarify api request information
2015-02-04 13:36:01 -05:00
18609e1706
Moving /watch, /proxy and /redirect registration to go-restful
2015-02-03 15:47:48 -08:00
9263a8f627
Remove logging on apiserver startup
...
Now that we return errors on startup there's not much value in the
startup log for anyone except a few developers. Nuke
2015-02-03 00:02:07 -05:00
a216cb747c
Fix logic issue in register resource handlers not doing list across all namespaces in v1beta3
2015-02-02 10:26:19 -05:00
4c33e36a88
Plumb restmapper properly through apiserver and tests
2015-02-02 10:26:19 -05:00
71ec444d63
Make a RESTMapper scope aware
2015-02-02 10:26:19 -05:00
521728e920
Deleting OperationHandler for handling /operation endpoint on server
2015-01-28 13:13:10 -08:00
5117189e03
Merge pull request #3707 from nikhiljindal/preOperations
...
Removing support for asynchronous server requests
2015-01-28 13:02:52 -05:00
6e1f680a57
return all errors from RESTStorage registration
2015-01-28 10:31:33 -05:00
de60600608
Making all operations synchronous
2015-01-27 18:47:56 -08:00
3a9e6d8f29
Switch to use Too Many Requests response code
...
Name the 429 status code
2015-01-27 14:54:30 -08:00
358ace610d
Merge pull request #3824 from smarterclayton/allow_panic_and_error_reporting
...
Allow panics and unhandled errors to be sent elsewhere
2015-01-27 13:18:43 -08:00
b078889360
Merge pull request #3822 from nikhiljindal/swaggerbug
...
Fixing a bug where Reads() was being called twice on POST routes
2015-01-27 10:01:27 -08:00
19987612bf
Replace code that eats errors with a more consistent reporting
...
In order to allow certain programmer error / unexpected error states
to be captured, replace sections that log and eat errors with a method
that can be centrally replaced. This captures two common error sources,
replication errors, and apiserver code that returns invalid errors.
2015-01-26 20:54:29 -05:00
54e5d1f102
Fixing a bug where Reads() was called twice on all POST routes
2015-01-26 17:21:25 -08:00
51007cc798
Updating handleIndex in master to list all valid paths.
...
The list of valid paths is computed from http.ServeMux and
restful.WebService.
Adding a mux helper - wrapper over mux, that keeps track of the paths
handled by mux.
2015-01-21 13:40:01 -08:00
90c835af47
The API server setup logging is debug specific, bump above V(4)
...
Reduces some chatter in test suites where we are confident this code
already works. Also removed any logging which is obvious from swagger.
Finally, rolls up InstallREST related errors all the way back to master,
which will glog.Fatalf (coding errors).
2015-01-15 14:25:58 -05:00
f8db96b673
Fixing a bug in
...
https://github.com/GoogleCloudPlatform/kubernetes/pull/3404 which broke
swagger-ui.
Swagger-ui requires operation to be defined on all Routes.
2015-01-12 15:20:01 -08:00
6f43074143
Merge pull request #3404 from smarterclayton/method_not_allowed
...
Allow RESTStorage objects to not implement methods
2015-01-12 13:21:10 -08:00
d17f75f254
Remove user agent logging (doesn't add significant value)
...
We can reintroduce path/agent logging at a later point, this just clogs
verbose logs.
2015-01-12 13:37:37 -05:00
22c99c98e2
Split RESTStorage into separate interfaces
...
Omit unimplemented interfaces from Swagger
2015-01-12 12:19:45 -05:00
7e909ed743
Changes to improve swagger ui.
...
- Separating out index, version and api handlers into independent web
services. Moved the index handler to /welcome, version handler to
/version and the api handler to /api,
2015-01-09 10:56:24 -08:00
a56087cdf8
Remove client from attributes, remove admission control interface, fix-up error codes
2015-01-07 14:42:31 -05:00
520ae3ef27
Implement basic admission control framework
2015-01-07 14:42:31 -05:00
5c14fc610b
Merge pull request #3045 from nikhiljindal/setApiVersion
...
Setting apiVersion in restful.WebService
2014-12-19 10:11:15 -08:00
cfee8f1355
done
2014-12-18 15:38:09 -08:00
6694a45542
Add doc for {namespace} path param, fixup and verify proxy paths
2014-12-16 15:55:48 -05:00
7cf664439f
Move namespace from query param to path part
2014-12-16 15:55:47 -05:00
b1b255f90a
Prevent infinite loop in apiserver errorJSON
2014-12-12 18:23:17 -05:00
59b5546b28
Turn on node level validation, and make the validation set dynamic.
2014-12-10 22:02:45 -08:00
e18dcb87c4
Format JSON by default. Fixes #2243 .
2014-11-25 23:11:43 +00:00
ea960711ff
Clean up error logs.
...
Use %v for errors, tidy some messages, make error messages start lowe-case
(as per go guidelines). Just accumulated nits.
2014-11-21 09:45:26 +08:00
7583e1a643
Automatic API generation by adopting go-restful
2014-11-14 16:49:19 +00:00
21a6e96418
Merge pull request #2126 from brendandburns/validatez
...
Add etcd to the list of services to validate.
2014-11-10 14:53:41 -05:00
d7dc20fd6a
Add etcd to the list of services to validate.
...
Also add minions.
2014-11-05 21:22:01 -08:00
4196780eda
Add self links to objects sent down the watch channel.
2014-11-05 17:22:18 -08:00
1668c6f107
Authorization based on namespace, kind, readonly.
...
Also, pass Authorizer into master.Config.
2014-11-03 17:45:15 -08:00
dca7363459
Serve API version list, test with an integration test.
2014-10-28 17:35:56 -07:00
40a5ca034d
Integration test on master, not just apiserver.
...
Moved code from cmd/apiserver to pkg/master.
test/integration/client_test made to use a master object,
instead of an apiserver.Handle.
Subsequent PRs will move more handler-installation into
pkg/master, with the goal that every http.Handler of a
standalone apiserver process can also be tested
in a "testing"-style go test.
In particular, a subsequent PR will test
authorization.
2014-10-27 09:14:58 -07:00
bf942e859f
remove old proxy code.
2014-10-20 11:28:12 -07:00
c0bf974871
Allow disabling non-necessary kubelet and apiserver endpoints
2014-10-09 16:49:27 -07:00
37e505601e
add self linking to apiserver
2014-09-26 15:08:02 -07:00
f8844ce69e
Add a validator for validating components in the cluster infrastructure.
2014-09-16 13:37:01 -07:00
d82cf7dd48
Rebased and fixed test cases
2014-09-09 17:50:18 -04:00
becf6ca4e7
Move RecoverPanics to be the top level wrapped handler. Add new method to be sure a logger has been generated instead of assuming one has. Move regexp list compilation into a utility and pass regexp list into CORS.
2014-09-09 17:50:18 -04:00
8b4ca9c2a7
Move CORS handler wrapping into cmd/apiserver and switch config flag to a list of allowed origins
2014-09-09 17:50:18 -04:00
8723eece49
Add option to enable a simple CORS implementation for the api server
2014-09-09 17:50:18 -04:00
69b359b689
Don't stack trace on 301s
2014-09-09 14:10:46 -07:00
753b80c9b8
Merge pull request #1105 from lavalamp/proxy
...
Add a generic proxier
2014-09-08 12:51:24 -07:00
0d30a656ef
Do interface{} -> runtime.Object rename everywhere
2014-09-07 22:19:24 -07:00
e2b645ec15
Add a generic proxier
...
To proxy traffic to anything that implements ResourceLocation.
Currently, this is only services. This is easily extensible to minions
(would supercede existing mechanism) and pods.
2014-09-05 13:33:30 -07:00
59f58cd043
Unify Godoc formatting, fix various typos
...
Signed-off-by: Vojtech Vitek (V-Teq) <vvitek@redhat.com>
2014-09-02 13:41:03 +02:00
4de254444e
Add simple service redirection
2014-08-27 20:51:41 -07:00
0f97a73c1b
Rename a bunch of "Make" functions to "New"
...
Also rename some to other names that make better reading. There are still a
bunch of "make" functions but they do things like assemble a string from parts
or build an array of things. It seemed that "make" there seemed fine. "New"
is for "constructors".
2014-08-20 21:27:19 -07:00
bbf3b55e76
Extract RESTHandler and allow API groupings
...
Prepare for running multiple API versions on the same HTTP server
by decoupling some of the mechanics of apiserver. Define a new
APIGroup object which represents a version of the API.
2014-08-13 10:53:34 -04:00
0083fae453
Provide helpers and tests for common error types
...
Unify error handling in apiserver into a single path - RESTStorage
objects must provide appropriate errors individually. Ensure ALL
errors which can be traced to logical faults with RESTStorage are
returned as api.Status objects.
2014-08-08 19:44:47 -04:00
a74fac7d70
Centralize path magic in apiserver into the New method
...
Make OperationHandler and WatchHandler properly encapsulate their
concerns and make them not depend on the global path
2014-08-08 16:33:44 -04:00
c9fc0bcf3d
Decouple apiserver from codec implementation
...
The apiserver on initialization must be provided with a codec
for encoding and decoding all handled objects including api.Status
and api.ServerOp. In addition, the RESTStorage Extract() method
has been changed to New(), which returns a pointer object that the
codec must decode into (the internal object). Switched registry
methods to use pointers for Create/Update instead of values.
2014-08-07 13:35:35 -04:00
836d2b9808
Fix proxy error condition and simplify method
...
Add new minion proxy test case.
2014-08-06 01:03:17 -04:00
325f9ef005
Make create atomic on etcd for Services/ReplControllers
2014-08-05 01:12:27 -04:00
1bdeb058e1
Slightly pause on requests to allow most to finish
...
Currently, every write will result in a 202 (etcd adding a few
ms of latency to each request). This forces clients to go into
a poll loop and pick a reasonable server poll frequency, which
results in 1 + N queries to the server for the single operation
and adds unavoidable latency to each request which affects their
perception of the service.
Add a very slight (25ms by default) delay to wait for requests
to finish. For clients doing normal writes this reduces the
requests made against the server to 1. For clients on long requests
this has no effect. The downside is that http connections are held
on to for a longer period in high write loads. The decrease in
perceived latency from the kubecfg is significant.
2014-07-30 17:49:47 -04:00
e64a393e1a
Move handle* methods to their respective locations
...
Fix names
2014-07-30 17:15:09 -04:00
fe7f611d88
Split operations code and add comments
2014-07-30 17:15:09 -04:00
9069696514
Rename write -> writeJSON
2014-07-30 17:15:09 -04:00
Wojciech Tyczynski