Commit Graph

501 Commits (8fcb0dfb7563fab0c377c62123ec0264b5b16e7f)

Author SHA1 Message Date
Dawn Chen 80bf32ce56 Merge pull request #14879 from tpounds/aws-cloud-cleanup
AWS Cloud Provider Cleanup
2015-10-12 12:25:52 -07:00
Alex Robinson 3bbfe48e0a Merge pull request #15286 from a-robinson/ensure
Correctly support updates in EnsureTCPLoadBalancer for GCE.
2015-10-09 17:34:40 -07:00
Alex Robinson 29c607bed6 Only use static IPs for GCE forwarding rules while creating or updating
them, not in the steady state once they've been created. This makes it
much less likely that users will run into static IP quota issues.

Also add slightly more parallelism to the deletion of load balancers
now that I realize the static IPs can be deleted in parallel with
forwarding rules :)
2015-10-09 19:03:57 +00:00
Alex Robinson 2a5a121505 Fix small comments. 2015-10-09 17:38:55 +00:00
Trevor Pounds 5d5013a722 Remove unreachable panic statement.
The availability zone always exist since it is retrieved
from the instance's EC2 metadata service during cloud
provider construction.
2015-10-09 10:19:56 -07:00
Trevor Pounds 4407ca9a64 Remove unused method. 2015-10-09 10:19:56 -07:00
Trevor Pounds f71533ce20 Remove unnecessary describe VPC call.
The external DescribeVPCs call is unnecessary since only the VPC ID
is used and it is retrieved from the EC2 metadata service.
2015-10-09 10:19:56 -07:00
Trevor Pounds 326dd7c1c0 Remove private struct field. It is only used at construction. 2015-10-09 10:19:56 -07:00
Alex Robinson 429fa7a378 Correctly support updates in EnsureTCPLoadBalancer for GCE.
Previously we'd just tear everything down and recreate it, which makes
for a pretty bad experience because it causes downtime whenever the
service controller restarts and has to make sure everything is in the
desired state.

This adds more code than I'd prefer, but makes it much cleaner and more
organized than it was before, in my opinion. I didn't bother
parallelizing anything because it's complex enough as it is, right now.

It's consistently passing the existing e2es and worked when I tested
manually, but this could definitely use additional e2e tests and/or some
serious refactoring to make real unit tests feasible. I'll follow up
with one or two e2e tests that make sense (updating an LB or killing the
controller manager, perhaps).
2015-10-08 23:20:48 +00:00
Prashanth Balasubramanian 02aa5e183c Add HTTPHealthCheck crud operations to cloudprovider library. 2015-10-07 13:22:56 -07:00
Alex Robinson d481ba7547 Merge pull request #14964 from a-robinson/lbdelete
Unrevert #14608 and decrease the latency of GCE load balancer deletions
2015-10-05 16:26:07 -07:00
Alex Robinson 90a9e01a68 Delete GCE external load balancer components in parallel.
This will cut down on the amount of time it takes to delete an external
load balancer, which should reduce the likelihood of resource leaks when
clusters are deleted.
2015-10-05 22:43:25 +00:00
Alex Robinson cfdde6f7d4 Fix PR for maintaining a GCE IP independently of the forwarding rule.
This code was in rough shape, so I've fixed the issues with the original
PR as well as a few other changes:
1. Clarify the error messages related to the "gce Addresses" to make it
   clear we're talking about static IP addresses
2. Fix the bug in the original PR, which was a nil pointer dereference
   from passing op to waitForRegionOp when the address doesn't exist.
3. Rearrange the steps of EnsureTCPLoadBalancerDeleted to be the reverse
   of EnsureCreated, which mostly just seems like good practice to me.
   This is also supported by the following two bugs I found :(
4. Fix an independent bug of returning too early if the target pool
   doesn't exist, effectively stranding the firewall. This was likely
   introduced because target pools used to be the last thing deleted,
   so it was previously safe to return there.
5. Fix an independent bug of not returning an error waiting for the
   target pool to be deleted failed. This was very possibly causing
   target pool leaks in our e2e tests. This was similarly due to
   assuming that the target pool was the last thing deleted in the
   function, then having the firewall deletion stuck in after it.
2015-10-05 22:43:15 +00:00
Alex Robinson d578e7738d Merge pull request #14242 from simonswine/fix_mulitple_subnets_per_az
aws: fixes ELB creation with multiple subnets per AZ
2015-10-05 13:06:19 -07:00
Marcin Wielgus 5adeb00583 Merge pull request #15048 from Huawei-PaaS/fixed_typos_for_cloudprovider
Fixed some typos and improved comments for cloudprovider
2015-10-05 17:49:15 +02:00
qiaolei 919add69be Fixed some typos and improved comments 2015-10-03 22:43:10 +08:00
k8s-merge-robot cc34aee8ab Merge pull request #14526 from saad-ali/issue13751GCEPollOps
Auto commit by PR queue bot
2015-10-02 09:46:28 -07:00
k8s-merge-robot a34855e0d1 Merge pull request #14657 from justinsb/aws_more_regions
Auto commit by PR queue bot
2015-10-02 03:48:25 -07:00
Brendan Burns 0e71ea1253 Maintain an IP address independent of the forwarding rule for GCE 2015-10-01 21:42:36 +00:00
Christian Simon c1a14bd163 aws: fixes ELB creation with multiple subnets per AZ
Only takes the first available subnet in a AZ, ignore other subnets
and log warning about this.

Removes AWS region comparison for subnet AZs. A VPC is only in a single
AWS region.

Fixes #12381
2015-10-01 21:38:11 +01:00
k8s-merge-robot 8356270cce Merge pull request #14430 from Defensative/updated-fw-tags
Auto commit by PR queue bot
2015-10-01 03:51:13 -07:00
eulerzgy 4c588d771c ent 2015-09-30 14:49:19 +08:00
eulerzgy 71b96422f4 set capital in some files 2015-09-30 14:46:20 +08:00
Brendan Burns 4b1d3d8b0c Merge pull request #14245 from tpounds/update-to-aws-sdk-go-v0.9.9
Update to aws-sdk-go v0.9.9
2015-09-29 19:31:14 -07:00
saadali 7771151767 GCE PD attach/detach operations should poll to verify successful completion 2015-09-29 14:32:06 -07:00
Justin Santa Barbara fda6243c5e AWS: Recognize cn-north-1 & us-gov-west-1 regions
These two regions were accidentally omitted.  This list now matches the
list we use elsewhere (e.g. when choosing an AMI).

Fixes #14420
2015-09-28 07:01:45 -07:00
Trevor Pounds ea85e2319b Use set interface methods. 2015-09-25 23:19:33 -07:00
Brian Grant 9f01981863 Revert "Maintain an IP address independent of the forwarding rule for GCE plus bug fixes" 2015-09-25 22:04:35 -07:00
Trevor Pounds 9cd91d111d Use AWS SDK EC2 metadata client. 2015-09-25 17:03:22 -07:00
Trevor Pounds df0718caa1 Migrate source to aws-sdk-go v0.9.9.
Upgrading to aws-sdk-go >= v0.9.0 requires a
source migration via awsmigrate-renamer tool.

see: http://aws.amazon.com/releasenotes/2948141298714307
2015-09-25 17:03:22 -07:00
Alex Robinson 242d28cf68 Fix PR for maintaining a GCE IP independently of the forwarding rule.
This code was in rough shape, so I've fixed the issues with the original
PR as well as a few other changes:
1. Clarify the error messages related to the "gce Addresses" to make it
   clear we're talking about static IP addresses
2. Fix the bug in the original PR, which was a nil pointer dereference
   from passing op to waitForRegionOp when the address doesn't exist.
3. Rearrange the steps of EnsureTCPLoadBalancerDeleted to be the reverse
   of EnsureCreated, which mostly just seems like good practice to me.
   This is also supported by the following two bugs I found :(
4. Fix an independent bug of returning too early if the target pool
   doesn't exist, effectively stranding the firewall. This was likely
   introduced because target pools used to be the last thing deleted,
   so it was previously safe to return there.
5. Fix an independent bug of not returning an error waiting for the
   target pool to be deleted failed. This was very possibly causing
   target pool leaks in our e2e tests. This was similarly due to
   assuming that the target pool was the last thing deleted in the
   function, then having the firewall deletion stuck in after it.
2015-09-25 18:49:51 +00:00
Brendan Burns a5f4484f24 Maintain an IP address independent of the forwarding rule for GCE 2015-09-25 16:36:13 +00:00
Christopher Eck 511e3e1be9 Fix for issue #14466. Don't use tag filtering when looking up which VPC an AWS node is attached to. 2015-09-24 09:51:35 -07:00
Kenneth Shelton 65ad351c7f * Removed host tag tests as they now require real live nodes 2015-09-23 09:10:52 -07:00
Kenneth Shelton aef8ba00e0 Ran gofmt -s 2015-09-23 08:40:51 -07:00
Kenneth Shelton 967fac0adc Changed to use sets utility 2015-09-22 12:26:50 -07:00
Kenneth Shelton 10f79eb490 Updated GCE FW target tag logic to use the set of longest tag prefixes from all instances 2015-09-22 09:31:41 -07:00
Trevor Pounds 1a7f8dc30c Check load balancer and cluster have the same region. 2015-09-21 12:38:00 -07:00
Trevor Pounds 4775a8a5bb Remove superfluous ELB region lookup logic.
The ELB client lookup isn't necessary because the service
does not operate across regions. Instead the client should
be built like the others by querying for the region from
the master node's metadata service.
2015-09-21 12:38:00 -07:00
Trevor Pounds ed8748a6b6 Remove obsolete TCPLoadBalancer interface method. 2015-09-21 12:38:00 -07:00
Daniel Martí 586cb9126a Move pkg/util.Time to pkg/api/unversioned.Time
Along with our time.Duration wrapper, as suggested by @lavalamp.
2015-09-17 17:51:27 -07:00
k8s-merge-robot 22f698f5b0 Merge pull request #13953 from liguangbo/change_iff_to_if_and_only_if
Auto commit by PR queue bot
2015-09-16 08:35:20 -07:00
liguangbo 4df68f03a3 change iff to if and only if to improve annotation readability 2015-09-16 08:29:36 +00:00
Prashanth Balasubramanian bd0eb34aec InstanceGroups 2015-09-14 16:04:41 -07:00
Prashanth Balasubramanian d096aaffd8 BackendServices 2015-09-14 16:04:41 -07:00
Prashanth Balasubramanian 9b929addec GlobalForwardingRules 2015-09-14 16:04:40 -07:00
Prashanth Balasubramanian b3a1c585cd TargetHttpProxy 2015-09-14 16:04:34 -07:00
Prashanth Balasubramanian 83a2dfdef0 UrlMap 2015-09-14 16:02:08 -07:00
Abhishek Shah 44ce4aa423 Create a LB for a K8S with the LB-IP provided by user. 2015-09-10 21:05:06 -07:00
tummychow 78ce5da988 Move util.StringSet into its own package
A lot of packages use StringSet, but they don't use anything else from
the util package. Moving StringSet into another package will shrink
their dependency trees significantly.
2015-09-10 12:04:15 -07:00