68cea87cfd
kubectl: remove unnecessary internal->external conversion before PrintObj
2018-11-02 10:03:52 -07:00
ea7065d471
fix a bug that --tail option does not take effects in 'kubectl logs --selector xx=xx --tail 3'
2018-11-02 18:20:58 +08:00
f824b58ba2
validate args for kubectl config view
2018-11-02 16:17:43 +08:00
3d0c961d57
Fix some golint errors for packages in `pkg/kubectl`
...
- Fix some golint errors for `pkg/kubectl`
- Fix a golint error for `pkg/kubectl/apps`
- Fix all golint errors for `pkg/kubectl/cmd`
- Fix some golint errors for `pkg/kubectl/generate/versioned`
- Fix a golint error for `pkg/kubectl/generate`
- Fix some golint errors for `pkg/kubectl/metricsutil`
- Fix all golint errors for `pkg/kubectl/util`
- Fix all golint errors for `pkg/kubectl/util/slice`
2018-11-02 11:55:40 +08:00
bce51cc574
Merge pull request #70412 from Pingan2017/kubectl-top
...
code cleanup for kubectl top
2018-11-01 15:17:55 -07:00
1e161bb329
kubectl: change legacyscheme codecs to direct codecs (no conversion)
2018-10-31 15:24:22 -07:00
d5865240c5
kubectl: fixes expose bug for workload without selectors
2018-10-30 19:27:10 -07:00
d7de3e5369
Merge pull request #70428 from vithati/users/vithati/kubectlissue546
...
Fix for the 'kubectl explain crd --recursive' goes into an infinite loop issue
2018-10-30 17:41:23 -07:00
05a461c17b
Fix for the 'kubectl explain crd --recursive' goes into an infinite loop issue
2018-10-31 03:30:46 +05:30
901c798681
prevent sorting of PATH dirs
...
This patch allows the `kubectl plugin list` command to display discovered
plugin paths in the same order as they appear in a user's PATH.
Prior to this patch, discovered plugin paths were sorted before being
displayed.
Additionally, any errors encountered while reading from any directory in a
user's PATH will now be printed to stderr at the end of the command's
output.
2018-10-30 14:13:13 -04:00
eea9994112
code cleanup for kubectl top
2018-10-30 15:01:24 +08:00
975e6c0a73
Merge pull request #70039 from liggitt/deployment-rollback
...
Switch kubectl rollout to directly rolling back deployments
2018-10-29 18:52:51 -07:00
57df11bc0f
Switch kubectl rollout to directly rolling back deployments
2018-10-26 23:48:44 -04:00
117c6177c4
Merge pull request #70278 from jhvhs/master
...
Documentation re-formatting
2018-10-26 13:32:00 -07:00
fdcd6de9c0
Update deprecation warning for kubectl run
2018-10-26 16:22:33 +02:00
84ba7e8f69
Documentation re-formatting
...
The closing bracket in the link was automatically included in the link HREF.
Myself and @lurraca used standard markdown formatting to prevent that from happening.
2018-10-26 11:32:36 +01:00
b6fd5d93b2
Merge pull request #69389 from smarterclayton/wait_error
...
kubectl wait must handle errors returned by watch
2018-10-25 09:40:41 -07:00
dad07683b1
Merge pull request #69013 from ibrasho-forks/switch-to-http.Error
...
Update usages of http.ResponseWriter.WriteHeader to use http.Error
2018-10-23 15:31:55 -07:00
1af393d58e
Merge pull request #69866 from xichengliudui/fix181016
...
Remove duplicate words
2018-10-22 15:35:36 -07:00
34196ac946
Merge pull request #69692 from seans3/deployment-util-fix
...
kubectl: copy deployment util dependency into kubectl
2018-10-19 06:07:40 -07:00
d8f9b5b668
Merge pull request #69958 from Pingan2017/cleanup-kubectl-delete
...
remove unneed if block for kubectl delete command
2018-10-18 19:50:53 -07:00
85e460e362
Merge pull request #69809 from sc14aec/create-context-error-messages
...
Fix error messages suggesting invalid flag
2018-10-18 19:50:43 -07:00
34db40fbf5
Merge pull request #67930 from AdamDang/patch-15
...
Fix the returned messaged: statefullset->statefulset
2018-10-18 18:39:03 -07:00
007ad9179c
Merge pull request #69760 from Pingan2017/validate-args
...
validate args for kubectl api-versions/api-resources command
2018-10-18 14:44:00 -07:00
00dd32b167
Merge pull request #69573 from bjhaid/master
...
Opt out of chowning and chmoding from kubectl cp.
2018-10-18 14:43:49 -07:00
ffd4ea963d
kubectl: copy deployment util dependency into kubectl
2018-10-18 12:02:39 -07:00
4d66eeb922
Merge pull request #69709 from seans3/kubectl-translate-fix
...
kubectl: move translated data into kubectl
2018-10-18 10:25:18 -07:00
44bed94f0e
Opt out of chowning and chmoding from kubectl cp.
...
`kubectl cp` relies on tar to extract the copied file/directory in the
container, tar by default attempts to chown/chmod the extracted file
after extraction if the user is the "superuser"(root)
```
--same-owner
try extracting files with the same ownership as exists in the archive
(default for superuser)
-p, --preserve-permissions, --same-permissions
extract information about file permissions (default for superuser)
```
This fails in environment where the container runs as root but is not
granted the OWNER or CHOWN capability.
Before this patch below was the behavior of `kubectl cp`
```
kubectl cp README.md foo-67b6fcbd4c-qjlt6:/tmp
tar: README.md: Cannot change ownership to uid 1000, gid 1000: Operation
not permitted
tar: Exiting with failure status due to previous errors
command terminated with exit code 2
kubectl exec -it foo-67b6fcbd4c-qjlt6 -- ls -l /tmp/README.md
-rw------- 1 1000 1000 3179 Oct 7 22:00 /tmp/README.md
```
After this patch
```
kubectl cp -x a foo-67b6fcbd4c-qjlt6:/
kubectl exec -it foo-67b6fcbd4c-qjlt6 -- ls -l /tmp/README.md
-rw-r--r-- 1 root root 3179 Oct 7 22:00 /tmp/README.md
```
2018-10-18 14:16:06 +00:00
797f0ac660
remove unneed if block for kubectl delete command
2018-10-18 11:33:45 +08:00
b7f8369da2
kubectl: move translated data into kubectl
2018-10-17 10:34:21 -07:00
a76b6ee56a
kubectl: remove internalclientset dependency
2018-10-17 10:23:55 -07:00
0d6f6a680b
Merge pull request #68441 from smarterclayton/describe_dependency
...
Move versioned generators into their own package
2018-10-17 04:24:06 -07:00
5a8afa073f
Dynamic client watchers should be able to handle ERROR gracefully
...
Watch can return type "ERROR" and a metav1.Status object. We need to
handle that during wait, and make it easy to handle the status object.
2018-10-16 12:55:23 -04:00
c21774e9de
Remove defaulting from test that uses kubectl.Scheme
...
The dependency on printers/internalversion was causing kubectl/scheme
to have defaulters registered, which should not be the case. Remove
defaults from the test.
2018-10-16 12:54:41 -04:00
defd8713ac
Fix govet errors in generators
2018-10-16 12:54:40 -04:00
9f5c2aea1a
Cut a dependency between kubectl and the rest of the repo
...
The types referenced in credentialprovider are part of a long term api
and will not change, and kubectl doesn't need to take a dependency on this
package in order to do minimal validation here.
2018-10-16 12:54:40 -04:00
5e905f1f5f
Move versioned generators into their own package
...
pkg/kubectl has a lot of files. Move everything generator related
into pkg/kubectl/generate (generic) or pkg/kubectl/generate/versioned
(type specific).
Move the DescriberFn and GeneratorFn out of kubectl/cmd/util and into
the respective versioned packages, along with tests.
2018-10-16 12:54:40 -04:00
00720ba51d
Fix `gofmt' errors.
2018-10-16 21:31:59 +05:30
c291d3d7ed
Consistently print errors to stderr and add newlines to cordon
2018-10-16 11:16:15 -04:00
d17ce325a6
Fix local copy path for `kubectl cp'.
...
Adds an extra check condition for "." in stripPathShortcuts
so that an empty string is returned, and the correct prefix
index is used untarAll when generating path names.
Resolves : #69804 .
2018-10-16 20:11:54 +05:30
2b2d8ba8c1
validte args for kubectl api-versions/api-resources
2018-10-16 19:22:17 +08:00
c1c718e5ab
Merge pull request #69746 from seans3/printers-fix
...
kubectl: update to use correct printers package
2018-10-15 15:04:42 -07:00
060218a862
Merge pull request #69412 from tossmilestone/scheduler-factory-test
...
Refactor scheduler factory test
2018-10-15 13:52:41 -07:00
e394482373
Remove duplicate words
2018-10-15 15:55:49 -04:00
6a2ef97d46
kubectl: update to use correct printers package
2018-10-15 11:02:19 -07:00
4400996c48
Fix error messages suggesting invalid flag
2018-10-15 16:39:53 +01:00
2fb3ba71f1
Update usages of http.ResponseWriter.WriteHeader to use http.Error
...
Signed-off-by: Ibrahim AshShohail <me@ibrasho.com>
2018-10-14 05:58:00 +03:00
2129bc9f85
Merge pull request #69742 from apelisse/fix-diff-error
...
Rename KUBERNETES_EXTERNAL_DIFF to KUBECTL_EXTERNAL_DIFF
2018-10-13 09:54:52 -07:00
a5b489a3a3
Merge pull request #69751 from seans3/tabwriter-fix
...
kubectl: copy printer tabwriter into kubectl
2018-10-13 03:56:17 -07:00
d84c43120e
Merge pull request #69745 from apelisse/check-dryrun-on-create
...
kubectl dry-run: Check for server didn't work on create
2018-10-12 22:31:28 -07:00
b66d58c1b6
Merge pull request #69446 from seans3/taint-fix
...
kubectl taint: copy core taintutil dependency into kubectl
2018-10-12 16:01:33 -07:00
d076897be7
kubectl: copy printer tabwriter into kubectl
2018-10-12 15:10:46 -07:00
3348f9ae23
Merge pull request #69627 from dims/updating-ghodss-yaml-to-latest-version-2
...
Updating ghodss/yaml and gopkg.in/yaml.v2 to latest version 2
2018-10-12 14:48:26 -07:00
81feb2d03c
Merge pull request #69604 from seans3/podutil-fix
...
kubectl: copy pod utils into util/podutils package
2018-10-12 14:48:11 -07:00
572a028148
kubectl diff: Print error when something goes wrong
2018-10-12 14:12:32 -07:00
8c196137e8
kubectl taint: copy core taintutil dependency into kubectl
2018-10-12 12:39:15 -07:00
54889d581a
kubectl dry-run: Check for server didn't work on create
...
We changed the code to verify that the type supports dry-run, but we've
only done it for patch, not for create, which means that people can
create objects they don't want to create. We can actually simplify the
code by moving the check much earlier in the method, which fixes all
possible bug like this.
2018-10-12 11:30:49 -07:00
8751c1e5a8
Merge pull request #69560 from WanLinghao/clusterrolebinding_description_improve
...
Improve decription of command 'kubectl create clusterrole'
2018-10-12 11:20:11 -07:00
3f102c3980
Merge pull request #69500 from m1kola/LC_MESSAGES_support
...
Makes kubectl respect the `LC_ALL` and `LC_MESSAGES` env vars
2018-10-12 11:19:59 -07:00
e31d14cb10
kubectl diff: Rename KUBERNETES_EXTERNAL_DIFF to KUBECTL_EXTERNAL_DIFF
2018-10-12 10:56:16 -07:00
6fc89ae92d
Merge pull request #69633 from soltysh/move_templates
...
Move pkg/kubectl/cmd/templates -> pkg/kubectl/util/templates
2018-10-12 10:07:07 -07:00
a96a390d92
Refactor scheduler factory test
...
Use `k8s.io/client-go/kubernetes/fake.Clientset` as the fake k8s client.
Signed-off-by: He Xiaoxi <xxhe@alauda.io>
2018-10-12 14:39:08 +08:00
b1ea6dcfbc
Merge pull request #69449 from apelisse/verify-dry-run-support
...
kubectl: Verify dry run support
2018-10-11 13:45:12 -07:00
e0c9189082
Manual changes to package visibility
2018-10-11 22:01:06 +02:00
61899e1654
Generated changes
2018-10-11 22:01:06 +02:00
21789b85a6
Move pkg/kubectl/cmd/templates -> pkg/kubectl/util/temlpates
2018-10-11 22:01:03 +02:00
75a137616e
Adds support for `LC_MESSAGES` and `LC_ALL`
...
Implements the following locale lookup priority order: `LC_MESSAGES`, `LC_ALL`, `LANG`.
2018-10-11 20:06:38 +01:00
5f8f607c27
kubectl: copy pod utils into util/podutils package
2018-10-11 10:49:52 -07:00
128b8fe4fe
Merge pull request #69477 from m1kola/port-forward_named_port
...
Adds support of named ports for kubectl port-forward
2018-10-10 16:46:35 -07:00
f2e2a930f9
dry-run: Verify if the object supports dry-run
...
For each object, first we verify if they have a dryRun parameter in the
openapi for the patch verb. If we can't find the object, we assume that
CRD will behave like "namespace". So we check if namespace supports
dryRun. If it does, then we verify that the resource is a CRD.
2018-10-10 08:56:09 -07:00
a0460a5238
dry-run: Create class to find if a type is a CRD
...
Finding out if a Group-version-kind is a CRD is useful, since we want to
detect dry-run ability differently for CRDs.
2018-10-10 08:56:09 -07:00
ae735282ad
Create a method to check dryRun is supported
...
We don't want to run dryRun requests against servers that don't support
dry-run, since they might ignore the flag and just persist the unwanted
changes.
This creates a new method that checks in the OpenAPI if the dryRun
parameter can be used.
2018-10-10 08:55:33 -07:00
65da81f42e
Fix up test cases
...
Change-Id: Ib9245f78dbfb88f1f37a26ca64bf80d3f78d7497
2018-10-10 10:24:09 -04:00
54a73630f1
kubectl factory client access: Moves remaining internal references into callers
2018-10-09 13:34:30 -07:00
830e09cc96
Merge pull request #46517 from goblain/cli-port-forward-listen
...
port-forward listen on address
2018-10-09 12:38:55 -07:00
137193faaf
Merge pull request #69448 from seans3/env-resolve-fix
...
kubectl env resolve: copy core fieldpath and resource dependencies into kubectl
2018-10-09 11:25:43 -07:00
48086eb7d4
Merge pull request #69543 from seans3/rollback-fix
...
kubectl rollback: remove duplicated code for printing pod template
2018-10-09 10:14:39 -07:00
637ba154c8
Merge pull request #65189 from juanvallejo/jvallejo/path-fixes-cmd-copy
...
fix paths w shortcuts when copying from pods
2018-10-09 10:14:28 -07:00
e55a28d169
fix paths w shortcuts when copying from pods
...
Addresses an issue where copying from a remote location containing path
shortcuts (podName:../../../tmp/foo) causes an index out of range panic.
2018-10-09 10:27:54 -04:00
5958baa163
improve decription of command 'kubectl create clusterrole'
2018-10-09 15:50:30 +08:00
20a54b312c
kubectl rollback: remove duplicated code for printing pod template
2018-10-08 15:39:16 -07:00
50c5b379b7
kubectl env resolve: copy core fieldpath and resource dependencies into kubectl
2018-10-08 14:50:20 -07:00
d4c4871852
Merge pull request #69413 from seans3/rollback-fix
...
kubectl rollback: remove legacyscheme dependency
2018-10-08 13:02:19 -07:00
a19e84e001
Allows to use named ports in the kubectl portforward
2018-10-08 20:58:22 +01:00
4643c6e95e
port-forward listen on address
...
adds an address flag to kubectl port-forward to allow to bind to a different ip then localhost
2018-10-07 22:18:18 +02:00
add731dff1
Manual changes to package visibility and test dependencies
2018-10-06 18:44:05 +02:00
1d9617d8e1
Generated changes
2018-10-06 18:44:05 +02:00
55d5df8a36
React to moves
2018-10-06 18:44:05 +02:00
33adf367f9
Move each kubectl command to a separate directory
2018-10-06 18:44:05 +02:00
187e2e01c9
Move scheduler cache interface and implementation to pkg/scheduler/internal/cache
2018-10-06 20:48:59 +08:00
97b2992dc1
Update gofmt for go1.11
2018-10-05 12:59:38 -07:00
fecb5edf8a
Merge pull request #66266 from wking/kubectl-drain-drop-backOff
...
kubectl: Drop backOff from DrainOptions
2018-10-04 19:34:34 -07:00
5800937698
Merge pull request #69398 from seans3/run-test-fix
...
kubectl run test: remove legacyscheme dependency and cleanups
2018-10-04 15:59:29 -07:00
34e2688835
Merge pull request #69404 from seans3/fake-test-fix
...
kubectl fake test factory: replace legacyscheme with kubectl scheme
2018-10-04 13:40:20 -07:00
f7df7f8a25
Merge pull request #69335 from seans3/set-tests-fix
...
kubectl set tests: remove testapi core dependency
2018-10-04 13:40:10 -07:00
95ec1f79b9
kubectl rollback: remove legacyscheme dependency
2018-10-04 13:13:32 -07:00
686f29fbc4
Merge pull request #66301 from wking/kubectl-drain-drop-typer
...
kubectl: Drop typer from DrainOptions
2018-10-04 12:28:57 -07:00
5589c5b3cb
Merge pull request #69401 from seans3/helpers-test-fix
...
kubectl helpers test: remove core dependencies
2018-10-04 10:09:55 -07:00
7136a3e4b2
Merge pull request #67880 from chenyb4/kubectl_openapi
...
Add kubectl openapi doc import comment
2018-10-04 01:05:15 -07:00
2d1ef05ad1
Merge pull request #69295 from deads2k/kbuectl-13-wait-false
...
allow condition value to specified for kubectl wait
2018-10-03 21:32:12 -07:00
Sean Sullivan