Commit Graph

2378 Commits (750881c0ab62a9f59d53582bc33826caa167aa83)

Author SHA1 Message Date
andyzhangx 53145d793e change azure disk host cache to ReadOnly by default
change cachingMode default value for azure disk PV

revert back to ReadWrite in azure disk PV setting
2019-01-04 02:37:12 +00:00
Michelle Au 7a4f906f25 Rename UnmountMountPoint to CleanupMountPoint 2019-01-03 16:35:54 -08:00
Michelle Au 002a4e33d8 Move unmount volume util from pkg/volume/util to pkg/util/mount 2019-01-03 16:34:53 -08:00
mlmhl 34a2f23dc1 use json format to get rbd image size 2018-12-29 19:45:13 +08:00
Jordan Liggitt 73dcfe12da Stop checking VolumeScheduling feature gate 2018-12-27 17:45:45 -05:00
Neven Miculinic 49a966cb1a Added missing secret key in the message 2018-12-19 13:03:11 +01:00
Kubernetes Prow Robot cd02e752bf
Merge pull request #71509 from cofyc/fix71438
Fix device mountable volume names in DSW
2018-12-19 00:51:52 -08:00
Michelle Au 8954c11719 Cleanup volume approvers 2018-12-18 15:12:13 -08:00
Michelle Au 0b6fa24f65 Add msau42 to top-level volume approvers 2018-12-18 15:11:42 -08:00
andyzhangx 81a123dbed fix kubelet log flushing issue in azure disk 2018-12-12 08:20:00 +00:00
Yecheng Fu 67552a8f6e Add unit test to verify generated volume names. 2018-12-12 13:03:21 +08:00
Alexander Trost f9e7ba07b7
rbd: log error when unable to get Secret
Signed-off-by: Alexander Trost <galexrt@googlemail.com>
2018-12-11 19:31:21 +01:00
Kubernetes Prow Robot 13985d2674
Merge pull request #70172 from WanLinghao/configmap_volume_support_monitor
Support more volume types in stats/summary endpoint including configm…
2018-12-09 18:36:58 -08:00
Kubernetes Prow Robot 83b3baaf58
Merge pull request #71581 from saad-ali/fixCSILogEventSpam
Reduce CSI log and event spam
2018-11-30 22:27:27 -08:00
Yecheng Fu 5ada29ac16 Rename GetUniqueVolumeNameForNonAttachableVolume to GetUniqueVolumeNameFromSpecWithPod 2018-12-01 12:25:32 +08:00
k8s-ci-robot 79e5cb2cb7
Merge pull request #71302 from liggitt/verify-unit-test-feature-gates
Split mutable and read-only access to feature gates, limit tests to readonly access
2018-11-29 21:45:12 -08:00
k8s-ci-robot 2fd1949b7f
Merge pull request #71294 from Chenditang/verify-golint
Fix golint verify errors.
2018-11-29 21:45:02 -08:00
saad-ali 2251bf0c21 Ensure volume mount err checking done inside op
Ensure volume mount error checking is done inside the operation so that
failures get handled with exponential backoff, etc.
2018-11-29 16:52:24 -08:00
k8s-ci-robot 6be4f1bbf3
Merge pull request #71471 from mshaverdo/panic_in_attach_detach_controller
Fix panic in attachDetachController
2018-11-29 09:30:21 -08:00
k8s-ci-robot d80614d4a7
Merge pull request #70860 from humblec/getVolumeName
GlusterFS: Move GetVolumeName() to unimplemented func.
2018-11-29 07:36:28 -08:00
k8s-ci-robot cc153a9cd5
Merge pull request #70612 from jianglingxia/jlx201811031409
delete new defined para name in fc volume
2018-11-29 07:36:07 -08:00
Mikhail Shaverdo a29981640f Fix nil pointer dereference panic in attachDetachController
add check `attachableVolumePlugin == nil` to operationGenerator.GenerateDetachVolumeFunc()
2018-11-29 13:10:07 +03:00
k8s-ci-robot d0e8e6b78f
Merge pull request #70613 from jianglingxia/jlx201811031619
fix golint problem of volume cephfs/iscsi/nfs
2018-11-29 02:01:13 -08:00
k8s-ci-robot e5326f22ea
Merge pull request #70471 from xichengliudui/fix181031
Fix some typos
2018-11-29 00:48:16 -08:00
k8s-ci-robot b548d92b7c
Merge pull request #70392 from harsh-px/cfg-port
Lookup PX api port from k8s service
2018-11-28 23:31:50 -08:00
saad-ali 18050e308c Allow CSI Drivers suporting 0.x/1.x to use old dir
Allow drivers implmenting both CSI 0.x and 1.x to use the old volume
plugin directory in addition to the the new volume plugin directory.
2018-11-28 11:11:37 -08:00
saad-ali aa8244beb5 Modify CSI to handle both 0.3 and 1.0
Modify the CSI volume plugin to handle CSI version 0.x as well as 1.x
2018-11-21 18:37:31 -08:00
saad-ali d1b44857ad Add missing feature gate to CSI driver uninstall 2018-11-21 18:37:31 -08:00
saad-ali 2b44ec5e9c Reduce csipb dependencies
Remove csipb dependency from everywhere except the CSI client in
preperation for supporting multiple CSI clients.
2018-11-21 18:37:31 -08:00
saad-ali 8f666d9e41 Modify kubelet watcher to support old versions
Modify kubelet plugin watcher to support older CSI drivers that use an
the old plugins directory for socket registration.
Also modify CSI plugin registration to support multiple versions of CSI
registering with the same name.
2018-11-21 18:37:31 -08:00
Jordan Liggitt 2498ca7606 drop VerifyFeatureGatesUnchanged 2018-11-21 11:51:33 -05:00
chendt.fnst 80de428f49 Fix golint verify errors.
**What type of PR is this?**
/kind cleanup

**What this PR does / why we need it**:
$ hack/verify-golint.sh
Errors from golint:
pkg/cloudprovider/providers/aws/aws_fakes.go:357:9: if block ends with a return statement, so drop this else and outdent its block
pkg/volume/util/util.go:204:9: if block ends with a return statement, so drop this else and outdent its block

**Which issue(s) this PR fixes** *(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged)*:

**Special notes for your reviewer**:

**Release note**:
```
NONE
```
2018-11-21 09:11:20 +08:00
Jing Xu 562d0fea53 Handle failed attach operation leave uncertain volume attach state
This commit adds the unit tests for the PR. It also includes some files
that are affected by the function name changes.
2018-11-19 17:21:49 -08:00
Jing Xu 47331cf0a2 WIP: Handle failed attach operation leave uncertain volume attach state
This PR fixes issue #32727.

When an attach operation fails, it is still possible that the volume
will be attached to the node later. This PR adds the logic to record the
volume to node with attached state no matter whether the operation
succedded or not. If the operation fails, mark the attached state to
false. If the operation succeeded, mark the attached state to true. The
reconciler will still issue attach operation until it returns
successfully. If the pod is removed in the mean time, the reconciler
will issue detach operations for all the volumes no matter what is the
attached state.
2018-11-19 17:19:10 -08:00
jianglingxia 6159bab94a
Merge branch 'master' into jlx201811031619 2018-11-17 12:53:21 +08:00
jianglingxia 0094e05975 fix golint problem of volume cephfs/iscsi/nfs 2018-11-17 12:50:47 +08:00
k8s-ci-robot ec2e767e59
Merge pull request #71167 from msau42/block-beta
Promote raw block volume support to beta
2018-11-16 20:28:03 -08:00
k8s-ci-robot 4821291398
Merge pull request #71095 from msau42/csi-devicepath
Remove devicePath dependency for CSI volumes
2018-11-16 18:22:24 -08:00
k8s-ci-robot f877b2257a
Merge pull request #71074 from jsafrane/volume-manager-races
Fix race between MountVolume and UnmountDevice
2018-11-16 18:22:14 -08:00
Michelle Au 974d47ecf8 Remove devicePath dependency for CSI volumes 2018-11-16 15:40:35 -08:00
Cheng Xing ca18690ceb Augmenting API call retry in nodeinfomanager 2018-11-16 13:00:22 -08:00
Matthew Wong dd517c9ff2 Update all tests to account for BlockVolume enabled by default 2018-11-16 13:38:59 -05:00
Jordan Liggitt 248d661327 Add tests to ensure storage feature gate changes don't escape packages 2018-11-16 10:52:53 -05:00
Jordan Liggitt 358c092abe fix storage unit tests leaking feature flag changes 2018-11-16 10:52:52 -05:00
Michelle Au fd64c08240 Fix storage feature gate test setting 2018-11-16 10:49:40 -05:00
Jan Safranek 5283537401 Fixed clearing of devicePath after UnmountDevice
UnmountDevice must not clear devicepath, because such devicePath
may come from node.status (e.g. on AWS) and subsequent MountDevice
operation (that may be already enqueued) needs it.
2018-11-16 13:24:42 +01:00
k8s-ci-robot 6fc60428a7
Merge pull request #71020 from saad-ali/updateCSI10
Bump CSI Spec to 1.0.0 and gRPC to 1.13.0
2018-11-16 01:53:21 -08:00
k8s-ci-robot cde4c9ebe1
Merge pull request #68635 from mkimuram/issue/68424
CSI block volume refactor to fix target path
2018-11-15 21:35:42 -08:00
jianglingxia 371088e83c delete new defined para name in fc volume 2018-11-16 09:40:11 +08:00
saad-ali 09d3dce38a Update CSI client to pick up CSI v1.0.0 changes 2018-11-15 16:39:59 -08:00
Masaki Kimura 9c56b53390 Fix the comment for csi block pathes to make look the same to filesystem 2018-11-15 23:26:19 +00:00
k8s-ci-robot 726c07eb26
Merge pull request #69929 from jsafrane/csi-ga
Promote CSIPersistentVolume feature to GA
2018-11-14 20:34:58 -08:00
Masaki Kimura 6d7b5f1d1b Delegate creation of publishPath to driver and allow creating device file directly 2018-11-15 01:14:12 +00:00
Masaki Kimura d8c6fe5202 Change stagingPath to be a directory 2018-11-14 20:53:28 +00:00
k8s-ci-robot 5a84dffc75
Merge pull request #71007 from mikedanese/allowdefault
TokenRequestProjections should allow API server to default empty audience
2018-11-14 11:38:16 -08:00
Masaki Kimura f0354ad605 Fix for adding block volume support to CSI RBD driver 2018-11-14 19:20:56 +00:00
Michelle Au 498cd61f41 Add volumeattachment status subresource 2018-11-14 14:01:16 +01:00
Mike Danese 3167b15908 TokenRequestProjections should allow API server to default empty audience 2018-11-13 20:25:16 -08:00
k8s-ci-robot d3a21cf5a2
Merge pull request #70848 from cofyc/fix64590
Improve usability of CSI plugin metrics
2018-11-13 19:45:43 -08:00
Deep Debroy 05759a9091 Handle validation of drivers in Spec and Status
Signed-off-by: Deep Debroy <ddebroy@docker.com>
2018-11-13 02:35:30 -08:00
Deep Debroy af73d7bdc1 Add validation of CSINodeInfo before Create/Update calls
Signed-off-by: Deep Debroy <ddebroy@docker.com>
2018-11-13 00:48:56 -08:00
Harsh Desai fdc60629c9 Update portworx to move from glog to klog
Signed-off-by: Harsh Desai <harsh@portworx.com>
2018-11-12 10:59:57 -08:00
Harsh Desai db93c5fcbe cache portworx API port
- reused client whenever possible
- refactor get client function into explicit cluster-wide and local functions

Signed-off-by: Harsh Desai <harsh@portworx.com>
2018-11-12 10:51:36 -08:00
Harsh Desai c6a2d24fa2 Lookup PX api port from k8s service
Fixes #70033

Signed-off-by: Harsh Desai <harsh@portworx.com>
2018-11-12 10:50:12 -08:00
Yecheng Fu dfe0a08f05 Improve usability of CSI plugin metrics
Use full qualified plugin name if volume spec is present.
2018-11-12 09:21:49 +08:00
Davanum Srinivas 954996e231
Move from glog to klog
- Move from the old github.com/golang/glog to k8s.io/klog
- klog as explicit InitFlags() so we add them as necessary
- we update the other repositories that we vendor that made a similar
change from glog to klog
  * github.com/kubernetes/repo-infra
  * k8s.io/gengo/
  * k8s.io/kube-openapi/
  * github.com/google/cadvisor
- Entirely remove all references to glog
- Fix some tests by explicit InitFlags in their init() methods

Change-Id: I92db545ff36fcec83afe98f550c9e630098b3135
2018-11-10 07:50:31 -05:00
k8s-ci-robot e133ab274d
Merge pull request #70515 from davidz627/feature/csiNodeInfo
Add explicit "Installed" field to CSINodeInfo and change update semantics
2018-11-09 06:42:09 -08:00
Humble Chirammal e9ed21988d GetVolumeName() is used in a few places, all of which are not applicable to gluster:
AD controller
    kubelet volume manager actual/desired sw for attachable volumes
    volume reconstruction

This is a followup PR based on comment#
https://github.com/kubernetes/kubernetes/pull/60195#discussion_r231675596

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2018-11-09 16:09:12 +05:30
David Zhu 06f3b26012 Change semantics of driver install and uninstall in CSINodeInfo to use new fields. 2018-11-08 19:45:01 -08:00
David Zhu 4621887037 Updated test files with new fields 2018-11-08 19:45:01 -08:00
k8s-ci-robot 3c10143967
Merge pull request #60195 from humblec/glusterfs-pvspec-3
Refactor GlusterFS PV spec.
2018-11-08 00:24:39 -08:00
fanzhangio dcb3a5fac7 Feature: Implements Raw Block Volume Support for in-tree vSphere plugin
- add raw block volume support for vsphere volume provisioner
- set VolumeMode and any FSType in vsphere volume dynamic provision if feature
BlockVolume enabled
- implement BlockVolumePlugin, BlockVolumeMapper, BlockVolumeUnmapper interfaces.
- add tests for vsphere block volume
2018-11-07 12:16:12 -08:00
Humble Chirammal bdb051c72d Refactor GlusterFS PV spec.
This patch introduces glusterfsPersistentVolumeSource addition
to glusterfsVolumeSource. All fields remains same as glusterfsVolumeSource
with an addition of a new field
called `EndpointsNamespace` to define namespace of endpoint in the
spec.

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2018-11-06 15:51:01 +05:30
k8s-ci-robot 839c4ec7c3
Merge pull request #70609 from jianglingxia/jlx201811031314
delete some para no need used in local volume
2018-11-05 19:05:03 -08:00
k8s-ci-robot e40209a433
Merge pull request #70607 from jianglingxia/jlx201811021606
fix local volume getVolumeSourceFSType func by golint
2018-11-05 19:04:54 -08:00
k8s-ci-robot 703ac550a3
Merge pull request #68880 from houjun41544/20180920-downward
Remove unused function in downwardapi.go
2018-11-05 16:32:15 -08:00
k8s-ci-robot 15de3eed09
Merge pull request #70461 from mysunshine92/golint
fix golint errors in pkg/volume/*
2018-11-05 11:41:47 -08:00
k8s-ci-robot f44a8a4cac
Merge pull request #69419 from humblec/pvc-rfc-63
glusterfs: Allow admin to enable or disable custom endpoint/service names
2018-11-04 22:36:40 -08:00
jianglingxia 0c79df1bcb delete some para no need used in local volume 2018-11-03 14:03:47 +08:00
jianglingxia 4ead52e0f5 fix local volume getVolumeSourceFSType func by golint 2018-11-03 12:56:10 +08:00
k8s-ci-robot af583b1c5f
Merge pull request #70540 from gnufied/fix-csi-attach-limit-node-update
Fix csi attach limit node update
2018-11-02 16:44:30 -07:00
k8s-ci-robot 69f5f5eff2
Merge pull request #67978 from WanLinghao/token_controller_improve
remove idle tokens in kubelet token manager
2018-11-02 12:28:47 -07:00
Hemant Kumar 889468b1ab Fix csi volume attach limit 2018-11-02 15:10:31 -04:00
k8s-ci-robot 6813ebb568
Merge pull request #67851 from aniket-s-kulkarni/flexvolume-resize-implementation
Flexvolume resize implementation
2018-11-02 10:47:01 -07:00
k8s-ci-robot 6c0684f010
Merge pull request #70548 from vladimirvivien/csi-plugin-deregister
CSI Kubelet Plugin Watcher DeRegistration
2018-11-02 08:39:06 -07:00
k8s-ci-robot 45550cadbe
Merge pull request #70477 from andyzhangx/azure-ultrassd-sdk
add azure UltraSSD disk support
2018-11-01 22:16:55 -07:00
k8s-ci-robot 4351cea80c
Merge pull request #70046 from cheftako/lintCleanGce
Fixed lint errors for pkg/cloudprovider/providers/gce.
2018-11-01 13:44:06 -07:00
k8s-ci-robot 133f662610
Merge pull request #70408 from idealhack/fix-golint-pkg-volume-util
Fix golint error for `pkg/volume/util/resize_util.go`
2018-11-01 11:11:22 -07:00
Vladimir Vivien df280251e7 CSI Kubelet Plugin Watcher unregistration 2018-11-01 13:53:55 -04:00
qingsenLi 3ac9b27b2a remove repetitive word in annotation 2018-11-02 00:54:41 +08:00
yameiwang 18a904d187 fix golint errors in pkg/volume/* 2018-11-01 16:52:56 +08:00
andyzhangx f1bd292c76 add ultrassd support
update stagin Godeps.json

update godeps license

fix test failure

fix comments
2018-11-01 06:30:15 +00:00
Humble Chirammal 734da0edb1 glusterfs: Allow admin to provide custom endpoint/service name prefix
This patch introduces a new SC parameter called `customepnameprefix`
in glusterfs plugin. This new storageclass parameter allow admins
to create endpoints and services with mentioned prefix.
If this parameter has not been set or if its empty,
default prefix string ie "glusterfs-dynamic-" will be used for ep/svc
name.

This patch address below issues#

https://github.com/kubernetes/kubernetes/issues/53939
https://github.com/kubernetes/kubernetes/issues/56379

Additional Ref# #
https://github.com/kubernetes/kubernetes/issues/56380

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2018-10-31 18:06:40 +05:30
andyzhangx d210b4bcf3 upgrade azure sdk to support ultra ssd
update Godeps.json

update azure sdk for ultrassd support

update bazel

fix build failure
2018-10-31 10:08:52 +00:00
xichengliudui 8477389e7c Fix some types
Fix some typos
2018-10-31 04:05:25 -04:00
k8s-ci-robot 56796f3bf4
Merge pull request #67898 from NetApp/csi-mount-options
Add support for mount options to CSI drivers
2018-10-30 19:48:20 -07:00
k8s-ci-robot 63a7e06eb5
Merge pull request #69484 from ddebroy/ddebroy-winpipe1
Correctly handle named pipe host mounts for Windows
2018-10-30 16:15:57 -07:00
k8s-ci-robot a49e4e128e
Merge pull request #69708 from mcrute/fix-aws-imports
Fix AWS volume and cloud provider import order
2018-10-30 13:44:50 -07:00
Mike Crute 49df100af9 fix AWS volume and cloud provider import order 2018-10-30 08:18:45 -07:00
k8s-ci-robot 650357ae53
Merge pull request #70306 from obnoxxx/glusterfs-improve-comments
Glusterfs: improve some comments
2018-10-30 06:25:20 -07:00
k8s-ci-robot c7f0616482
Merge pull request #70236 from mlmhl/cephfs
Improve cephfs fuse error log level
2018-10-30 06:25:10 -07:00
Yang Li a4fff0d32c Fix golint error for `pkg/volume/util/resize_util.go` 2018-10-30 13:01:54 +08:00
k8s-ci-robot 070a35f9c3
Merge pull request #69544 from justinsb/tempdir_cleanup
Introduce test harness into unit tests
2018-10-29 20:07:27 -07:00
mlmhl 12e007d33c improve cephfs fuse error log level 2018-10-30 09:56:47 +08:00
walter 735ad9ed63 Fixed lint errors for pkg/cloudprovider/providers/gce.
Fixed minor issues.
Cleaned up from merge errors.
2018-10-29 11:52:24 -07:00
Michael Adam 870bf314fe glusterfs: remove a redundant comment
This comment exactly states what the line below it does.
There's no point in keeping it.

Signed-off-by: Michael Adam <obnox@redhat.com>
2018-10-29 17:07:08 +01:00
Michael Adam 465bb06533 glusterfs: improve a comment block
moving it to the function it explains and
rewording slightly.

Signed-off-by: Michael Adam <obnox@redhat.com>
2018-10-29 17:07:08 +01:00
Humble Chirammal a6759a7b22 Fix a typo in source code comment
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2018-10-26 20:01:19 +05:30
Humble Chirammal 5bd0b5d841 GlusterFS: Use pvc uid instead of pvc name in glusterfs endpoint name.
At present, endpoints and services are created
for glusterfs pvcs are in form of glusterfs-dynamic-<PVC name>
however this could cause issue if user deletes a PVC and immediately
creates a new one with the same name, PV controller will try to delete
the old PV and its endpoint and at the same the controller will try to create new PV
and the same endpoint. Depending on which event reaches the
controller first, it may create new PV, check that endpoints exists,
then delete the old PVC and delete endpoints already used by the new PV.

This patch changes the endpoint/service name to below format:

`glusterfs-dynamic-<PVC UUID>`.

By the uniqueness of UUID, above mentioned issue will no longer be present.

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2018-10-26 20:00:02 +05:30
Deep Debroy 119e2a1d43 Address CR comments and add more tests
Signed-off-by: Deep Debroy <ddebroy@docker.com>
2018-10-26 00:29:27 -07:00
Aniket Kulkarni 75350d11e9 adding support for expanding in use persistent volumes for Flex 2018-10-24 15:31:16 -04:00
k8s-ci-robot 3abb9f0ad7
Merge pull request #70002 from andyzhangx/getdisklun
fix azure disk attachment error on Linux
2018-10-24 10:53:51 -07:00
WanLinghao 83a9db5148 Support more volume types in stats/summary endpoint including configmap, secret, projected 2018-10-24 14:19:12 +08:00
k8s-ci-robot 322d0df3d2
Merge pull request #70053 from gman0/fix-csiclient-lock
CSI client: added missing lock when reading from csiDrivers
2018-10-23 02:08:32 -07:00
k8s-ci-robot 91ac9d50fa
Merge pull request #69371 from pivotal-k8s/fix-well-tested-fake
Add tests for `csiDriverClient`
2018-10-22 18:28:37 -07:00
andyzhangx f69068753a improve azure disk attachment perf on Linux
use new getDiskLUN func in linux
2018-10-22 02:24:15 +00:00
WanLinghao 7df1078d6f Currently, kubelet token mamanger only clean tokens who are expired. For tokens with long expiration, if the pod who creates them got killed or evicted, those tokens may stay in kubelet's memory until they are expired. It's bad for kubelet and node itself. After this patch, each time a pod was deleted, token manager would clean related tokens. 2018-10-22 09:32:59 +08:00
gman 571ad40fa1 CSI client: added missing lock when reading from csiDrivers 2018-10-20 22:43:17 +02:00
andyzhangx 79a5bb6216 add more logging for azure disk diagnostics 2018-10-19 08:11:49 +00:00
k8s-ci-robot b5c25728ec
Merge pull request #69718 from andyzhangx/azurefile-premium
support Azure premium file for azure file plugin
2018-10-18 05:18:50 -07:00
andyzhangx bc2c79a43a add azure premium file support
update bazel and fix goftm

use defaultStorageAccountKind

fix test failure

update godep license file

fix staging godeps issue

update staging godeps

fix comments, use one API call for file creation
2018-10-17 03:27:29 +00:00
k8s-ci-robot c585d13e36
Merge pull request #69854 from andyzhangx/azurefile-permission
change default azure file mount permission to 0777
2018-10-16 19:26:25 -07:00
k8s-ci-robot 5a0220a6d8
Merge pull request #69387 from mcrute/master
fix golint for pkg/cloudprovider/providers/aws
2018-10-16 17:53:02 -07:00
k8s-ci-robot 1d3d1e8968
Merge pull request #68518 from leakingtapan/golint-fix-volume-empty-dir
fix golint issues for pkg/volume/empty_dir
2018-10-16 17:52:44 -07:00
andyzhangx ccac3a51f3 change azure file mount permission to 0777 2018-10-16 07:51:05 +00:00
k8s-ci-robot d54e0fc0bc
Merge pull request #69670 from atlassian/simplify-rand-seed
Simplify rand seeding
2018-10-15 13:53:01 -07:00
Cheng Pan 42ef7ae8d5 fix golint issues for pkg/volume/empty_dir 2018-10-15 20:00:36 +00:00
Hannes Hörl 6330cee9ea Add tests for `csiDriverClient`
As #69219 outlines the unit tests in `csi_client_test.go` where not
testing the actual implementation of the `csiDriverClient` but was
testing the fake.

To fix this, we changed the `csiDriverClient` to use a
`nodeClientCreator` which is responsible for creating a new
`NodeClient`, a real one in prod and a fake one in the tests.

The setup of the gRPC connection has been pushed into that creator. The
node client uses that connection; that's transparent to the driver
client. It's the responsibility of the driver client to close the
connection when it is done with the node client. To achieve this, we
have the node client creator return a closer which handles the
connection teardown.

In the tests we now also check if the driver client actually calls
this closer, thus closing the gRPC connection.

Closes: #69219

Co-authored-by: Rosie Bloxsom <rbloxsom@pivotal.io>
Co-authored-by: Maria Ntalla <mntalla@pivotal.io>
2018-10-15 20:55:37 +01:00
k8s-ci-robot 2119512b9e
Merge pull request #68491 from leakingtapan/golint-fix-volume-util
fix golint issue for pkg/volume/util
2018-10-15 11:40:32 -07:00
k8s-ci-robot 296ea67c84
Merge pull request #69556 from leakingtapan/golint-fix-volume-fc-flock
Fix golint issues for pkg/volume/{fc,flocker} packages
2018-10-14 10:43:59 -07:00
Deep Debroy f8a69f1086 Broaden scope of host path types to skip processing in Windows
Signed-off-by: Deep Debroy <ddebroy@docker.com>
2018-10-12 19:57:08 -07:00
Ben Swartzlander 85b224856d Add unit tests for CSI mount options 2018-10-12 12:16:20 -04:00
Ben Swartzlander 65d3beb820 Add support for mount options to CSI drivers 2018-10-11 13:39:19 -04:00
Mikhail Mazurskiy f5e9c0473c
Remove unnecessary random re-seeding
Package k8s.io/apimachinery/pkg/util/rand seeds the random based on time
during the package initialization, so no need to re-seed it.
2018-10-11 22:02:01 +11:00
Mikhail Mazurskiy 3a243090a5
Simplify random seed initialization
There is no need to set the time zone as the result does not
depend on it
2018-10-11 21:01:15 +11:00
k8s-ci-robot 43d61f42f1
Merge pull request #69187 from SandeepPissay/addOwner
Adding myself as OWNER for vSphere Cloud Provider.
2018-10-10 20:24:37 -07:00
k8s-ci-robot 3ac3889838
Merge pull request #69558 from andyzhangx/GetVolumeLimits-warning
fix GetVolumeLimits log flushing issue
2018-10-10 16:46:54 -07:00
andyzhangx 12284c9817 upgrade azure go sdk for azure file premium support
update azure sdk for azure file premium support

update azure sdk to support azure file premium

update bazel
2018-10-09 13:28:51 +00:00
lichuqiang 814dbac3df add provision failure hook in fake volume plugin 2018-10-09 19:16:27 +08:00
andyzhangx e67b369dfa fix GetVolumeLimits log flushing issue
fix logging flushing issue in GetVolumeLimits
2018-10-09 07:12:33 +00:00
Cheng Pan 065e4543b7 Fix golint issues for pkg/volume/{fc,flocker} packages 2018-10-09 06:04:00 +00:00
Justin Santa Barbara 58fc3c8c23 Introduce test harness into unit tests
The harness lets us execute code after the test has completed.

Use it to clean-up temp dirs in the flexvolume tests (initially).
2018-10-08 18:44:05 -04:00
Mike Crute 4d65f20ff6 fix golint for pkg/cloudprovider/providers/aws 2018-10-08 12:08:56 -07:00
Jan Safranek 362be3a58b Retry attaching multipath iSCSI volumes
Don't mount single path instead of multipath volumes and always wait until
at least 2 paths are available. Try up to 3 times to get all paths. Try 5
times to get at last 2 paths.
2018-10-08 13:00:24 +02:00
k8s-ci-robot a29b093a56
Merge pull request #69451 from justinsb/sort_bind_options
Sort bind options in JoinMountOptions
2018-10-06 21:29:51 -07:00
k8s-ci-robot 0f17e9ade6
Merge pull request #69386 from cblecker/go-1.11
Update to go1.11.1
2018-10-05 17:35:51 -07:00
Deep Debroy b4bb5dd430 Correctly handle named pipe host mounts for Windows
Signed-off-by: Deep Debroy <ddebroy@docker.com>
2018-10-05 16:46:04 -07:00
k8s-ci-robot 13705ac81e
Merge pull request #68310 from cheftako/cpiMove
Moving the cloudprovider interface to staging.
2018-10-05 13:29:01 -07:00
Christoph Blecker 97b2992dc1
Update gofmt for go1.11 2018-10-05 12:59:38 -07:00
Justin Santa Barbara 3c4789b464 Sort bind options in JoinMountOptions
We were not sorting them previously, which made the order
non-deterministic.  If we believe the order doesn't matter, let's pick
a consistent order to minimize the chances of a rare flake.

This also simplifies the unit tests, which were flaking
not-very-rarely, e.g. with

`bazel test //pkg/volume/awsebs/... --runs_per_test=8`
2018-10-04 21:39:13 -04:00
k8s-ci-robot 6e850768a6
Merge pull request #69115 from mkimuram/issue/69114
Fix descriptor lock release logic for block volume unmapDevice
2018-10-04 18:19:36 -07:00
Walter Fender f3f46d5f5a Moving the cloudprovider interface to staging.
Individual implementations are not yet being moved.
Fixed all dependencies which call the interface.
Fixed golint exceptions to reflect the move.
Added project info as per @dims and
https://github.com/kubernetes/kubernetes-template-project.
Added dims to the security contacts.
Fixed minor issues.
Added missing template files.
Copied ControllerClientBuilder interface to cp.
This allows us to break the only dependency on K8s/K8s.
Added TODO to ControllerClientBuilder.
Fixed GoDeps.
Factored in feedback from JustinSB.
2018-10-04 14:41:20 -07:00
k8s-ci-robot ae2efc752a
Merge pull request #69391 from justinsb/fix_go111_printf
Storage: printf cleanups
2018-10-04 07:51:48 -07:00
k8s-ci-robot a25bc8df42
Merge pull request #68440 from humblec/log-level
Add `log-level` mount option support for glusterfs plugin
2018-10-04 06:21:49 -07:00
Masaki Kimura 4226ae7a61 Fix to reflect commnet
- Change not to skip error from GetLoopDevice other than DeviceNotFound
- Add comment for the reason for order of descriptor lock release and TearDownDevice
2018-10-03 22:31:51 +00:00
k8s-ci-robot 02df80d82b
Merge pull request #69211 from lichuqiang/mount_options
mountoptions support for local storage
2018-10-03 13:02:13 -07:00
k8s-ci-robot e03886c34a
Merge pull request #68297 from leakingtapan/golint-fix-gce-pd
fix golint for pkg/volume/gce_pd
2018-10-03 13:01:34 -07:00
Justin Santa Barbara 1a082a48e8 storage: printf cleanups
go test in 1.11 now performs some validation of format strings, so
this address the issues highlighted by go test, allowing go test to
pass with 1.11.

Fixes pertaining to storage.
2018-10-03 15:26:55 -04:00
Masaki Kimura 3d808540df Fix descriptor lock release logic for block volume unmapDevice
Fixes: #69114
2018-10-03 14:40:54 +00:00
k8s-ci-robot 984b7c89e8
Merge pull request #69140 from jsafrane/iscsi-panic
Fix iSCSI panic in DetachDisk
2018-10-03 01:16:30 -07:00
lichuqiang f733837392 support mount options in setup 2018-10-03 14:06:14 +08:00
lichuqiang 2f4be20f5d mountoptions support for local storage 2018-10-03 13:13:52 +08:00
Humble Chirammal fdcd58a794 Add `log-level` mount option support for glusterfs plugin
The glusterfs plugin/driver set log-level to ERROR by default while
mounting glusterfs shares. However at times, its required to supply other
log-level options like INFO, TRACE..etc. This patch enables the support
to provide other log-level values from storageclass.

Additional Ref#
    https://docs.gluster.org/en/v3/Administrator%20Guide/Setting%20Up%20Clients/

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2018-10-03 10:16:41 +05:30
k8s-ci-robot a4589f1cbe
Merge pull request #68813 from leakingtapan/golint-fix-volume-flex
fix golint issue for pkg/volume/flexvolume package
2018-10-02 18:15:31 -07:00
k8s-ci-robot 2d67d782de
Merge pull request #69225 from gnufied/volume-limit-tidy-up
Enable volume limit feature by default
2018-10-02 17:03:32 -07:00
Cheng Pan 7d68fd00e6 fix golint for pkg/volume/gce_pd 2018-10-01 18:58:30 +00:00
Hemant Kumar 575f79e03e Enable volume limit feature by default
Also add tests for it.
2018-10-01 14:37:45 -04:00
k8s-ci-robot ecfd1a3e56
Merge pull request #68945 from gnufied/fix-mount-options
Make sure we pass mount options while creating bind mounts
2018-10-01 09:27:54 -07:00
k8s-ci-robot 0815609e4a
Merge pull request #69116 from JHilker/patch-1
Random typo fix
2018-10-01 02:45:45 -07:00
k8s-ci-robot 9895e4e844
Merge pull request #69032 from mlmhl/azure_file_setup
return error if make dir failed when setting up azure file volume
2018-09-29 22:21:58 -07:00
k8s-ci-robot e019addcaa
Merge pull request #68931 from mlmhl/check_volume_attachment
extract volume attachment status checking operation as a common function when attaching a CSI volume
2018-09-29 19:45:06 -07:00
SandeepPissay 800ba767f8 Adding few VMware contributors as approvers for vsphere volume plugin 2018-09-28 15:29:25 -07:00
k8s-ci-robot 2e73529c9e
Merge pull request #58646 from adityadani/disable_selinux_for_portworx_volumes
Change the portworx volume attribute SupportsSELinux to false
2018-09-28 03:06:16 -07:00
k8s-ci-robot 52b7f6f0c3
Merge pull request #68979 from xing-yang/nodeinfo
Return error from NodeGetInfo
2018-09-27 04:48:29 -07:00
Jan Safranek e5fbb3538f Unmount iSCSI device only if it's mounted. 2018-09-27 10:24:59 +02:00
Jan Safranek ffaff4e976 Fixed panic in iSCSI.UnmountDevice
Fill iscsiDetacher.plugin so iscsiDetacher.plugin.targetLocks.LockKey(iqn) does not
panic.
2018-09-27 10:23:54 +02:00
Jacob Hilker 4eb6f16b54
Random typo fix 2018-09-26 16:18:04 -04:00
Hemant Kumar 6eda6d1a06 Make sure we pass mount options while creating bind mounts
This fixes an inconsitency that exists in mounter
2018-09-26 15:12:05 -04:00
k8s-ci-robot c8f0af2afc
Merge pull request #68680 from benoitf/fix-chown
Fix chown on distributed flex volumes (like gluster)
2018-09-25 19:23:58 -07:00
k8s-ci-robot 7db813178d
Merge pull request #68536 from sngchlko/affinity-for-cinder
Add VolumeScheduling support for Cinder
2018-09-25 12:16:02 -07:00
k8s-ci-robot 433d72da06
Merge pull request #68435 from humblec/log-file-nil
Glusterfs: Remove unwanted `log-file` mount argument.
2018-09-25 12:15:42 -07:00
Florent BENOIT 6584df5914 if driver disable support of FSGroup, mounter will not process the volume ownership 2018-09-25 16:12:11 +02:00
k8s-ci-robot c16691037d
Merge pull request #68255 from leakingtapan/golint-fix-ebs
Fix golint for pkg/volume/aws_ebs
2018-09-25 06:13:33 -07:00
mlmhl 867a717fb1 return error if make dir failed when setting up azure file volume 2018-09-25 20:16:08 +08:00
k8s-ci-robot b875ad8c08
Merge pull request #67508 from brahmaroutu/flex_metrics
Provide Flex volume metrics if the plugin supports.
2018-09-25 00:18:10 -07:00
k8s-ci-robot 9120dc01e1
Merge pull request #67939 from NickrenREN/rbd-ams
RBD AccessModes checking when attaching
2018-09-24 17:17:00 -07:00
Xing Yang 0a14086792 Return error from NodeGetInfo
This PR checks if NodeGetInfo returns error. If so, it returns
the error. Without this change, it always returns no error (nil)
regardless of whether NodeGetInfo returns error.
2018-09-22 12:00:15 -07:00
Cheng Pan 000e30086b fix golint for pkg/volume/aws_ebs 2018-09-22 05:56:05 +00:00
mlmhl 2ff6b7e0d8 extract volume attachment status checking operation as a common function when attaching a CSI volume 2018-09-21 19:49:31 +08:00
Cheng Pan aa297d1adf fix golint issue for pkg/volume/flexvolume package 2018-09-20 17:33:45 +00:00
houjun 76c0dd588c Remove unused function in downwardapi.go 2018-09-20 16:17:40 +08:00
k8s-ci-robot 9228bec334
Merge pull request #68579 from verult/adc-crd-access
Updating CSI e2e test to create CSI CRDs
2018-09-19 02:00:30 -07:00
Cheng Xing 4ff1e32974 Updating CSI e2e test to create CSI CRDs; storing CRD spec in a common location 2018-09-18 14:25:00 -07:00
David Zhu 9d207b3e3c GetMountRefs should not fail if the path supplied does not exist anymore. It has no mount references 2018-09-17 17:35:12 -07:00
k8s-ci-robot f193e4b107
Merge pull request #68691 from gnufied/fix-configmap-bug
verify invalid secret/configmap/projected volumes
2018-09-14 17:02:02 -07:00
Hemant Kumar 85e337153a verify invalid secret/configmap/projected volumes
And avoid calling Setup if they don't exist
2018-09-14 17:38:52 -04:00
Vladimir Vivien e3bc731143 CSI fix for proper fsgroup application to volume 2018-09-14 14:58:18 -04:00
Cheng Xing a8e282e905 Delaying kubeclient and csi client injection into CSI plugin 2018-09-13 14:10:49 -07:00
Humble Chirammal 38e8c00119 Glusterfs: Remove unwanted `log-file` mount argument.
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2018-09-12 22:41:25 +05:30
Seungcheol Ko 4b3e50b61c fix verify-bazel error 2018-09-12 07:27:33 +00:00