Commit Graph

502 Commits (74092228b22c5da5d592d5f2bafd972ea121640a)

Author SHA1 Message Date
Kubernetes Submit Queue 317853c90c
Merge pull request #59464 from dixudx/fix_all_typos
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

fix all the typos across the project

**What this PR does / why we need it**:
There are lots of typos across the project. We should avoid small PRs on fixing those annoying typos, which is time-consuming and low efficient.

This PR does fix all the typos across the project currently. And with #59463, typos could be avoided when a new PR gets merged.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #

**Special notes for your reviewer**:
/sig testing
/area test-infra
/sig release
/cc @ixdy 
/assign @fejta 

**Release note**:

```release-note
None
```
2018-02-10 22:12:45 -08:00
Di Xu 48388fec7e fix all the typos across the project 2018-02-11 11:04:14 +08:00
Kubernetes Submit Queue a35acccaf8
Merge pull request #59447 from verult/pd-alpha
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Fixes the regression of GCEPD not provisioning correctly on GKE alpha clusters.

Fixes the regression by better distinguishing between single-zone and multi-zone PDs.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #59047

**Special notes for your reviewer**: All PD and dynamic provisioning e2e tests pass, manually verified provision, delete, attach, and detach of both single-zone and multi-zone PDs. Will create e2e tests for multizone PDs in a separate PR.

**Release note**:


/sig storage
/assign @saad-ali
2018-02-09 11:55:10 -08:00
Kubernetes Submit Queue 0b6a0a6977
Merge pull request #59490 from agau4779/gce-unittest
Automatic merge from submit-queue (batch tested with PRs 58437, 59490, 55684). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

[GCE] Unit test ExternalLoadBalancer

**What this PR does / why we need it**:

- Unit tests for `pkg/cloudprovider/providers/gce/gce_loadbalancer_external.go`
- Tests creating, updating, and deleting an external LoadBalancer

**Future Improvements**
In order to further test `gce_loadbalancer_external.go`, we should add tests for the following cases:

- Network Tiers - when the current/desired network tier doesn't match, existing resources with the wrong tier should be torn down
- Expect an error when the TargetPool does not exist
- Expect an error when the LoadBalancer Firewall does not exist
- Case when TargetPool needs to be recreated 
- Case when IP needs to be released (calls gce.DeleteRegionAddress)
```release-note
NONE
```
2018-02-08 21:34:37 -08:00
Ashley Gau 5e38d785a2 make context the first arg in AddInstanceHook/RemoveInstanceHook 2018-02-08 11:04:39 -08:00
Ashley Gau 4b398a6d8d generate mocked methods with context as the first arg, because golint 2018-02-08 11:02:48 -08:00
Cheng Xing 02352460f6 Fixes the regression of GCEPD not provisioning correctly on alpha clusters. 2018-02-08 10:46:06 -08:00
Jesse Haka 3cf5b172fa add node shutdown taint
shutdowned -> stopped

use shutdown everywhere

use patch in taints api call

use notimplemented in clouds use AddOrUpdateTaintOnNode

correct log text

add fake cloud

try to fix bazel

add shutdown tests

add context
2018-02-08 12:56:06 +02:00
Ashley Gau b7fe9fe02f run update-bazel.sh, lint on mock.go 2018-02-07 15:27:35 -08:00
Ashley Gau 5c8e7e3707 remove newline before err checks. address pr comments 2018-02-07 14:38:31 -08:00
Ashley Gau 41070a2f58 use getInstanceByName to check for node presence, instead of DeleteInstance) 2018-02-07 14:36:08 -08:00
Ashley Gau 378b177f02 test updateExternalLoadBalancer removes nodes 2018-02-07 12:42:57 -08:00
Ashley Gau 60ed92b16d check firewall creation + deletion for healthcheck firewall 2018-02-07 11:38:24 -08:00
Ashley Gau 58f96f76e3 isolate node creation into separate function, address PR comments 2018-02-07 11:22:33 -08:00
Ashley Gau 23a6c5b3b7 cleanup 2018-02-07 09:43:46 -08:00
Kubernetes Submit Queue 891b3d10c4
Merge pull request #59423 from jingax10/upgrade_aliases_branch
Automatic merge from submit-queue (batch tested with PRs 59394, 58769, 59423, 59363, 59245). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Only populate alias range for nic0 when invoking instance.UpdateNetworkInterface.

**What this PR does / why we need it**:
Without the fix, GCP will emit errors, e.g., googleapi: Error 400: Invalid value for field 'resource.accessConfigs': ''. Updating this field is not supported., invalid

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #
N/A

**Special notes for your reviewer**:

**Release note**:

```release-note
"NONE"
```
2018-02-06 21:34:43 -08:00
Kubernetes Submit Queue e5b6026db6
Merge pull request #59287 from cheftako/cloud-context-level
Automatic merge from submit-queue (batch tested with PRs 59441, 58264, 59287, 59396, 59439). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Add context to all relevant cloud APIs

**What this PR does / why we need it**:

This adds context to all the relevant cloud provider interface signatures.
Callers of those APIs are currently satisfied using context.TODO().
There will be follow on PRs to push the context through the stack.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #815

**Special notes for your reviewer**:
For an idea of the full scope of this change please look at PR #58532.

**Release note**:
```release-note
Implementers of the cloud provider interface will note the addition of a context to this interface. Trivial code modification will be necessary for a cloud provider to continue to compile.
```
2018-02-06 20:27:39 -08:00
Ashley Gau 2ef71eb6e5 add AddInstanceHook mock method, test insertion of new instace 2018-02-06 17:41:06 -08:00
Ashley Gau ad98c4854f check presence of healthcheck 2018-02-06 17:41:06 -08:00
Ashley Gau 95bd67a18e test loadbalancer resources created & deleted 2018-02-06 17:41:05 -08:00
Ashley Gau aeba01a287 Move shared load balancer variables out of test.lb update/delete tests 2018-02-06 17:41:05 -08:00
Ashley Gau 6fedaa88ec Add TestEmsireExternalLoadBalancer test 2018-02-06 17:41:05 -08:00
Walter Fender e18e8ec3c0 Add context to all relevant cloud APIs
This adds context to all the relevant cloud provider interface signatures.
Callers of those APIs are currently satisfied using context.TODO().
There will be follow on PRs to push the context through the stack.
For an idea of the full scope of this change please look at PR #58532.
2018-02-06 12:49:17 -08:00
Ashley Gau 41318d7596 move makeHostUrl to gce_instances (only used there) 2018-02-06 10:49:08 -08:00
Ashley Gau 2d5d301669 use comparable host path instead of full url when creating a targetpool 2018-02-06 10:48:09 -08:00
Jing Ai 19b3bb1562 Only populate alias range for nic0 when invoking instance.UpdateNetworkInterface. 2018-02-06 07:57:26 -08:00
Jing Ai 4738e10b3e Add GCE instance UpdateNetworkInterface API to beta. 2018-02-05 11:39:54 -08:00
Jing Ai 627f4d3550 Use beta instead of alpha GCE Compute API to add an alias range to an instance. 2018-02-05 10:34:07 -08:00
Nick Sardo 5d6bb83501 Sort firewall params 2018-02-02 15:38:23 -08:00
Kubernetes Submit Queue 29ca36f077
Merge pull request #58775 from freehan/url-parse-fix
Automatic merge from submit-queue (batch tested with PRs 58777, 58978, 58977, 58775). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

fix url parsing for staging/dev endpoint

```release-note
NONE
```
2018-01-29 14:59:45 -08:00
Minhan Xia eeae81619b fix url parsing for staging/dev endpoint 2018-01-26 11:27:57 -08:00
Kubernetes Submit Queue 876292f9ee
Merge pull request #58368 from MrHohn/gce-externalLB-update-host
Automatic merge from submit-queue (batch tested with PRs 58661, 58764, 58368, 58739, 58773). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

[GCE cloud provider] Ensure hosts are updated in EnsureLoadBalancer()

**What this PR does / why we need it**:
From https://github.com/kubernetes/kubernetes/issues/56527, the `EnsureLoadBalancer()` implementation in GCE external LB doesn't always update the hosts (nodes). This PR makes it to do so.

Previously, the only situation where `ensureExternalLoadBalancer()` will not update hosts is when hosts are updated but there is no other changes that trigger target pool update (for which we delete&recreate target pool and hence updates the hosts). So the main change here is detecting that condition and call `updateTargetPool()`.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #56527

**Special notes for your reviewer**:
Turned out it could be a small change, so I gave it a try.
/assign @nicksardo @bowei 

**Release note**:

```release-note
NONE
```
2018-01-24 16:38:39 -08:00
Bowei Du 2514774707 Expose the generate stub for compute API
This allows clients such as Ingress to begin migration to the newly
generated stubs.
2018-01-23 00:21:42 -08:00
Kubernetes Submit Queue 8a05e2d7d4
Merge pull request #58490 from bowei/cp-neg
Automatic merge from submit-queue (batch tested with PRs 57867, 58490, 58502, 58134). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

GCE: neg to use generated code

GCE: neg to use generated code

```release-note
NONE
```
2018-01-23 00:06:28 -08:00
Bowei Du 02e52da702 Update Instances to use generated code
Update LoadBalancer to use generated code
2018-01-22 16:59:51 -08:00
Bowei Du 7ebc34fea9 Remove op field as it is no longer needed
Key is used instead
2018-01-20 09:44:52 -08:00
Bowei Du 76c796ffa4 GCE: invalid location was used in regional and zonal operations
Location was set to the full URL instead of the short name. Adds
logging to the operations to make future issues easier to debug.
2018-01-20 00:50:22 -08:00
Bowei Du 6cd1eda2d2 Update NEG to use generated code 2018-01-19 20:03:23 -08:00
Bowei Du 31be3a37f8 Fixes some typos/spaces in the GCE cloudprovider 2018-01-19 18:13:45 -08:00
Bowei Du f8776f8f0c Resulting generated code 2018-01-19 18:13:42 -08:00
Bowei Du 3ea2f3e9f2 Add logging in all generated GCE calls 2018-01-19 18:13:38 -08:00
Bowei Du aaa3dfd695 GCE: Check that the key is valid for each call 2018-01-19 12:03:43 -08:00
Bowei Du a2b222c94e GCE: Fix Valid() to check for proper region/zone names 2018-01-19 12:03:39 -08:00
Kubernetes Submit Queue 47b89aaf8f
Merge pull request #58493 from bowei/cp-firewall
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

GCE: firewall

GCE: firewalls to use generated code

```release-note
NONE
```
2018-01-19 10:35:20 -08:00
Kubernetes Submit Queue a8a418b0ae
Merge pull request #58504 from bowei/cp-targetpool
Automatic merge from submit-queue (batch tested with PRs 58053, 58504). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Update TargetPool to use generated code

```release-note
NONE
```
2018-01-19 05:11:27 -08:00
Kubernetes Submit Queue 49c729eef4
Merge pull request #58501 from bowei/cp-zones
Automatic merge from submit-queue (batch tested with PRs 56948, 58365, 58501). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Update Zones to use generated code

Update Zones to use generated code
```release-note
NONE
```
2018-01-19 01:12:33 -08:00
Kubernetes Submit Queue 6b57037432
Merge pull request #58489 from bowei/cp-routes
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

GCE: Change routes to use the generated code

GCE: Change routes to use the generated code

```release-note
NONE
```
2018-01-18 23:49:37 -08:00
Bowei Du 87355e4aed Update TargetPool to use generated code 2018-01-18 23:10:39 -08:00
Kubernetes Submit Queue e5216fe1ed
Merge pull request #58436 from bowei/cp-ingress
Automatic merge from submit-queue (batch tested with PRs 57908, 58436). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Updates UrlMap, BackendService, Healthcheck, Certs, InstanceGroup to use the generated code

Updates UrlMap, BackendService, Healthcheck, Certs, InstanceGroup to use the generated code

```release-note
NONE
```
2018-01-18 23:03:30 -08:00
Bowei Du 20bace876b Update Zones to use generated code 2018-01-18 22:15:58 -08:00
Bowei Du b239257a83 Update bazel 2018-01-18 22:06:34 -08:00
Kubernetes Submit Queue e056dde7ea
Merge pull request #58491 from bowei/cp-forwarding
Automatic merge from submit-queue (batch tested with PRs 58104, 58492, 58491). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

GCE: forwarding rules to use generated code

GCE: forwarding rules to use generated code

```release-note
NONE
```
2018-01-18 21:57:34 -08:00
Bowei Du f249968df6 Update Routes to use generated code 2018-01-18 21:39:33 -08:00
Bowei Du 8de8a6d8f2 Remove ignoring of object not found on deletion
This is all handled properly at the caller sites
2018-01-18 17:48:01 -08:00
Bowei Du 9710da8be5 Fix reference to Items in internal load balancer 2018-01-18 17:44:30 -08:00
Bowei Du 0fbfc23b26 Update bazel 2018-01-18 17:34:21 -08:00
Bowei Du 81725cab34 Update Forwarding rules to use generated code 2018-01-18 17:34:15 -08:00
Bowei Du c9cfea68ad Update bazel 2018-01-18 17:32:25 -08:00
Bowei Du e4e7c0a215 Update Firewall to use generated code 2018-01-18 17:31:42 -08:00
Bowei Du 5ac26ac46f Update bazel builds 2018-01-18 17:25:14 -08:00
Zihong Zheng 687e593601 [GCE cloud provider] external lb - move target pool operation into
its own function
2018-01-18 17:24:18 -08:00
Zihong Zheng 1c7d9e152f [GCE cloud provider] Update hosts in EnsureLoadBalancer() 2018-01-18 17:24:18 -08:00
Bowei Du 67c34edbb3 Update TargetProxy to use generated code 2018-01-18 17:22:34 -08:00
Bowei Du 2556e01142 Update InstanceGroup to use generated code 2018-01-18 17:21:55 -08:00
Bowei Du 271935d7d9 Update Certs to use generated code 2018-01-18 17:21:55 -08:00
Bowei Du f83c5379dc Update Healthcheck to use generated code 2018-01-18 17:21:55 -08:00
Bowei Du 48ad2eed8e Update BackendService to use generated code 2018-01-18 17:21:55 -08:00
Bowei Du fa3e0af5ac Update UrlMap to use generated code 2018-01-18 17:21:55 -08:00
Bowei Du 93bb60e07f Update Addresses to use generated code 2018-01-18 17:20:54 -08:00
Kubernetes Submit Queue fa094e6672
Merge pull request #58435 from bowei/cp-gen-method-pages
Automatic merge from submit-queue (batch tested with PRs 58422, 58229, 58421, 58435, 58475). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Add handling for method that use Pages() to retrieve results

- Add handling for method that use Pages() to retrieve results
- Make functions take in *Key rather than value type.

```release-note
NONE
```
2018-01-18 16:36:41 -08:00
Bowei Du d3a1b4b255 Update code for GCE cloud provider 2018-01-18 13:33:34 -08:00
Bowei Du 447823b4a1 Add handling for method that use Pages() to retrieve results
Make functions take in *Key rather than value type.
2018-01-18 13:33:34 -08:00
Zihong Zheng 5b97e1b375 Update gce call to use wrapper in gce_loadbalancer_external 2018-01-17 18:22:09 -08:00
Kubernetes Submit Queue 75e50a3779
Merge pull request #58113 from bowei/cloud
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Add `cloud` for the generated GCE interfaces, support structs

Note: this does not wire the generated code.

```release-note
NONE
```
2018-01-12 19:03:00 -08:00
Bowei Du ac48b1b075 Add `cloud` for the generated GCE interfaces, support structs
Note: this does not wire the generated code.
2018-01-10 15:10:21 -08:00
Kubernetes Submit Queue 8c22277f4c
Merge pull request #57861 from nicksardo/existing-sub
Automatic merge from submit-queue (batch tested with PRs 54230, 58100, 57861, 54752). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

GCE: Use existing subnetwork of ILB forwarding rule

Fixes #57860

**Test Cases**:
Clusters using auto network with existence of a manual subnet in same region.
- [x] Upgrade 1.7 cluster with existing ILBs to latest. Confirm existing ILBs still are synced.
  Version 1.7 does not attempt to fill in the subnetwork, so the forwarding rule was created with the correct subnetwork. 
- [x] Upgrade 1.8 cluster with existing ILBs to latest. Confirm existing ILBs (using wrong subnet) still are synced. 
- [x]  Latest version creates ILBs using the correct subnet.


Clusters with manual subnets have always and will continue to use the subnet specified in gce.conf.
- [x] Upgrade 1.8 cluster with existing ILBs to latest. Confirm existing ILBs (using manual subnet) still are synced. 


Clusters with legacy networks have always and will continue to use an empty subnet. 
- [x] Upgrade 1.8 cluster with existing ILBs to latest. Confirm existing ILBs (using legacy network) still are synced. 


**Release note**:
```release-note
GCE: Allows existing internal load balancers to continue using an outdated subnetwork 
```
2018-01-10 13:29:36 -08:00
Bowei Du 3cde2613ff Fix lint and bazel 2018-01-09 23:09:08 -08:00
Bowei Du 8cdfe36267 Update generated code to stable order 2018-01-09 17:10:05 -08:00
Bowei Du 5abf80718e Remove glog dependency in the generator 2018-01-09 16:57:15 -08:00
Bowei Du c3e23b1b14 Fix gofmt 2018-01-09 16:40:15 -08:00
Bowei Du 2aaf8b47b2 Clean up documentation. 2018-01-09 16:40:15 -08:00
Bowei Du 9a70885559 BUILD 2018-01-09 16:40:15 -08:00
Bowei Du f076f4fa0b Hand written unit test for exercising the mock 2018-01-09 16:40:15 -08:00
Bowei Du a0adc1bb19 Special custom code for handling the Projects resource 2018-01-09 16:40:15 -08:00
Bowei Du e230bd967b Generated code (see gen/main.go for the source) 2018-01-09 16:40:14 -08:00
Bowei Du 329e0b1cb5 support interfaces for the generated code 2018-01-09 16:40:14 -08:00
Bowei Du 968cce929c code generation 2018-01-09 16:40:14 -08:00
Bowei Du 75bff35884 long running operation support 2018-01-09 16:40:14 -08:00
Bowei Du 8250950d15 documentation 2018-01-09 16:40:14 -08:00
Bowei Du 94ddfd17e7 Implementation of the compute "filter" handling for List() 2018-01-09 16:40:14 -08:00
Bowei Du b19149406e "meta" type descriptions used for code generation 2018-01-09 16:40:14 -08:00
Bowei Du 6894e3d32b Support utilities 2018-01-09 16:40:14 -08:00
Nick Sardo 64c20676ac Use existing subnetwork of forwarding rule 2018-01-05 10:15:33 -08:00
Nick Sardo d6ed5d3107 Use GA API for managing addresses 2017-12-27 11:27:43 -08:00
Jeff Grafton efee0704c6 Autogenerate BUILD files 2017-12-23 13:12:11 -08:00
Kubernetes Submit Queue 6937763331
Merge pull request #57351 from nicksardo/auto-sub
Automatic merge from submit-queue (batch tested with PRs 57351, 55654). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

GCE: Get automatically created subnetwork if none is specified for auto network

Fixes #57350 

**Release note**:
```release-note
GCE: Fixes ILB creation on automatic networks with manually created subnetworks.
```
2017-12-22 23:11:36 -08:00
Bowei Du 301488b235 Expose all GCE cloud proivder services versions, not just the GA API 2017-12-22 11:24:10 -08:00
Nick Sardo c893ce8c95 Get automatically created subnetwork if none is specified 2017-12-20 17:48:32 -08:00
stewart-yu 2ab0e3217e remove unuse code in cloudprovider 2017-12-17 17:21:14 +08:00
Kubernetes Submit Queue 2ae99cf146
Merge pull request #56955 from feiskyer/scrub-dns
Automatic merge from submit-queue (batch tested with PRs 56997, 57008, 56984, 56975, 56955). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Remove unused ScrubDNS interface from cloudprovider

**What this PR does / why we need it**:

DNS scrubber from kubelet has been removed in #36785 and cloudprovider's `ScrubDNS()` interface is not used anywhere.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #56953.

**Special notes for your reviewer**:

**Release note**:

```release-note
Remove ScrubDNS interface from cloudprovider.
```
2017-12-16 15:23:54 -08:00