Commit Graph

19 Commits (64f56764d5ba7d06cf60e2e5013dcf5e9a453a3c)

Author SHA1 Message Date
David Ashpole e5a6a79fd7 update cadvisor, docker, and runc godeps 2017-09-05 12:38:57 -07:00
deads2k 633e9d98fc use apimachinery packages instead of client-go packages 2017-01-13 14:04:54 -05:00
deads2k 1ebe759743 selectively move to client-go packages 2017-01-04 17:49:24 -05:00
Michael Fraenkel e31dda98c1 Use the builtin timeout provided by SSH 2016-12-29 18:49:24 -05:00
Kubernetes Submit Queue 98c68947ee Merge pull request #36549 from cjcullen/closetunnel
Automatic merge from submit-queue

Close tunnels after failed healthchecks.

When we fail an ssh-tunnel healthcheck, we currently leak a file descriptor keeping the SSH connection open.

This closes the underlying tunnel before removing our pointer to it. It is possible that the tunnel was functional, but the healthcheck failed for some other reason (e.g. kubelet healthz down), which could close an in-use tunnel, but I think that is acceptable.
2016-11-15 10:42:53 -08:00
CJ Cullen 1fdb3ee902 Close tunnels after failed healthchecks. 2016-11-11 09:51:51 -08:00
Yu-Ju Hong e105eec9c9 Disable keep-alive for SSH tunnel health checks
We don't reuse the http client. Disabling the keep-alive to properly close the
connections.
2016-11-08 10:03:43 -08:00
Mikkel Oscar Lyderik 1b5aa2c09c ssh pubkey parsing: prevent segfault
Fixes an issue where the apiserver would segfault when parsing an ssh
public key that isn't PEM encoded.
2016-10-21 22:00:19 +02:00
Phu Kieu 6f9fd4431a Use same SSH tunnel as kubelet 2016-10-12 11:54:47 -07:00
lojies 0d675fff04 add err to return 2016-09-20 14:47:31 +08:00
Wojciech Tyczynski 4b9b1afe76 Revert "Add a customized ssh dialer that will timeout" 2016-07-14 08:48:24 +02:00
Chao Xu d29b880efe add a customized ssh dialer that will timeout 2016-07-13 10:46:57 -07:00
David McMahon ef0c9f0c5b Remove "All rights reserved" from all the headers. 2016-06-29 17:47:36 -07:00
k8s-merge-robot 4c9bbea0cf Merge pull request #24506 from timstclair/ssh
Automatic merge from submit-queue

Don't log private SSH key

Log files may have more inclusive permissions than private SSH keys, and as such we should not log the key, even if it looks invalid. I accidentally leaked my key this way when posting e2e test logs.
2016-04-19 22:36:44 -07:00
Tim St. Clair df42b984d4 Don't log private SSH key
Log files may have more inclusive permissions than private SSH keys, and
as such we should not log the key, even if it looks invalid.
2016-04-19 16:34:37 -07:00
CJ Cullen cba5e84fd1 Fix goroutine leak in ssh-tunnel healthcheck. 2016-04-19 11:23:27 -07:00
CJ Cullen cde4f6d613 Add a timeout to the sshDialer to prevent indefinite hangs. 2016-04-04 16:35:20 -07:00
Jan Chaloupka 4389b3f0d6 Rewritte util.* -> wait.* wherever reasonable 2016-02-07 12:02:20 +01:00
Joe Finney 7a59683e41 Retry SSH connection for E2E log gathering. 2016-02-03 16:06:02 -08:00