ffb2b62726
Merge pull request #3725 from dchen1107/cleanup
...
Generate pod.Name when pod.Name == "" for both HTTP and file sources.
2015-01-22 13:10:27 -08:00
ec77507915
Generate pod.Name when pod.Name == "" for both HTTP and file sources.
...
Fix #3584
2015-01-22 12:53:30 -08:00
30219f8dfa
Merge pull request #3664 from thockin/pull-if
...
Pull if
2015-01-21 13:05:28 -08:00
81343aac63
Change PullPolicy constants to match
2015-01-21 12:48:56 -08:00
819803b79f
Make VolumeSource not be a pointer
...
There's no reason for it to be a pointer.
2015-01-20 17:54:04 -08:00
dd45246150
Merge pull request #3587 from dchen1107/image
...
Clean up Kubernetes PullPolicy
2015-01-20 17:18:26 -08:00
60ec08db93
Rename HostDir to HostPath in v1beta3
2015-01-20 15:56:44 -08:00
9192a4ce22
Merge pull request #3642 from dchen1107/clean
...
Remove image GC.
2015-01-20 14:07:00 -08:00
d1af520bd0
Merge pull request #3589 from filbranden/fix_nil_interface_pointer_without_reflect1
...
Fix comparison of EtcdClient to nil so that it does not run into the pointer vs. interface issue
2015-01-20 13:55:25 -08:00
2299c04cea
Remove image GC.
...
Fix #3617,#3611, and #3393 .
2015-01-20 13:43:08 -08:00
3101a33d32
Kubelet stop using api/helper.go for PullPolicy
2015-01-20 11:54:22 -08:00
aec4594a8d
Introduce validatePullPolicyWithDefault to validation.
2015-01-20 11:54:22 -08:00
6cb275829f
Implement volumes as plugins.
...
Break up the monolithic volumes code in kubelet into very small individual
modules with a well-defined interface. Move them all into their own packages
and beef up testing along the way.
2015-01-20 11:45:45 -08:00
6dee1d7fa4
Fix typos in user-facing strings
2015-01-18 01:32:34 -06:00
79ff06ffa1
Fix comparison of EtcdClient to nil so that it does not run into the pointer vs. interface issue
...
This is a partial rollback of commit 6e6f465a36http://golang.org/doc/faq#nil_error and the
discussion in PR #3356 .
Tested by installing a kubelet built from head with this patch into a
containervm instance and confirming it did not crash on standalone.go.
Confirmed that by only removing the `reflect.IsNil()` comparison but not
changing the return type of `EtcdClientOrDie()` did indeed cause that
same crash, so changing the return type does indeed fix the issue.
Signed-off-by: Filipe Brandenburger <filbranden@google.com>
2015-01-16 16:43:05 -08:00
d54242a649
Merge pull request #3552 from commonlisp/master
...
Replace kubelet logging %s--%s--%s with dockertools.BuildDockerName()
2015-01-16 14:31:43 -08:00
98bdd3f7c4
Test for and fix crash with nil client in kubelet.
...
Added test that fails before fix.
Fixed use of nil pointer.
2015-01-16 13:39:31 -08:00
e86c8f9e53
Merge pull request #3565 from dchen1107/podstatus
...
Introduce PodStatusResult, and deprecate PodContainerInfo.
2015-01-16 12:05:07 -08:00
15e9fa8a9d
Introduce PodStatusResult, and deprecate PodContainerInfo.
2015-01-16 09:10:40 -08:00
af4bbd1a1b
Replace kubelet logging %s--%s--%s with dockertools.BuildDockerName()
...
Fixes issue #3454
2015-01-15 19:47:54 -08:00
5aeda8a5bb
Remove dead code in test.
2015-01-15 14:49:08 -08:00
46f8a56dba
Merge pull request #3376 from erictune/channel_api
...
Kublet watches Pods.
2015-01-15 14:48:12 -08:00
2e002b1095
Add second pod to test.
2015-01-15 13:36:49 -08:00
b57cc6a11c
Increase timeout for TestEtcdSourceExistingBoundPods test
2015-01-14 17:06:04 -08:00
46827720b3
Merge pull request #3493 from saad-ali/testFor3467
...
Add test case for EtcdSource ExistingBoundPods
2015-01-14 16:35:26 -08:00
a1c287ede9
Add test case for EtcdSource ExistingBoundPods
2015-01-14 16:15:08 -08:00
b759f67ee3
Kublet watches Pods.
...
Added a kubelet config source for watching pods on apiserver.
The pods are converted to boundpods for merging with other
config sources.
The preferred way to create a kubelet is now to pass an apiserver
client but not an etcd client. Changed cmd/integration to use
apiserver to talk to kubelets. And cmd/kubernetes.
Unit, integration, and e2e tests pass, except for a failure of the pd
e2e test which was unrelated.
2015-01-14 15:31:26 -08:00
1be3de895c
Move util.UID to pkg/types
2015-01-14 15:22:21 -08:00
c13ae34b02
Merge pull request #3445 from saad-ali/fix3172
...
Remove CONDITION from event object completely
2015-01-14 15:03:06 -08:00
88c68e0349
Merge pull request #3331 from pmorie/services
...
Service visibility w/in namespaces, master services, set env vars in kubelet
2015-01-14 15:01:05 -08:00
8a764c02d5
Merge pull request #3478 from thockin/uid_type
...
Use a strong type for UID fields
2015-01-14 14:20:22 -08:00
90dfdcecd5
Remove CONDITION from event object completely
...
# *** ERROR: *** Some files have not been gofmt'd. To fix these
# errors, run gofmt -s -w <file>, or cut and paste the following:
# gofmt -s -w pkg/kubecfg/resource_printer.go pkg/proxy/config/config.go pkg/runtime/types.go
#
# Your commit will be aborted unless you override this warning. To
# commit in spite of these format errors, delete the following line:
# COMMIT_BLOCKED_ON_GOFMT
2015-01-14 14:17:16 -08:00
fd834ae84d
Pods should see services only from their own ns
2015-01-14 17:06:36 -05:00
009c5e1129
Using ExtractObj instead of ExtractToList since BoundPods is not a List type
2015-01-14 14:05:47 -08:00
e86d4cd3c6
Use a strong type for UID fields
2015-01-14 13:53:43 -08:00
0716df8f2b
Fix Event.Source for hostname_override case.
2015-01-14 09:43:13 -08:00
826b61c76d
Address nits from PR #3423
2015-01-13 23:34:37 -08:00
ca89aa6528
Make data dirs for all pods when syncing
2015-01-13 17:18:21 -08:00
110ab6f1bd
Split up kubelet "source seen" logic
2015-01-12 21:48:55 -08:00
55653568ae
Merge pull request #3385 from erictune/source_api
...
Added kubelet config source from apiserver.
2015-01-12 15:47:15 -08:00
18bcef5235
Added kubelet config source from apiserver.
2015-01-12 15:29:16 -08:00
0d92da6b15
Remove logic to handle if UID is blank
...
This should only have been triggered by tests, and those should now be fixed.
I tested by calling panic() if UID was blank in BuildDockerName() or if number
of fields was < 5 in ParseDockerName(). All errors were fixed.
2015-01-12 14:27:34 -08:00
905514a12b
Ensure Namespace and UID are set in kubelet
...
Make all kubelet config sources ensure that UID and Namespace are defaulted, if
need be.
We can *almost* disable the "if blank" logic for UID, except for tests that
call APIs that do not run through SyncPods. We really ought to be enforcing
invariants better.
2015-01-12 14:27:34 -08:00
af0e2fd551
Merge pull request #3403 from thockin/klet-dirs-structure
...
Apply more structure to pod data dirs
2015-01-12 14:19:22 -08:00
e1917cf900
Fix "Kubelet doesn't kill old pods when BoundPods is empty" issue
2015-01-12 12:39:47 -08:00
523a80bec7
Apply more structure to pod data dirs
...
This is makes it possible to read back "known" pods from disk without
getting other (non-pod) kubelet dirs in the mix. Ditto for containers
within a pod. This is just saner overall. Pods now nest in a pods/
dir. Likewise containers.
2015-01-12 06:16:32 -08:00
29d084c4d3
Pass client into Kubelet.
...
Subsequent PR will make use of it.
2015-01-08 15:35:17 -08:00
eac982137f
Merge pull request #3260 from commonlisp/master
...
NewMainKubelet validates SyncFrequency, minimum GC age, etc.
2015-01-08 08:20:55 -08:00
06475fc4b4
NewMainKubelet validates Kubelet config parameters
...
Fixes issue #3202 .
* Validates SyncFrequency and minimum GC age and propagates error to RunKubelet
* Defaults for Kubelet config and minor cleanup
* cmd Kubelet MinimumGCAge to 1m instead of 0
2015-01-07 18:50:53 -08:00
95dd2d7ca6
reuse function; never ever unlock without defer
2015-01-07 17:07:12 -08:00
5f2dae4dd8
Merge pull request #3195 from lavalamp/numericWire
...
Add numeric type into api
2015-01-07 16:15:52 -08:00
35f54addca
Update more packages, tests, binaries for quantity
...
make etcd registry pass test
fix kubelet config for quantity
fix openstack for quantity
fix controller for quantity
fix last tests for quantity
wire into binaries
fix controller manager
fix build for 32 bit systems
2015-01-07 15:21:35 -08:00
7f49ba0dcf
Put quantity into packages
...
kubelet, GCE, validation, client
2015-01-07 15:21:34 -08:00
ba53d723d3
Clean up how client is passed to Kubelet in preparation for reading pods
...
Also fixes how Kubelet server looks up pods by name when there are multiple
sources.
2015-01-07 14:40:37 -05:00
7c69570663
Add a lock around the other docker pull.
...
Fixes e2e (I hope), certainly passes e2e in my client.
2015-01-07 00:17:57 -08:00
733e12e19b
Revert "Avoid race between image pull and garbage collect"
...
This reverts commit 6f14e2e210
2015-01-06 23:23:23 -08:00
e84b4d03a4
Merge pull request #3183 from anguslees/pull-lock
...
Avoid race between image pull and garbage collect
2015-01-06 21:23:29 -08:00
e3c019128e
Add EventSource to api to have both Component and Host information.
2015-01-06 16:08:20 -08:00
2b91c1417c
Create selfLink for pods from config files and indicate hostname as part of event source.
2015-01-06 16:08:20 -08:00
8b42534f77
Fix kubelet config tests
2015-01-06 13:02:41 -08:00
88fe5c6f46
Never set pod.Name in kubelet config code
...
I think it is time to tighten up input requirements. The validation code will
reject a pod that has an empty name field.
2015-01-06 11:14:19 -08:00
cae572290b
Merge pull request #3230 from saad-ali/hashingLogging
...
Improve kubelet logging around container being killed due to hash change
2015-01-05 16:48:29 -08:00
d6d18a32e7
Replace %s with %q to make empty strings more obvious
2015-01-05 16:38:47 -08:00
03baa7234a
Merge pull request #3225 from dchen1107/clean
...
Move GetHostName and GetDockerEndpoint methods to pkg/util
2015-01-05 16:21:51 -08:00
eb831919d9
Improve kubelet logging around container being killed due to hash change
2015-01-05 16:20:40 -08:00
f92f830e1f
Modify hash to be computed using spew library so that nested object values are used instead of pointer
2015-01-05 15:48:06 -08:00
f718957a79
Move GetHostName and GetDockerEndpoint methods to pkg/util
2015-01-05 11:44:21 -08:00
78547d9a87
Merge pull request #3194 from vishh/stats
...
Update "/stats" endpoint on kubelet.
2015-01-05 11:23:00 -08:00
3ef9e404c1
Update "/stats" endpoint on kubelet to take namespace as an argument as part of the API.
2015-01-03 02:17:25 +00:00
6f14e2e210
Avoid race between image pull and garbage collect
...
Hold the pullLock while pulling regular container images, not just the
network container.
Also: previously, the locks were grabbed at too-low a layer in the
callstack, leaving a (narrow) window where images could be pulled and
then garbage collected before being used.
This change takes the existing pullLock a layer higher in the call stack
so the critical regions encompass the entire find+delete and pull+use
operation in both cases.
2014-12-31 11:50:40 +11:00
e8d30f019d
Modify "kubectl get events" to print FieldPath so BoundPod events for the same Pod but different containers can be differentiated
2014-12-29 21:32:49 -08:00
d38613777b
Propagate syncPod error as event to upper layer.
2014-12-29 15:42:47 -08:00
652479a3b1
Add kubelet DNS flags & api disable for DNS
...
This adds --cluster_dns and --cluster_domain flags to kubelet. If
non-empty, kubelet will set docker --dns and --dns-search flags based on
these. It uses the cluster DNS and appends the hosts's DNS servers.
Likewise for DNS search domains.
This also adds API support to bypass cluster DNS entirely, needed to
bootstrap DNS.
2014-12-29 09:18:12 -08:00
b8781c04bb
Add support for garbage collecting images.
2014-12-22 16:56:58 -08:00
f073ecf4cc
Understand OOMKilled reason
2014-12-18 15:59:44 -08:00
c34f2d354c
Merge pull request #3035 from dchen1107/master
...
Update fsouza/go-dockerclient pkg to latest revision and fix some compiling issues.
2014-12-18 14:07:40 -08:00
608c3d5046
Update kubelet package on latest go-dockerclient package.
2014-12-18 13:49:13 -08:00
845fb5013d
Remove some dead code.
2014-12-18 13:32:20 -08:00
71fc5940f1
suppress unnecessary stacktrace when http status code is redirect related.
2014-12-17 18:42:11 -08:00
928f52056e
Remove HTTP Server support for pushing pods onto the kubelet.
2014-12-17 17:15:36 -08:00
7da0378f3c
Track the sources that the kubelet has seen, and only delete pods
...
when every source has been seen at least once.
2014-12-17 13:08:43 -08:00
bb28949291
Merge pull request #2831 from jdef/unit_test_for_2815
...
unit test for #2815 , as requested by @brendandburns
2014-12-16 15:08:41 -08:00
3a0d16ff35
Add an e2e test for exec liveness probes. Fix the docker exec integration.
2014-12-16 13:53:32 -08:00
6902f6ab21
Merge pull request #2844 from brendandburns/fix
...
Handle a missing apiserver flag better.
2014-12-15 17:25:09 -08:00
9bc8915eeb
Merge pull request #2912 from smarterclayton/small_v1beta3_refactors_2
...
More small refactors for v1beta3 -> internal
2014-12-15 15:16:36 -08:00
1a5a7ebd69
Handle a missing apiserver flag better.
2014-12-15 15:14:41 -08:00
2c64db5943
Merge pull request #2938 from vishh/exec
...
Updated docker version that supports exec to '1.3.0'.
2014-12-15 14:49:12 -08:00
dadb8431c4
Remove internal PodState in favor of internal PodStatus object
2014-12-15 16:50:05 -05:00
f4ef05bc20
Updated docker version that supports exec to '1.3.0'.
2014-12-15 20:44:58 +00:00
a6f967b6e7
Revert "Revert "Add an api object for the kubelet, and a versioned endpoint.""
...
This reverts commit dcfcf315e5
2014-12-15 09:29:04 -08:00
dcfcf315e5
Revert "Add an api object for the kubelet, and a versioned endpoint."
...
This reverts commit d4b9979382
2014-12-12 21:13:44 -08:00
3afc9fffba
fixed minor formatting
2014-12-12 20:43:07 -05:00
d4b9979382
Add an api object for the kubelet, and a versioned endpoint.
2014-12-12 15:26:28 -08:00
51bfb50698
Use util.Time consistently in types.go
2014-12-11 11:14:25 -05:00
4af64b8911
api: add container's id to ContainerStatus
...
Sometimes for external applications it is useful to correlate the pod
containers to the real docker instances.
This patch adds a new entry in the container status (containerID) which
is used to identify the instance.
Signed-off-by: Federico Simoncelli <fsimonce@redhat.com>
2014-12-10 20:38:41 +00:00
85b4b4677e
unit test for #2815 , as requested by @brendandburns
2014-12-10 15:33:38 -05:00
17475cdbe7
Merge pull request #2821 from lavalamp/fix
...
Allow, when testing, SelfLinks to be unset.
2014-12-10 12:10:51 -08:00
5c79668854
Merge pull request #2815 from jdef/inspect_tagged_image
...
inspect the full repo/image:tag name
2014-12-10 11:53:14 -08:00
e46bfcf699
Allow, when testing, SelfLinks to be unset. Kubelet now makes events in tests.
2014-12-09 17:53:42 -08:00
9a1fea6927
Merge pull request #2817 from lavalamp/fix
...
Compare containers by name, not by pointer equality.
2014-12-09 17:33:56 -08:00
ba62943b8e
Compare containers by name, not by pointer equality.
2014-12-09 17:06:39 -08:00
4985f58eb5
Merge pull request #2759 from mikedanese/configure-cadvisor-port
...
make cadvisor port configurable on the kubelet
2014-12-09 15:21:35 -08:00
ca2840a8e8
inspect the full repo/image:tag name
2014-12-09 15:41:08 -05:00
acc6b95c21
Add functions to get kubelet directories.
...
Gets rid of some magic constants and makes volume plugins (coming later)
cleaner.
2014-12-06 11:00:19 -08:00
722abf1a95
- make cadvisor port configurable on the kubelet.
...
- added cadvisor port documentation.
2014-12-06 09:48:08 -08:00
76ef747927
avoid panics when docker CT has no name
2014-12-05 15:48:25 -05:00
b1c7893916
Merge pull request #2683 from jimmidyson/cadvisor-0.6.2
...
Fixes #2681 : update to cadvisor 0.6.2
2014-12-04 03:48:40 +08:00
9a9a1e0939
Move from go-yaml/yaml to ghodss/yaml
2014-12-02 16:24:05 -08:00
f4b031d025
Merge pull request #2514 from thockin/label-ns
...
Add label key namespacing
2014-12-02 13:38:46 -08:00
993ef88eec
Merge pull request #2689 from brendandburns/standalone
...
Refactor kubelet, standalone k8s and integration test to all use the same code.
2014-12-01 21:53:41 -08:00
d47b510104
Refactor kubelet, standalone k8s and integration test to all use the same code.
2014-12-01 15:37:21 -08:00
89875ef09d
Loosen DNS 952 for labels
2014-12-01 12:30:43 -08:00
5109ce3356
Fixes #2681 : update to cadvisor 0.6.2
2014-12-01 11:38:03 +00:00
54859cf1ea
Remove format specifiers with no options.
2014-11-26 12:05:00 -08:00
a5bc6301a4
Revert "Using util.Time for ContainerStatus"
2014-11-24 21:32:31 -08:00
610ab9a0db
Merge pull request #2586 from dchen1107/cleanup
...
Using util.Time for ContainerStatus
2014-11-24 15:35:07 -08:00
acb0f1198b
Using util.Time for ContainerStatus
2014-11-24 15:15:33 -08:00
f122fc94bf
Move service enviroment vars code.
...
GetServiceEnvironmentVariables (originally in pkg/registry/service/rest.go)
is split into two parts: one that lists services, and one that turns
a ServiceList into environment vars. This will allow a subsequent PR
to add a call to the latter function with an existing ServiceList.
The former part is moved into pkg/registry/pod/bound_pod_factory.go.
The latter part is put in a new package, pkg/kubelet/envvars/envvars.go.
The new package is under kubelet because the container enviroment is more
associated with kubelet than with registry.
Test code moved too.
2014-11-23 05:50:34 -08:00
7d3e00c679
Remove never-needed return value.
...
Make some types private.
2014-11-21 15:11:45 -08:00
9f5ebef3d8
Merge pull request #2513 from lavalamp/verifyNetwork
...
Fix crash (loop?) in kubelet
2014-11-21 10:10:32 -08:00
9116c27040
Fix crash (loop?) in kubelet
2014-11-20 18:28:23 -08:00
95a9098311
fix 'go vet' warnings
2014-11-21 09:45:28 +08:00
ea960711ff
Clean up error logs.
...
Use %v for errors, tidy some messages, make error messages start lowe-case
(as per go guidelines). Just accumulated nits.
2014-11-21 09:45:26 +08:00
6d3324c3fd
Add image related events to kubelet.
2014-11-19 15:16:14 -08:00
cea52d7e4f
Merge pull request #2409 from mattmoor/master
...
Implements a credentialprovider library for use by DockerPuller.
2014-11-17 21:53:25 -08:00
0c5d9ed0d2
Implements a credentialprovider library for use by DockerPuller.
...
This change refactors the way Kubelet's DockerPuller handles the docker config credentials to utilize a new credentialprovider library.
The credentialprovider library is based on several of the files from the Kubelet's dockertools directory, but supports a new pluggable model for retrieving a .dockercfg-compatible JSON blob with credentials.
With this change, the Kubelet will lazily ask for the docker config from a set of DockerConfigProvider extensions each time it needs a credential.
This change provides common implementations of DockerConfigProvider for:
- "Default": load .dockercfg from disk
- "Caching": wraps another provider in a cache that expires after a pre-specified lifetime.
GCP-only:
- "google-dockercfg": reads a .dockercfg from a GCE instance's metadata
- "google-dockercfg-url": reads a .dockercfg from a URL specified in a GCE instance's metadata.
- "google-container-registry": reads an access token from GCE metadata into a password field.
2014-11-17 21:46:54 -08:00
0ca192889f
Fix namespace of minion birthcry event.
2014-11-17 15:34:07 -08:00
eeb4547bec
Merge pull request #2392 from dchen1107/upstream1
...
Generate container related events from kublet
2014-11-17 11:28:52 -08:00
736c4ffb0b
more events from kublet
2014-11-17 11:00:46 -08:00
8a508bcce3
Merge pull request #2391 from lavalamp/fix3
...
Remove confusing function; add TODO and explanation for (nonfatal) error...
2014-11-14 17:24:18 -08:00
c412540cf2
Remove confusing function; add TODO and explanation for (nonfatal) error message in integration test.
2014-11-14 17:16:05 -08:00
ce145545b9
Add unittests to test PullPolicy.
2014-11-14 16:09:53 -08:00
f729d748ac
If the image with :latest tag specified in Spec, kubelet should try
...
to pull the latest one even the policy is PullIfNotPresent.
2014-11-14 16:09:53 -08:00
6d31c2bf8a
util.EncodeJSON proven harmful, remove it everywhere
...
People were misusing EncodeJSON in tests when they should be using
runtime.EncodeOrDie(testapi.Codec(), obj). Removing the potential
for cutting self on sharp objects.
2014-11-13 10:38:13 -05:00
f2f1708687
Setting RawTerminal attribute in LogOptions to false
2014-11-12 17:47:52 +01:00
b5a88a4662
Merge pull request #2283 from dchen1107/deathrattle
...
Fixed Eventf with wrong arguments.
2014-11-11 10:41:51 -05:00
ada43ae233
Fixed Eventf with wrong arguments.
2014-11-10 23:53:48 -08:00
db0d98daa2
Merge pull request #2257 from jhadvig/kubelet_timeout
...
Bumping kubelet write/read timeout
2014-11-10 21:18:25 -08:00
08c8f2cde1
Record event of kubelet restart re: minion obj.
2014-11-10 13:46:48 -08:00
3cf17c0094
Merge pull request #2225 from dchen1107/deathrattle
...
Capture application termination messages/output
2014-11-10 11:25:14 -08:00
57454cce81
Add support to capture application termination message and propagate
...
the message to the upper layer through ContainerStatus.
2014-11-10 10:56:23 -08:00
8ffbced280
Introduce terminationMessagePath to Container, and update conversion code
...
to assign the default path.
Move default setting for terminationMessagePath to conversion
from validation. Addressed other comments.
2014-11-10 10:55:56 -08:00
dfa076b79a
Dumping kubelet write/read timeout
2014-11-10 17:09:50 +01:00
b4ab6e6ecc
Remove dead code.
2014-11-07 11:05:35 -08:00
1d76452bc2
added support for authentication against the default docker registry when provided in the .dockercfg
...
a
2014-11-06 11:52:25 -08:00
e88e490614
Merge pull request #2143 from lavalamp/eventing2.1
...
Begin putting event emission into kubelet
2014-11-05 15:37:26 -08:00
0a1493a5ce
Merge pull request #2160 from dchen1107/fix
...
Restart network container when container's configure is changed.
2014-11-05 15:13:05 -08:00
dcc111bf13
Start putting event generation into kubelet (not enabled yet)
2014-11-05 15:09:14 -08:00
fc0dab630c
Merge pull request #2086 from markturansky/v1beta3_refactor
...
Refactor internal API for Services to match v1beta3
2014-11-04 21:48:02 -08:00
4b16e979e6
Fix nil docker client (how did this ever work???)
2014-11-04 16:58:37 -08:00
Tim Hockin