Joe Beda
8092a80ad9
Merge pull request #903 from erictune/cleanup4
...
Pass obj with lock by reference.
2014-08-14 14:29:01 -07:00
Eric Tune
ee91a19f90
Pass obj with lock by reference. Methods->funcs.
...
Fixes "lock passed by value" issues raised by "go vet".
2014-08-14 14:01:27 -07:00
Brendan Burns
7ea2a37219
deflake tests.
2014-08-13 15:41:42 -07:00
Clayton Coleman
7d24615d8e
Etcd can close the watch channel for services
...
Need to loop and reopen if it's closed.
2014-08-13 14:21:16 -04:00
Michal Fojtik
afbd7a6147
Make proxy/config/etcd.go less verbose when etcd is not available
2014-08-12 11:51:44 +02:00
Kouhei Ueno
2e02967aca
Avoid data race in Proxier.OnUpdate
...
The bug was that the proxier is passed as value on method decleration.
This caused a copy of Proxier to be created when the method was invoked.
The copy being a shallow copy turned out to have them both reference
a same map instance, but their mutexes were different instances.
This turned out to use different mutexes before operating on a same map
instance, which didn't make sense.
2014-08-06 04:34:54 +09:00
brendandburns
f87a93af7a
Merge pull request #754 from kelseyhightower/proxy-cleanup
...
proxy: cleanup and minor refactoring
2014-08-05 11:46:52 -07:00
Kelsey Hightower
1d3e660248
proxy: cleanup and minor refactoring
...
This change includes minor refactoring and cleanup of the proxy
package including the following items:
* Rename source files with misspelling of round robin
* Remove unnecessary and redundant comments
* Update comments for clarity
* Add locking when updating the round-robin index
* Improve method receiver names
* Rename the LoadBalance method to NextEndpoint to add clarity
No changes in behaviour have been introduced.
2014-08-05 07:18:12 -07:00
Clayton Coleman
0c33ed09d4
Remove long sleeps from proxy tests
2014-08-04 15:35:03 -04:00
Clayton Coleman
786b0399c3
Make interval a constant on proxy/config/etcd
...
Allow future testing of intervals
2014-08-04 15:34:43 -04:00
Brendan Burns
2cbe2c18d4
Add a comment to tickle travis.
2014-07-30 15:06:56 -07:00
Brendan Burns
9519a8049b
Fixed tests.
2014-07-30 15:02:36 -07:00
Brendan Burns
448a4b7d69
Revert "Revert "Add support for stopping a proxier.""
...
This reverts commit 19beaf71b5
.
2014-07-30 06:52:03 -07:00
Daniel Smith
19beaf71b5
Revert "Add support for stopping a proxier."
2014-07-29 23:24:57 -07:00
Daniel Smith
00bdeecb63
Merge pull request #682 from brendandburns/proxy
...
Add support for stopping a proxier.
2014-07-29 23:20:55 -07:00
brendandburns
b0d18b2af0
Merge pull request #571 from lavalamp/master
...
Decode/Encode everywhere
2014-07-29 17:19:33 -07:00
Brendan Burns
99f0d2e807
Add support for stopping a proxier.
2014-07-29 15:40:47 -07:00
Brendan Burns
aa703a4e72
Make file error logging edge triggered to reduce log spam.
2014-07-29 05:38:07 -07:00
Daniel Smith
b3cc696486
All types stored in etcd are now API objects.
...
This means I made an api.ContainerManifestList, and added a JSONBase to
endpoints (and changed Name -> JSONBase.ID).
2014-07-28 11:27:36 -07:00
Dan McPherson
7bbc5e2a19
Fixing typos
2014-07-28 15:15:50 +02:00
Jonathan Boulle
c43035088b
assorted formatting and typo fixes
2014-07-24 15:10:36 -07:00
Daniel Smith
05f01a3654
Revert "assorted formatting and typo fixes"
2014-07-18 17:16:30 -07:00
Jonathan Boulle
9e63c3a633
assorted formatting and typo fixes
2014-07-18 13:02:59 -07:00
Brendan Burns
744072a71e
Insert a couple of sleeps to slow things down.
2014-07-18 09:24:01 -07:00
Clayton Coleman
021cf64808
Change proxy config to reuse util/config
...
Splits endpoint and service configuration into their own objects. Also makes
the endpoint and service configuration tests correct - there was a race condition
previously that meant tests were passing but not checking correct code.
2014-07-16 14:13:25 -04:00
Yuki Yugui Sonoda
2861955025
Corrects wording of godoc comments.
2014-07-15 22:03:08 +09:00
Yuki Yugui Sonoda
1bd7276aca
Correct the style of nested conditionals
2014-07-15 20:58:03 +09:00
Yuki Yugui Sonoda
60dd1f7cc0
Eliminates tautological comments
2014-07-15 20:58:01 +09:00
Yuki Yugui Sonoda
41febcee5e
Merge branch 'master' into fix/golint
...
Conflicts:
pkg/master/master.go
pkg/master/pod_cache.go
pkg/proxy/config/file.go
pkg/proxy/proxier.go
pkg/proxy/roundrobbin.go
pkg/scheduler/randomfit.go
pkg/scheduler/randomfit_test.go
2014-07-15 20:57:47 +09:00
Clayton Coleman
f84a948c9c
Merge pull request #426 from claire921/cleanup
...
pkg/proxy/config: clean up file.Run()
2014-07-12 15:12:05 -04:00
Clayton Coleman
1af753a396
Merge pull request #420 from claire921/proxy
...
pkg/proxy: remove unnecessary go routine
2014-07-12 13:58:42 -04:00
Claire Li
78cad3fd5e
pkg/proxy/config: clean up file.Run()
2014-07-11 22:41:06 -07:00
brendandburns
89655584eb
Merge pull request #423 from claire921/onpudate
...
pkg/proxy: filtering before comparing
2014-07-11 22:33:09 -07:00
brendandburns
cde7b5841b
Merge pull request #422 from claire921/use_splithostport
...
pkg/proxy: use net.SplitHostPort instead of strings.Split
2014-07-11 22:32:50 -07:00
Claire Li
094b78d7de
pkg/proxy: filtering before comparing
2014-07-11 22:13:29 -07:00
Claire Li
ba07dc804c
pkg/proxy: use net.SplitHostPort instead of strings.Split
2014-07-11 22:08:53 -07:00
Claire Li
abcbce55ce
pkg/proxy: remove unnecessary io.EOF checking
2014-07-11 21:51:24 -07:00
Claire Li
4d47db8b5f
pkg/proxy: remove unnecessary go routine
2014-07-11 21:34:42 -07:00
Yuki Yugui Sonoda
7373695e33
Fixes golint errors in pkg/proxy
2014-07-11 22:35:57 +09:00
Burcu Dogan
1816a63d55
proxy: lock should be above the fields it protects.
2014-07-11 00:23:43 -07:00
Burcu Dogan
e4d966744d
proxy: fixing linting errors.
2014-07-10 22:36:06 -07:00
Nan Deng
b351578ddd
fix data race in config.go. This is a hard one.
2014-07-02 23:23:14 -07:00
Tim Hockin
9f9e75f508
Switch to glog for logging, bridge logging to glog.
...
1) imported glog to third_party (previous commit)
2) add support for third_party/update.sh to update just one pkg
3) search-and-replace:
s/log.Printf/glog.Infof/
s/log.Print/glog.Info/
s/log.Fatalf/glog.Fatalf/
s/log.Fatal/glog.Fatal/
4) convert glog.Info.*, err into glog.Error*
Adds some util interfaces to logging and calls them from each cmd, which
will set the default log output to write to glog. Pass glog-wrapped
Loggers to etcd for logging.
Log files will go to /tmp - we should probably follow this up with a
default log dir for each cmd.
The glog lib is sort of weak in that it only flushes every 30 seconds, so
we spin up our own flushing goroutine.
2014-06-24 20:51:57 -07:00
Daniel Smith
b850d36166
Fix boilerplate everywhere
2014-06-23 11:32:11 -07:00
Joe Beda
239e1273cf
The Mac is picky about the syntax for listening on ephemeral ports.
2014-06-13 16:04:17 -07:00
Daniel Smith
e1bc4d2eba
Port 2223 is in use on my machine sometimes, so this test was flaky.
2014-06-12 21:55:55 -07:00
Brendan Burns
164160adef
Address package level comments for readability.
2014-06-12 20:26:12 -07:00
Johan Euphrosine
4f6bed03ae
gofmt -s pkg/ cmd/
2014-06-12 14:16:19 -07:00
Joe Beda
2c4b3a562c
First commit
2014-06-06 16:40:48 -07:00