Commit Graph

42 Commits (465f7ebf43e879f9ae235489171612036ad16167)

Author SHA1 Message Date
Mehdy Bohlool c14e7e2004 Add e2e test for multi-version CRD admission webhook patch bug 2019-02-16 00:46:57 -08:00
Kubernetes Prow Robot d5a1ebbd33
Merge pull request #73634 from JoeWrightss/patch-2
Fix some typos in comment
2019-02-04 05:09:47 -08:00
zhoulin xie 777174080b Fix some typos in comment
Signed-off-by: zhoulin xie <zhoulin.xie@daocloud.io>
2019-02-01 21:11:55 +08:00
Mehdy Bohlool ea54a0c504 E2E Test 2018-11-09 12:50:22 -08:00
Audrey Lim 3eaab702fb Annotate errors in apimachinery e2e tests 2018-10-23 20:34:20 -07:00
Claudiu Belu 6db2dadc87 Fixes webhook test failures
The test "Should be able to deny attaching pod" can randomly fail
because it never waits for the pod to enter a "Running" state. Because
of this, the "kubectl attach" command can potentially fail, if the pod is
not in the correct state.

Additionally, if the "kubectl attach" actually manages to attach, then the
test will hang. The command should be executed with a timeout.
2018-10-08 16:55:33 -07:00
k8s-ci-robot 3fe21e5433
Merge pull request #68922 from BenTheElder/version-staging
move pkg/util/version to staging
2018-09-26 22:59:42 -07:00
jennybuckley 1ba644ef6b Add e2e test for mutating webhooks affecting webhook-config objects 2018-09-25 11:21:00 -07:00
Benjamin Elder 8b56eb8588 hack/update-gofmt.sh 2018-09-24 12:21:29 -07:00
Benjamin Elder 088cf3c37b find & replace version import 2018-09-24 12:03:24 -07:00
Chao Xu 201111b644 Added e2e test to check admission webhook works for pods/attach. 2018-08-06 18:59:52 -07:00
Kubernetes Submit Queue b904855601
Merge pull request #66870 from apelisse/dry-run-client
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

dry-run: Update DynamicClient to pass Create/Update options

Change dynamic client to accept Create and Update options on Create/Update/Patch methods.

**What this PR does / why we need it**:

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```
2018-08-02 17:00:29 -07:00
Antoine Pelisse 71970d6475 dry-run: Update DynamicClient to pass Create/Update options 2018-08-02 10:38:31 -07:00
Chao Xu be1ee3d5d3 Change the expected error message to the common part of the responses of 1.11 and 1.12 servers 2018-08-01 23:21:51 -07:00
Clayton Coleman 8a2d037bc5
Make the timeout error more specific so users can find it
This makes the error consistent with the timeout filter and also helps
the user understand that they requested a specific timeout.
2018-07-26 00:53:31 -04:00
Anthony Yeh 436db71751
Set explicit labels/selector for apps/v1 Deployment/RS. 2018-05-22 13:43:07 -07:00
Anthony Yeh a6a5190494
test/e2e: Use apps/v1 Deployment/ReplicaSet.
This must be done at the same time as the controller update,
since they share code.
2018-05-22 13:43:06 -07:00
David Eads fd044d152e fix dynamic client name 2018-05-11 13:12:09 -04:00
xuzhonghu 393324497f make use of simple dynamic client in test 2018-04-27 13:38:58 +08:00
jennybuckley 7fee22b7be Fix flaky crd e2e tests 2018-04-11 14:08:05 -07:00
Manjunath A Kumatagi 1bb810e749 Use pause manifest image 2018-04-06 11:00:50 +05:30
jennybuckley 3fcc269733 Cleanup CRD/CR confusion in webhook e2e tests 2018-04-03 15:14:30 -07:00
hzxuzhonghu 932a072990 add e2e case for crd webhook 2018-04-03 20:42:44 +08:00
jennybuckley cd06e4db1f Remove wildcard matching of no-op test webhooks 2018-03-21 15:13:43 -07:00
jennybuckley 58b43ad27d Prevent webhooks from affecting admission requests for webhooks 2018-03-05 16:35:52 -08:00
Walter Fender 0bdf29801c Fix flaky AdmissionWebhook e2e-crd tests
Several of the tests("It") in the e2e suite reuse the CRD.
However they each try to setup and tear down the CRD independently.
Since these tests can be running in parallel, causing intermittant
failures.
Added a new framework utility for creating CRDs per test.
Then making the relevant tests use the utility to prevent name
collision/race.
Fixed bazel build.
Factored in fixes for @caesarxuchao
Making suggested change for @janetkuo
2018-02-06 11:34:57 -08:00
Walter Fender e4e4979056 Fix flaky AdmissionWebhook e2e tests.
Several of the tests("It") in the e2e suite reuse the config name.
Since these tests can be running in parallel, causing intermittant
failures.
Changes the test so each test uses a different name.
Restructured the tests to make it easier to make sure the name in a
test is being used consistently.
Fix feedback from @caesarxuchao
Fixed format.
2018-01-29 18:14:08 -08:00
Chao Xu 5029bb56c4 Let mutating webhook defaults the object after applying the patch sent back by the webhook 2018-01-09 15:58:18 -08:00
liz b814c5677f
Collect all the assorted image URLs from e2e tests in one place
utils/image/manifest has an additional `arch` parameter, which determines
whether an image ends in `-$ARCH` (like `-amd64`).

All locations that previously had gcr.io urls referenced in costants or inline
have been updated to refere test/utils/image.
2017-12-19 12:16:07 -05:00
Walter Fender e1cf77858e Add e2e test for when a webhook does not return.
Adding code to simulate a webhook not returning.
Ensure that we verify that the returned error is a timeout.
2017-12-11 18:32:31 -08:00
Chao Xu 7945ae68d0 remove reference to v1alpha1 2017-11-21 13:00:40 -08:00
Chao Xu 0b3ee54076 fix webhook e2e test cleanup 2017-11-17 21:02:47 -08:00
Chao Xu ea123f82aa Adding the mutating webhook 2017-11-17 21:02:47 -08:00
cheftako dac3c2e168 Admission request/response handling
AdmissionResponse allows mutating webhook to send apiserver a json patch
to mutate the object.
This reflects the imperative nature of AdmissionReview. It adds
AdmissionRequest and AdmissionResponse in place of status/spec.
The AdmissionResponse the allows the mutating webhook
to send back a json path with the mutated version of the requested
object.
Fixed the integration test to clean up properly.
Switched test image to 1.8v5 to reflect API changes.
Make sure to cache test framework client for cleaup test code.
Switched to pointer for patch type.
Factored in @liggitt's feedback.
Factored in @lavalamp's feedback.
2017-11-17 14:22:55 -08:00
Yanqiang Miao 16aa5820fb Correct clean up actions in e2e tests 2017-11-17 08:46:21 +08:00
Janet Kuo 6432422307 Webhook e2e test: fail open and fail closed 2017-11-14 12:11:46 -08:00
Janet Kuo 7ffaa06ab3 Webhook e2e test: PUT and PATCH operations 2017-11-13 16:50:51 -08:00
Chao Xu ab053a224d let validation webhook convert objects to the external version before sending them 2017-11-13 12:55:33 -08:00
Daniel Smith a0cb2ce697 Add URL beside service 2017-11-11 16:09:34 -08:00
Chao Xu 7006d224be add NamespaceSelector to the api
business logic in webhook plugin and unit test

add a e2e test for namespace selector
2017-11-10 13:40:16 -08:00
mbohlool 9ddea83a2c Rename ExternalAdmissionHookConfiguration to ValidatingWebhookConfiguration 2017-11-09 11:39:50 -08:00
Chao Xu 88cb71c421 Add a e2e test for the admission webhook 2017-10-27 15:58:23 -07:00