481de197c0
Merge pull request #75156 from smarterclayton/diff_invalid
...
Handle nil interface inputs to diff.ObjectReflectDiff
2019-03-20 00:55:01 -07:00
6a2936dcbf
Merge pull request #74642 from SataQiu/fix-golint-20190227
...
Fix golint failures in client-go/scale/scheme/appsint, client-go/scale/scheme/extensionsint, client-go/scale/scheme
2019-03-19 20:14:54 -07:00
d261549a1c
Merge pull request #71813 from booxter/make-update-errors-visibility
...
Expose errors from godep_restored to caller
2019-03-19 19:00:25 -07:00
2fde54c1f3
staging: include generated code in godep verification
...
as we now commit up-to-date generated definitions in
apiextensions-apiserver
2019-03-13 17:11:05 -07:00
5d0bef342a
apiextensions: commit generated openapi definition
2019-03-13 15:15:34 -07:00
eb4865fbe5
Hack to ignore stale packages in godep
...
Change-Id: Ibf0877521310d6f2baad605bf1216940e95cb9cd
2019-03-12 09:49:03 -04:00
f71ac0fc5f
Merge pull request #75048 from dims/add-verify-check-for-publish-bot-dependencies
...
verify script to ensure publishing bot rules and godeps are in sync
2019-03-08 15:41:11 -08:00
9fd3d2718b
Merge pull request #75184 from liggitt/verify-godeps-generated
...
ignore uncommitted generated openapi files in verify-godeps
2019-03-08 14:19:47 -08:00
060e44ae85
ignore uncommitted generated openapi files in verify-godeps
2019-03-08 11:46:11 -05:00
f229aa0ad6
Merge pull request #75044 from errordeveloper/move-cli-runtime-subpackages
...
Move printers & resources packages
2019-03-08 05:43:26 -08:00
7d06bb8bc2
verify script to ensure publishing bot rules and godeps are in sync
...
Change-Id: Idbad862a797916cc4408ea0099c30d0557044907
2019-03-08 07:38:11 -05:00
fa0fd28767
Handle nil interface inputs to diff.ObjectReflectDiff
...
Causes a panic today. Add godoc bragging about how ridiculously awesome
ObjectReflectDiff is.
2019-03-08 00:15:50 -05:00
6d7a9048b6
Move printers & resources packages
...
These packages deserve to live at the top level of `k8s.io/cli-runtime`,
as they are potentially of wider use than genericclioptions.
2019-03-07 23:00:24 +00:00
820a1dc96b
Add node.k8s.io/v1beta1 API
2019-03-07 11:57:12 -08:00
63f61a6714
Migrate RuntimeClass to internal API
2019-03-07 11:07:54 -08:00
f8024ab087
Merge pull request #74904 from sttts/sttts-proto-tests
...
Rework proto generation scripts and add tests
2019-03-07 10:58:05 -08:00
ef5ba5cc8b
Merge pull request #75061 from andrewsykim/fix-mac-bazel
...
fix hack/update-bazel.sh for mac os environments
2019-03-07 01:07:52 -08:00
bd8eeaaaaf
Merge pull request #74468 from ixdy/bazel-cgo-crossbuild
...
bazel: improve multi-arch support for docker image artifacts
2019-03-06 20:35:11 -08:00
88a685feef
Merge pull request #74807 from runyontr/test-cmd-kubeadm-isolation
...
Kubeadm test Isolation: #74464
2019-03-06 17:59:52 -08:00
752d18d2b0
Merge pull request #74510 from SataQiu/fix-golint-2019022502
...
Fix some golint failures for pkg/kubelet/apis/...
2019-03-06 17:59:25 -08:00
a6c3a26c34
fix hack/update-bazel.sh for mac os environments
2019-03-06 15:47:25 -05:00
8495f7c9ed
bazel: add docker_push rules
2019-03-06 12:35:33 -08:00
a7346b60bc
Merge pull request #74970 from ipuustin/lib-util-sh-2
...
hack/lib/util.sh: fix empty array expansion with bash 3.
2019-03-06 02:08:33 -08:00
45b0d9bd0a
hack/*protobuf.sh: dynamically find api roots
2019-03-06 08:36:14 +01:00
9f7560de70
Merge pull request #74153 from ixdy/bazel-kubernetes-src-tarball-new
...
bazel: make kubernetes-src.tar.gz actually include all srcs
2019-03-05 21:42:00 -08:00
21239a350d
fix golint failures in client-go/scale/scheme/appsint, client-go/scale/scheme/extensionsint, client-go/scale/scheme
2019-03-06 13:26:39 +08:00
ecb6d13253
hack/lib/util.sh: fix empty array expansion with bash 3.
2019-03-05 21:34:08 +02:00
b4e692b68f
Merge pull request #74854 from neolit123/conformance-nodes
...
conformace/run_e2e.sh: pass shellcheck and autodetect ginkgo nodes
2019-03-05 09:50:12 -08:00
493f53433a
Merge pull request #74872 from nikopen/patch-2
...
cherry picks usage info link
2019-03-05 08:16:37 -08:00
298b8869cf
Merge pull request #74800 from danielqsj/mgo
...
fix golint failures for some files under metrics k8s.io/metrics/pkg/apis
2019-03-05 06:51:20 -08:00
e24e26fac8
Merge pull request #74647 from danielqsj/e2ein
...
Fix golint failures for e2e/instrumentation/...
2019-03-05 06:51:10 -08:00
890b5c1d9a
Merge pull request #74582 from SataQiu/fix-golint-2019022602
...
fix some golint failures for plugin/pkg/admission/...
2019-03-05 06:50:46 -08:00
6c31101257
Merge pull request #74283 from xing-yang/csi_crd_controller
...
CSINodeInfo and CSIDriver Controller Changes
2019-03-05 04:44:42 -08:00
baf4eb67ac
Merge pull request #74257 from ipuustin/lib-util-sh
...
Fix shellcheck-reported errors in hack/lib/util.sh.
2019-03-04 23:11:59 -08:00
e2f42845d1
Merge pull request #74487 from danielqsj/window
...
Fix golint failures for e2e/windows
2019-03-04 19:27:11 -08:00
fe2301f17d
conformace/run_e2e.sh: pass shellcheck and autodetect ginkgo nodes
...
- for ginkgo parallel mode pass -p to autodetect ginkgo nodes.
- disable parallel mode by default (false).
- use provider "skeleton" instead of "local".
- make run_e2e.sh pass shellcheck.
2019-03-05 01:32:57 +02:00
5cf1950ef8
Fix golint in test/e2e/instrumentation/logging
2019-03-05 07:10:39 +08:00
873fbf9112
Fix golint in test/e2e/instrumentation/monitoring
2019-03-05 07:07:06 +08:00
dddb13c690
Merge pull request #74711 from SataQiu/fix-golint-2019022802
...
Fix golint failures in staging/src/k8s.io/apiserver/pkg/storage/errors, staging/src/k8s.io/apiserver/pkg/storage/etcd
2019-03-04 13:25:38 -08:00
5756eea804
Merge pull request #74700 from SataQiu/fix-golint-20190228
...
Fix golint failures in test/e2e/instrumentation, test/e2e_node/environment
2019-03-04 13:25:26 -08:00
f7e1058c98
shellcheck failures: remove hack/lib/util.sh
2019-03-04 23:23:20 +02:00
1e34d9df7d
hack/lib/util.sh: replace sed with bash replace.
...
Test script:
#!/bin/bash
rev1="foo"
rev2="\"bar\""
rev3="'bar'"
newrev1="${rev1//[\'\"]}"
newrev2="${rev2//[\'\"]}"
newrev3="${rev3//[\'\"]}"
oldrev1=$(echo "${rev1}" | sed "s/['\"]//g")
oldrev2=$(echo "${rev2}" | sed "s/['\"]//g")
oldrev3=$(echo "${rev3}" | sed "s/['\"]//g")
echo "$newrev1 vs. $oldrev1"
echo "$newrev2 vs. $oldrev2"
echo "$newrev3 vs. $oldrev3"
expected output:
foo vs. foo
bar vs. bar
bar vs. bar
2019-03-04 23:23:20 +02:00
0078fce5bd
hack/lib/util.sh: don't implicitly convert "find" results into array.
...
Also fix array item comparison. Test script for the comparison change:
#!/bin/bash
staging_apis=(extensions/v1beta1 extensions/v1 extensions/v1alpha)
group_versions=(v1 extensions/v1beta1 extensions/v1 extensions.k8s.io/v1)
for group_version in ${group_versions[@]}; do
# original code
if [[ " ${staging_apis[@]} " =~ " ${group_version/.*k8s.io/} " ]]; then
echo "orig: vendor/k8s.io/api/${group_version/.*k8s.io/}"
fi
# new code
for api in ${staging_apis[@]}; do
if [[ "${api}" = "${group_version/.*k8s.io/}" ]]; then
echo "new: vendor/k8s.io/api/${group_version/.*k8s.io/}"
fi
done
done
Expected output:
orig: vendor/k8s.io/api/extensions/v1beta1
new: vendor/k8s.io/api/extensions/v1beta1
orig: vendor/k8s.io/api/extensions/v1
new: vendor/k8s.io/api/extensions/v1
orig: vendor/k8s.io/api/extensions/v1
new: vendor/k8s.io/api/extensions/v1
2019-03-04 23:23:20 +02:00
edd806330a
hack/lib/util.sh: mark variables to be used in a sourcing context.
...
"Decorate" the variables with a no-op function to prevent shellcheck
from complaining that they are not being used. This method provides
visibility to which variables are supposed to be used in a sourcing
script compared to just disabling the warning.
2019-03-04 23:23:20 +02:00
24b5c67723
hack/lib/util.sh: various shellcheck-reported cleanups.
...
Use "command -v" instead of "which". Also remove the redirections,
since "command -v" does not return an error message if the command isn't
found. Also use "read -r" instead of "read" and quote variables
properly. Do some error handling if "pushd" or "popd" fail. Read values
properly into arrays.
However, one shellcheck error is ignored in trap mechanism. The logic
in trap_add function requires the trap command to be expanded when run.
Just storing the variable into trap doesn't work. Add a shellcheck
disable directive to ignore the error.
An alternative to ignoring could be tricking shellcheck with:
trap ''"${new_cmd}" "${trap_add_name}"
2019-03-04 23:18:54 +02:00
32f4bf6edf
cherry picks usage info link
2019-03-04 03:20:41 +00:00
bb45b8ee34
Make CSINodeInfo and CSIDriver Core APIs
...
This PR is the first step to transition CSINodeInfo and CSIDriver
CRD's to in-tree APIs. It adds them to the existing API group
“storage.k8s.io” as core storage APIs.
2019-03-02 12:31:05 -08:00
222dd0af4c
Merge pull request #71022 from emwalker/68026-golint-fixes-5
...
Remove test/integration/* from hack/.golint_failures
2019-03-01 14:08:33 -08:00
8acb522c03
Merge pull request #74488 from xichengliudui/fixshellcheck19022502
...
fix shellcheck in test/e2e_node/jenkins/...
2019-03-01 12:49:08 -08:00
1e44e33517
pulled kubeadm tests out of runTests to run before tests in test/cmd
...
Added timeout for https://github.com/kubernetes/kubeadm/issues/1430
2019-03-01 12:17:25 -05:00
Kubernetes Prow Robot