Commit Graph

63 Commits (42aba643290c19a63168513bd758822e8014a0fd)

Author SHA1 Message Date
mattjmcnaughton 214b910511 Fix shellcheck errors for some scripts in hack/
Five more of the hack/verify-* scripts now pass shellcheck and have been
removed from hack/.shellcheck_failures.
2019-02-19 10:08:15 -05:00
Sen Lu d6801b8211 Diff between PULL_BASE_SHA and HEAD when detecting file changes from
Prow
2019-01-08 11:17:00 -08:00
Christoph Blecker b19fb0a77e
Clean up artifacts variables in hack scripts 2018-12-19 15:17:13 -08:00
Christoph Blecker bc7e7e5114
Remove ignore on GodepVersion and Godep comments 2018-11-07 11:02:08 -08:00
Christoph Blecker 35cdbdf16c
Use ensured godep instead of relying on PATH 2018-11-07 11:02:01 -08:00
Matthias Bertschy 9b15af19b2 Update all script to use /usr/bin/env bash in shebang 2018-04-19 13:20:13 +02:00
Jeff Grafton 3ed87e2ac2 Fully resolve tmpdir in verify scripts, since it might be a symlink on macOS 2018-04-06 16:37:19 -07:00
Tim Hockin 3e583de0ac Vendor gazelle 2018-03-29 17:01:30 -07:00
Ismo Puustinen 03b674bc86 verify-godeps: change redirection order.
In code "popd 2>&1 > /dev/null" the stderr output goes to the terminal
instead of /dev/null, which is clearly the intention. Change the order
to fix this in four places. Also, while at it, change one incorrect
comparison to use "-gt" instead of ">" in the same file.
2018-03-23 15:37:03 +02:00
Christoph Blecker a11ea4e45f
Enforce OWNERS file in Godeps and vendor dirs 2018-02-15 13:30:30 -08:00
Christoph Blecker a34b1cfcfa
Route verify-godeps output to stderr 2018-02-07 21:44:35 -08:00
Christoph Blecker 61b4f176d9
Ignore OWNERS file in verify-godeps 2018-02-04 23:54:08 -08:00
Kubernetes Submit Queue aa12b9b7cb
Merge pull request #58849 from cblecker/staging-speed
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Only run verify-staging-godeps if staging/godeps are touched

**What this PR does / why we need it**:
I had a lightbulb moment. On presubmit, we only verify godeps if one of the following is changed:
- The godep scripts
- The Godeps/ dir
- The vendor/ dir

The same should apply to verifying the staging godeps, adding in the staging dir itself. The logic being, if we don't touch Godeps/vendor, we don't touch the script that generates stuff, and we don't make changes to the staging dir itself (like adding/removing imports), then we don't need to verify godeps.

Note that post-submit CI jobs will still check these, as I'm copying the same logic that's in verify-godeps

This seems too easy, so *please* point out if I'm missing something.

**Release note**:
```release-note
NONE
```
2018-01-31 09:33:45 -08:00
Christoph Blecker d58afe6384
When installing vendored godep, ensure that it's in path 2018-01-30 09:30:36 -08:00
Christoph Blecker 78ed389122
Remove unneeded code 2018-01-30 09:29:51 -08:00
Christoph Blecker 0088f3d67f
Add in godeps verification for hack/lib/ and build/ 2018-01-26 13:29:35 -08:00
Jordan Liggitt 125a840445
Target godep script change verifications 2017-08-09 22:34:13 -04:00
Christoph Blecker 8b3bf13806
Fix godep verify to use godep restore script 2017-07-07 23:16:54 -07:00
Christoph Blecker 2b111c5a55
Run verify-godeps.sh fully if hack/ dir changes 2017-07-07 23:16:37 -07:00
Christoph Blecker 3ad13293bc
Export patch files to artifacts 2017-03-25 12:16:50 -07:00
Christoph Blecker 4d85a54027
Change verify-godeps.sh use ensure_godep_version 2017-03-15 10:32:44 -07:00
Solly Ross 77069cd9ec Add staging repos to GOPATH in verify-godeps
This commit adds the staging repos to the GOPATH in
hack/verify-godeps.sh.  This allows vendored librarys
to depend on staging repos and not break verify-godeps.

This also adds `hack/godep-restore.sh`, which acts like
`godep restore`, but sets the GOPATH appropriate as well.
2017-03-01 10:23:30 -05:00
Eric Paris cc4a357664 Fix undefined KEEP_TMP in verify-godeps.sh 2017-01-24 14:45:20 -05:00
Eric Paris 57b12c9d09 Make verify-godeps.sh easier to debug
This does 3 things:

1. env var to retain the /tmp/godep
2. env var to use a specified /tmp/godep
3. rework of preload-dep to support more non-github things, like go4.org
2017-01-13 13:42:58 -05:00
saadali 62ee8b9d49 Move godeps to version v74 instead of v73 2016-11-03 00:43:06 -07:00
saadali 9e9a66ed22 Ensure verify-godep passes godep to godep-save 2016-11-02 23:49:30 -07:00
saadali 87636fdd78 Fix godep to v73 in verify-godeps 2016-11-02 21:08:26 -07:00
Saad Ali d41b3b0929 Revert "Add missing vendor files to make godeps happy" 2016-11-02 20:56:06 -07:00
saadali e9afbd5cdf Add missing vendor files to make godeps happy 2016-11-02 18:55:10 -07:00
saadali 683ea197be Hard code godep version to v74
See issue #36111
2016-11-02 16:33:53 -07:00
Mike Danese b250a8809d don't check BUILD file when verifying godeps 2016-10-21 17:32:33 -07:00
Daniel Smith 4eeebf76ae make verify godeps help you fix your problems 2016-09-21 18:08:41 -07:00
Tim Hockin b9d68ab566 Make verify-godeps check the results 2016-08-02 09:06:14 -07:00
Antoine Pelisse b681b17bb0 Revert "Fix working_set calculation in kubelet" 2016-07-20 17:04:32 -07:00
Vishnu kannan feb732195f run godeps twice in validation to include recursive dependencies
Signed-off-by: Vishnu kannan <vishnuk@google.com>
2016-07-20 11:11:56 -07:00
David McMahon ef0c9f0c5b Remove "All rights reserved" from all the headers. 2016-06-29 17:47:36 -07:00
k8s-merge-robot 421c12e69e Merge pull request #26458 from david-mcmahon/godep-version
Automatic merge from submit-queue

Check for a valid godep version.
2016-06-03 11:04:38 -07:00
David McMahon d038c53c0b Check for a valid godep version. 2016-06-02 16:35:14 -07:00
David McMahon 12edc97862 Verify changes against upstream vendor/ as well. 2016-05-27 16:27:42 -07:00
Michael Rubin 7900d0897d Adding "Pass/Fail" echo 2016-05-23 12:03:56 -07:00
Eric Paris b4f5108d39 Ignore godep version used to created Godep.json 2016-05-12 22:04:24 -04:00
Eric Paris ad3e18d60c Stop pinning to version v53 2016-05-12 22:04:24 -04:00
Eric Paris 5543e2e3fd Create a script to update godeps
Since its hard for an individual to remember that we need codecgen and
ginkgo in godeps but don't actually have that dependancy listed in a way
that godep can automatically find.
2016-05-12 22:04:19 -04:00
saadali 07f1e58d9a Modify verify-godeps to use v63 and hack 2016-05-11 17:59:29 -07:00
Tim Hockin 833770d9ac Fix verify-godeps 2016-05-08 20:30:39 -07:00
Tim Hockin cbf886c7f4 Convert everything to use vendor/ 2016-05-08 20:30:37 -07:00
Random-Liu 3876972d3f Clean up go-dockerclient reference. 2016-04-29 13:32:19 -07:00
Joe Finney 7fb8a8e46c Disable the vendor experiment in hack/verify-godeps.sh 2016-03-22 13:50:15 -07:00
Jeff Grafton 59a91326fa Automatically determine remote upstream name.
Also add option to force Godeps verification checks on post-commit
Jenkins.
2016-03-09 16:22:28 -08:00
Jeff Grafton 24b3223141 Make skipping logic more robust in hack/verify-godep*
Also add an environment variable, KUBE_VERIFY_GIT_BRANCH, used with this
logic.
2016-03-09 15:20:36 -08:00