Commit Graph

338 Commits (40bf368f0f8a46c84bf4fc996c26b07ccca6c5d7)

Author SHA1 Message Date
Andy Goldstein d8fec75658 Fixes for golint tip
golint as of
3390df4df2/lint.go (L1440-L1442)
requires that any function that has a context.Context argument have said
argument in the first position. This commit fixes the one function we had where
it wasn't.
2016-10-27 12:07:23 -04:00
Kubernetes Submit Queue 6f80ec91d6 Merge pull request #35415 from wojtek-t/avoid_get
Automatic merge from submit-queue

Try to avoid Get to etcd in GuaranteedUpdate in Cacher
2016-10-26 16:15:06 -07:00
Kubernetes Submit Queue 6fd9acd3e1 Merge pull request #35621 from wojtek-t/reduce_watch_cache_lock_contention
Automatic merge from submit-queue

Reduce lock contention in watchCache
2016-10-26 14:23:30 -07:00
Wojciech Tyczynski 04e50ae119 Reduce lock contention in watchCache 2016-10-26 13:44:16 +02:00
Wojciech Tyczynski 5d2062db9f Reduce amount of not-helping logs in apiserver 2016-10-26 13:20:07 +02:00
Wojciech Tyczynski a1090151ef Try to avoid Get to etcd in GuaranteedUpdate in Cacher 2016-10-25 21:59:02 +02:00
Mike Danese 3b6a067afc autogenerated 2016-10-21 17:32:32 -07:00
Wojciech Tyczynski 93c008f8a4 Support resourceVersion in GetToList - unify interface of List and GetToList 2016-10-21 10:09:23 +02:00
Kubernetes Submit Queue 5fcb9fd056 Merge pull request #35125 from wojtek-t/avoid_unnecessary_reallocations
Automatic merge from submit-queue

Avoid unnecessary reallocations of slice in Cacher
2016-10-19 20:33:13 -07:00
Wojciech Tyczynski 0ced3f43bf Avoid unnecessary reallocations of slice in Cacher 2016-10-19 19:33:33 +02:00
Wojciech Tyczynski 8040719d7f Avoid computing key func multiple times in cacher 2016-10-19 08:38:18 +02:00
Wojciech Tyczynski f10b0205e7 Store keys in watchCache store 2016-10-19 08:38:18 +02:00
Wojciech Tyczynski 9895f337ee Avoid unnecessary copies in cacher 2016-10-19 08:33:58 +02:00
mbohlool 25afcc5522 Add +optional tag to all fields with omitempty json tag 2016-10-17 08:52:13 -07:00
Wojciech Tyczynski 0f2270698c Reduce amount of annoying logs in cacher 2016-10-17 16:15:24 +02:00
Wojciech Tyczynski 6d06a384ad Extend tracing in watchCache 2016-10-17 11:22:59 +02:00
Wojciech Tyczynski 4d5ac91f88 Add tracing to listing in Cacher 2016-10-17 08:58:40 +02:00
Wojciech Tyczynski 81779360de Accept Quorum parameter in etcd3. 2016-10-15 16:53:56 +02:00
Wojciech Tyczynski 2298e1746c Increase buffer sizes in cacher for watchers interested in all/many objects. 2016-10-13 16:40:33 +02:00
Wojciech Tyczynski b675b2230c Avoid unnecessary decoding in etcd3 client 2016-10-11 10:38:46 +02:00
Hongchao Deng 2516ab058d etcd3 watcher: use prevKV for prevObj 2016-10-10 09:46:40 -07:00
Kubernetes Submit Queue b5145e1924 Merge pull request #34322 from wojtek-t/cacher_improvements
Automatic merge from submit-queue

Improve some logging in cacher
2016-10-08 00:38:48 -07:00
deads2k 518d5500c7 remove testapi.Default.GroupVersion 2016-10-07 10:10:54 -04:00
Wojciech Tyczynski c02df26ad6 Improve some logging in cacher 2016-10-07 15:04:08 +02:00
Wojciech Tyczynski d70a9615ec Minor clearnup in etcd3 code 2016-10-06 15:38:34 +02:00
Wojciech Tyczynski 90bc19959d Extend logging in cacher to understand its bottleneck 2016-10-06 10:57:46 +02:00
Wojciech Tyczynski 82c360a252 Make gets for previous value in watch serializable 2016-10-05 13:18:31 +02:00
Hongchao Deng 35917e552a revert #32012 (Unshare cluster in each test suite)
Since #33393 is merged, the bug should have been fixed.
2016-09-27 09:38:18 -07:00
Hongchao Deng 6f3ac807fd pass SelectionPredicate instead of Filter to storage layer 2016-09-26 09:47:19 -07:00
Kubernetes Submit Queue 331eb83585 Merge pull request #33376 from luxas/fix_arm_atomics_2
Automatic merge from submit-queue

Move HighWaterMark to the top of the struct in order to fix arm, second time

ref: #33117

Sorry for not fixing everyone at once, but I seriously wasn't prepared for that quick LGTM 😄, so here's the other half.

@lavalamp 

> lgtm, but seriously, this is terrible, we probably have this bug all over. And what if someone embeds the etcdWatcher struct in something else not at the top? We need the compiler to enforce things like this, it just can't be done manually. Can you file or link a golang issue for this?

I totally agree! There isn't currently a way of programmatically detecting this unfortunately.
I guess @davecheney or @minux can explain better to you why it's so hard.

This is noted in https://github.com/kubernetes/kubernetes/blob/master/docs/proposals/multi-platform.md as a corner case indeed.

@pwittrock This should be cherrypicked toghether with #33117
2016-09-23 12:05:09 -07:00
Lucas Käldström 06917531b3 Move HighWaterMark to the top of the struct in order to fix arm, second time 2016-09-23 20:58:28 +03:00
Madhusudan.C.S c1f0d91c2a Dereference the UID pointer for a readable error message. 2016-09-22 20:34:06 -07:00
Kubernetes Submit Queue d323fed024 Merge pull request #33003 from hongchaodeng/etcd_fix2
Automatic merge from submit-queue

stop etcd watcher when watch chan is closed

When startWatching() stops due to the watch chan is closed, the watcher could still keeps running in the background. When this case happen, we should stop the watcher entirely and close ResultChan() too.
2016-09-20 20:21:24 -07:00
Hongchao Deng 8e3b40735a stop etcd watcher when watch chan is closed 2016-09-20 12:45:28 -07:00
Lucas Käldström 519379138d Move HighWaterMark to the top of the struct in order to fix 32-bit platforms 2016-09-20 22:44:56 +03:00
Hongchao Deng 5a4a095e29 etcd watcher: centralize error handling 2016-09-16 15:31:49 -07:00
Hongchao Deng 3e9af272d5 etcd3/watcher: logging error 2016-09-15 17:23:04 -07:00
Kubernetes Submit Queue 0a62dab566 Merge pull request #32645 from wojtek-t/fix_cacher_logging
Automatic merge from submit-queue

Fix logging in cacher

@smarterclayton @liggitt @hongchaodeng
2016-09-15 05:56:39 -07:00
Timothy St. Clair 9f3841b452 Revert "Revert "Enable v3 Client as the default on UTs""
This reverts commit 9dcef2e3cd.
2016-09-14 07:27:21 -05:00
Wojciech Tyczynski e5b3f19638 Fix logging in cacher 2016-09-14 09:13:41 +02:00
Wojciech Tyczynski 949dd90593 Extend logging for performance debuggin 2016-09-12 12:46:19 +02:00
Wojciech Tyczynski 03a23aed09 Log water mark for incoming queue in cacher 2016-09-09 11:35:05 +02:00
Kubernetes Submit Queue 504ccc6f37 Merge pull request #32275 from wojtek-t/split_process_event
Automatic merge from submit-queue

Split dispatching to watchers in Cacher into separate goroutine.

Should help with #32257
2016-09-08 07:42:12 -07:00
Wojciech Tyczynski e750454c31 Fix allow for non-ready nodes in e2e framework 2016-09-08 14:22:08 +02:00
Wojciech Tyczynski 378cd81dbe Split dispatching to watchers in Cacher into separate goroutine. 2016-09-08 13:27:54 +02:00
Wojciech Tyczynski bd54c389f5 Extend logging for scalability tests debugging 2016-09-08 12:02:59 +02:00
Kubernetes Submit Queue 9f58a867e1 Merge pull request #31522 from krousey/path_validation
Automatic merge from submit-queue

Split path validation into a separate library

This PR splits path segment validation into it's own package. This cuts off one of the restclient's dependency paths to some docker packages, and completely eliminates its dependency on go-restful swagger validation.


cc @kubernetes/sig-api-machinery
2016-09-07 10:14:32 -07:00
Hongchao Deng 8723fbaa61 unshare cluster, store in each test suite 2016-09-02 15:04:23 -07:00
Kris e87edf9bd5 Split path validation into a separate library 2016-08-26 08:05:20 -07:00
Hongchao Deng 9131fbd446 refactor destroy func in unit testing 2016-08-25 22:57:28 -07:00