Janet Kuo
|
10aee82ae3
|
Rename PetSet API to StatefulSet
|
2016-10-27 17:25:10 -07:00 |
|
m1093782566
|
fd47b6d4d1
|
change petset replicas type from int to int32
Change-Id: I0b8c30083e4a221421de46d9d4dcb21b1f5bb36f
|
2016-10-08 17:13:20 +08:00 |
|
Kubernetes Submit Queue
|
6c1c0b9842
|
Merge pull request #32027 from m1093782566/m109-petset-fix-test-err
Automatic merge from submit-queue
[BUG FIX] Fix bug of UT in Pet Set
<!-- Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, read our contributor guidelines https://github.com/kubernetes/kubernetes/blob/master/CONTRIBUTING.md and developer guide https://github.com/kubernetes/kubernetes/blob/master/docs/devel/development.md
2. If you want *faster* PR reviews, read how: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/faster_reviews.md
3. Follow the instructions for writing a release note: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/pull-requests.md#release-notes
-->
**What this PR does / why we need it**:
Fix bug of UT in Pet Set.
[1] https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/petset/pet_set_test.go#L74-L75,
I think` len(pl)` is not equal to `len(fc.pets)`, see [here](https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/petset/fakes.go#L229-L233)
[2] https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/petset/fakes.go#L249
I think should change to
```
if len(f.pets) <= index {
```
because when `len(f.pets)==index`, then [here](https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/petset/fakes.go#L252-L254) will cause `index out of range` panic!
[3] https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/petset/fakes.go#L271
same reason with [2]
[4] https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/petset/pet_set_test.go#L79
which doesn't make use of the error returned by [setHealthy](https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/petset/fakes.go#L248) and has a risk of letting the error out.
Should we catch the error and use `t.Errorf()` to stop the test?
|
2016-09-26 21:13:14 -07:00 |
|
m1093782566
|
927569bc5b
|
fix petset ut bug
|
2016-09-07 00:26:25 +08:00 |
|
m1093782566
|
7dd675ef32
|
clean up pet set code
Change-Id: I60562bb1aa44436a23cfc5e50d6037adcce417c6
|
2016-09-03 21:28:46 +08:00 |
|
David McMahon
|
ef0c9f0c5b
|
Remove "All rights reserved" from all the headers.
|
2016-06-29 17:47:36 -07:00 |
|
Clayton Coleman
|
5e4308f91d
|
Update use of Quantity in other classes
|
2016-05-19 08:41:43 -04:00 |
|
k8s-merge-robot
|
15919f336f
|
Merge pull request #25284 from bprashanth/service_unready
Automatic merge from submit-queue
Add a service annotation that allows endpoints for unready pods
See https://github.com/kubernetes/kubernetes/issues/25283 for context
@smarterclayton @thockin yes?
<!-- Reviewable:start -->
---
This change is [<img src="http://reviewable.k8s.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](http://reviewable.k8s.io/reviews/kubernetes/kubernetes/25284)
<!-- Reviewable:end -->
|
2016-05-12 12:05:27 -07:00 |
|
saadali
|
b83af3d481
|
Change "speter.net/go/exp/math/dec/inf" dependency
to "https://gopkg.in/inf.v0"
|
2016-05-11 17:01:28 -07:00 |
|
Prashanth Balasubramanian
|
377957a173
|
PetSet doesn't scale if it finds unready pets
|
2016-05-10 13:03:28 -07:00 |
|
Prashanth Balasubramanian
|
6bc3052551
|
PetSet alpha controller
|
2016-05-04 18:39:17 -07:00 |
