Commit Graph

6 Commits (1635393bd1cb21e82fbc899ce7fd6a997194abe2)

Author SHA1 Message Date
Mike Danese 9d9e588ced e2e: save raw profiles too 2018-04-23 13:06:37 -07:00
Kubernetes Submit Queue 4b69418676
Merge pull request #59661 from shyamjvs/fix-profile-gatherer
Automatic merge from submit-queue (batch tested with PRs 59424, 59672, 59313, 59661). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Disable symbol resolution by pprof in profile-gatherer

Because otherwise it is failing while trying to symbolize, due to lack of a kube-apiserver binary locally (as noted by @wojtek-t) within the job pod:

```
Local symbolization failed for kube-apiserver: open /usr/local/bin/kube-apiserver: no such file or directory
```

This does seem to still produce a graph with all named references - so it seems fine to avoid it. The [documentation](https://github.com/google/pprof/blob/master/doc/pprof.md#symbolization) says:

```
pprof can add symbol information to a profile that was collected only with address information. This is useful for profiles for compiled languages, where it may not be easy or even possible for the profile source to include function names or source coordinates.
```

So my feeling is that for golang, the function names, etc are included in the profile source.

/cc @wojtek-t @kubernetes/sig-scalability-misc 

```release-note
NONE
```
2018-02-09 14:46:37 -08:00
Shyam Jeedigunta f9834e3cf7
Disable symbol resolution by pprof in profile-gatherer 2018-02-09 16:36:25 +01:00
Wojciech Tyczynski 3e3dee6850 Print stderr from go tool pprof in profile gatherer 2018-02-09 14:39:08 +01:00
Shyam Jeedigunta c3db0828f9
Add apiserver profiling to our scalability tests 2018-02-08 11:09:31 +01:00
Shyam Jeedigunta f8cee91372 Introduce apiserver profile-gathering library in testing framework 2018-02-02 13:27:29 +01:00