Ed Bartosh
ab655a29b8
kubeadm: fix nil pointer dereference
...
If configuration file doesn't exist client variable is not assigned
and causes kubeadm crash:
$ sudo ./_output/bin/kubeadm reset
[reset] Reading configuration from the cluster...
[reset] FYI: You can look at this config file with 'kubectl -n kube-system get cm kubeadm-config -oyaml'
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0xf8 pc=0x108c9e7]
goroutine 1 [running]:
cmd/kubeadm/app/util/config.getInitConfigurationFromCluster(0x171109b, 0xf, 0x0, 0x0, 0xc0005b5a00, 0x3, 0x3, 0x69)
cmd/kubeadm/app/util/config/cluster.go:93 +0x37
cmd/kubeadm/app/util/config.loadConfiguration(0x0, 0x0, 0x18d63a0, 0xc00000c018, 0x170620b, 0x5, 0x0, 0x0, 0x15d6000, 0x18d7601, ...)
cmd/kubeadm/app/util/config/cluster.go:67 +0x374
k8s.io/kubernetes/cmd/kubeadm/app/util/config.FetchConfigFromFileOrCluster(0x0, 0x0, 0x18d63a0, 0xc00000c018, 0x170620b, 0x5, 0x0, 0x0, 0x497700, 0x18d63e0, ...)
cmd/kubeadm/app/util/config/cluster.go:45 +0x9c
k8s.io/kubernetes/cmd/kubeadm/app/cmd.resetDetectCRISocket(0x0, 0x0, 0x1, 0x0, 0x18d63e0, 0xc0003f0630)
cmd/kubeadm/app/cmd/reset.go:304 +0x73
k8s.io/kubernetes/cmd/kubeadm/app/cmd.NewCmdReset.func1(0xc0002a6780, 0x26dd548, 0x0, 0x0)
cmd/kubeadm/app/cmd/reset.go:71 +0x267
k8s.io/kubernetes/vendor/github.com/spf13/cobra.(*Command).execute(0xc0002a6780, 0x26dd548, 0x0, 0x0, 0xc0002a6780, 0x26dd548)
vendor/github.com/spf13/cobra/command.go:760 +0x2cc
k8s.io/kubernetes/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0xc00019a000, 0xc000389180, 0xc00019a500, 0xc00057c1a0)
vendor/github.com/spf13/cobra/command.go:846 +0x2fd
k8s.io/kubernetes/vendor/github.com/spf13/cobra.(*Command).Execute(0xc00019a000, 0xc00000c010, 0x18d63a0)
vendor/github.com/spf13/cobra/command.go:794 +0x2b
k8s.io/kubernetes/cmd/kubeadm/app.Run(0xc000086180, 0x18b)
cmd/kubeadm/app/kubeadm.go:48 +0x202
main.main()
cmd/kubeadm/kubeadm.go:29 +0x33
Removing check for configuration file existence should fix the issue.
2019-02-01 15:36:43 +02:00
Kubernetes Prow Robot
ad58fb1ea0
Merge pull request #73542 from juanvallejo/jvallejo/log-missing-dir-errors
...
make missing-directory errors non fatal
2019-02-01 04:45:12 -08:00
Kubernetes Prow Robot
35b09e5370
Merge pull request #73437 from dims/update-to-latest-gophercloud
...
Update to latest gophercloud
2019-02-01 04:45:00 -08:00
Maciej Borsz
afeabe99b7
Fix typo in create-heapster-node
2019-02-01 11:04:23 +01:00
Kubernetes Prow Robot
a3c14ecfa5
Merge pull request #73606 from krzysztof-jastrzebski/daemonsets
...
Deleting pods assigned to not existing nodes only if
2019-01-31 23:30:13 -08:00
Kubernetes Prow Robot
1b741f4c77
Merge pull request #73246 from danielqsj/code-generator
...
fix shellcheck in code-generator
2019-01-31 21:58:21 -08:00
Kubernetes Prow Robot
5be8d9552b
Merge pull request #70005 from stewart-yu/stewart-cloud-controller-manager-movefile
...
remove `pkg/controller` dependencies from `k8s.io/kubernetes/pkg/cloudprovider/providers`
2019-01-31 20:43:03 -08:00
Kubernetes Prow Robot
a31be286ca
Merge pull request #73608 from juanvallejo/jvallejo/improve-discovery-restmapper-errors
...
return original error, unless error is *meta.NoKindMatchError
2019-01-31 19:32:39 -08:00
Kubernetes Prow Robot
6af7d2cb1a
Merge pull request #69552 from Pingan2017/remove-experimental-fail-swap-on-flag
...
remove kubelet flag '--experimental-fail-swap-on' (deprecated in v1.8)
2019-01-31 19:32:28 -08:00
Andrew Kim
fc9b63d6f0
remove GCE cloud provider dependency to pkg/master/ports by duplicating the proxy port value
2019-01-31 21:37:08 -05:00
Kubernetes Prow Robot
3fa6402a39
Merge pull request #73612 from andrewsykim/vsphere-remove-version-dep
...
remove dep to pkg/version in vSphere provider
2019-01-31 18:20:48 -08:00
Kubernetes Prow Robot
244795a06a
Merge pull request #73442 from pjh/gce-windows-cluster
...
Update cluster/gce/ scripts to support Windows nodes.
2019-01-31 18:20:37 -08:00
stewart-yu
0ca7bf5e86
remove pkg/controller dependencies from k8s.io/kubernetes/pkg/cloudprovider/providers
2019-02-01 08:48:23 +08:00
Kubernetes Prow Robot
91d2bd3951
Merge pull request #73306 from Pingan2017/args-type-statusmanager
...
correct the type in status_manager.go
2019-01-31 16:05:44 -08:00
Kubernetes Prow Robot
7b7f18c6c8
Merge pull request #70978 from Pingan2017/gracePeriod
...
correct log output when specifed delete gracePeriod < minimumGracePer…
2019-01-31 16:05:33 -08:00
Andrew Kim
ece2b0db19
remove dep to pkg/version in vSphere provider
2019-01-31 17:26:05 -05:00
juanvallejo
bc381fb5fb
return original error, unless error is *meta.NoKindMatchError
2019-01-31 17:24:37 -05:00
Kubernetes Prow Robot
a5ade16abd
Merge pull request #73603 from sjenning/fix-kubelet-test
...
TestCreatePodSandbox_RuntimeClass should not expect RunPodSandbox when runtime class is not found
2019-01-31 14:10:30 -08:00
Sandeep Rajan
aa11f6c298
Bump CoreDNS version to 1.3.1
2019-01-31 16:55:02 -05:00
Kubernetes Prow Robot
85f1205efa
Merge pull request #73464 from ipuustin/verify-generated-files-remake
...
verify-generated-files-remake.sh: fix issues reported by shellcheck.
2019-01-31 13:00:04 -08:00
Andrew Kim
8be7963797
move GCERegionalPersistentDisk feature to k8s.io/cloud-provider
2019-01-31 15:19:52 -05:00
Kubernetes Prow Robot
aa7220876a
Merge pull request #73550 from andrewsykim/cloud-provider-version
...
use k8s.io/client-go/pkg/version for cloud providers
2019-01-31 11:44:46 -08:00
Krzysztof Jastrzebski
0087af78e2
Deleting pods assigned to not existing nodes only if
...
ScheduleDaemonSetPods is enabled.
2019-01-31 20:34:51 +01:00
Seth Jennings
6b51d48c4f
TestCreatePodSandbox_RuntimeClass should not expect RunPodSandbox when runtime class is not found
2019-01-31 12:55:56 -06:00
Kubernetes Prow Robot
8f1082c6af
Merge pull request #73455 from danielqsj/keymutex
...
Migrate to k8s.io/utils/keymutex and k8s.io/utils/strings
2019-01-31 09:56:19 -08:00
Ted Yu
9e227af65c
Add ps1 to windows executable extensions
2019-01-31 09:21:01 -08:00
Kubernetes Prow Robot
9487d37666
Merge pull request #72873 from taragu/exponential-backoff-plugin-registration
...
Add exponential backoff for plugin registration
2019-01-31 08:07:12 -08:00
dmaiocchi
fd708d173e
refactor config functions
2019-01-31 16:48:18 +01:00
Jordan Liggitt
f100a762bc
Stop using apps/v1beta1 in tests
2019-01-31 10:12:38 -05:00
danielqsj
cf1fb8a1cd
fix format issue
2019-01-31 22:01:13 +08:00
Kubernetes Prow Robot
46fc4dd96a
Merge pull request #73577 from wojtek-t/remove_vmodule
...
Remove vmodule from apiserver to reduce lock contention
2019-01-31 04:59:42 -08:00
Daniel (Shijun) Qian
e72b32558c
Merge branch 'master' into keymutex
2019-01-31 20:50:57 +08:00
Kubernetes Prow Robot
927fd1f785
Merge pull request #73532 from andrewsykim/cp-node-helper
...
move cloud node helper functions to k8s.io/cloud-provider/node/helpers
2019-01-31 02:54:27 -08:00
wojtekt
3032d92736
Remove vmodule from apiserver to reduce lock contention
2019-01-31 10:53:44 +01:00
Kubernetes Prow Robot
29e9ff36a9
Merge pull request #73063 from WanLinghao/kubectl_get_custom_clomuns_fix
...
Improve custom-columns option of `kubectl get ` command
2019-01-31 01:39:49 -08:00
Kubernetes Prow Robot
94b5aeba9d
Merge pull request #73529 from wojtek-t/optimize_index
...
Optimize Index() method to avoid unnecessary copies
2019-01-31 00:20:19 -08:00
Kubernetes Prow Robot
f86218f90f
Merge pull request #57759 from LiliC/lili/add-api-readme
...
Update api README
2019-01-30 23:12:13 -08:00
Kubernetes Prow Robot
3b02f17b35
Merge pull request #73477 from liggitt/storage-media-type
...
Allow control over media-type
2019-01-30 22:03:24 -08:00
Kubernetes Prow Robot
9388a27212
Merge pull request #73309 from cofyc/fix73216-receivedMoveRequest
...
Should move all unscheduable pods when we received move request to active queue
2019-01-30 22:03:13 -08:00
Kubernetes Prow Robot
92076f0d2e
Merge pull request #73501 from dlipovetsky/fix-kubelet-exec-error
...
kubeadm: Make exec error message more informative
2019-01-30 20:26:03 -08:00
Kubernetes Prow Robot
38d12df696
Merge pull request #73450 from liggitt/update-cluster-proportional-autoscaler
...
Update cluster-proportional-autoscaler to 1.4.0 to use apps/v1
2019-01-30 20:25:52 -08:00
Peter Hornyack
f0f7829934
Update cluster/gce scripts to support Windows nodes.
2019-01-30 19:49:07 -08:00
Kubernetes Prow Robot
1f7e9fd9a2
Merge pull request #73488 from andrewsykim/replace-utils-file
...
Replace pkg/util/file with k8s.io/utils/path
2019-01-30 17:50:16 -08:00
Kubernetes Prow Robot
fb96afb194
Merge pull request #73482 from liggitt/cross-group-watch
...
Always select the in-memory group/version as a target when decoding from storage
2019-01-30 17:50:06 -08:00
WanLinghao
97ec74df03
The client-go library supports user get Object info in the form of .spec.containers[0:3].name.
...
But kubectl get command doesn't support this.
This patch fix this, now users could get object info like:
a. kubectl get pod test-pod -o custom-columns=CONTAINER:.spec.containers[0:3].name
b. kubectl get pod test-pod -o custom-columns=CONTAINER:.spec.containers[-2:].name
2019-01-31 09:38:04 +08:00
Kubernetes Prow Robot
0f93328c7a
Merge pull request #73457 from xichengliudui/updatedockerversion
...
Update docker support for k8s
2019-01-30 16:39:01 -08:00
Kubernetes Prow Robot
fcbe7f50f2
Merge pull request #71767 from roycaihw/crd-metrics-rename
...
Log prometheus metric registration error and fix CRD metric names
2019-01-30 16:38:51 -08:00
Andrew Kim
c01caa6796
use k8s.io/client-go/pkg/version for cloud providers
2019-01-30 18:11:11 -05:00
Kubernetes Prow Robot
a780dd78d3
Merge pull request #73469 from dany74q/patch-1
...
Added windows executable extensions to Kubectl plugins
2019-01-30 14:28:54 -08:00
Kubernetes Prow Robot
f2ade8e993
Merge pull request #73163 from MalloZup/phases-preflight
...
expose preflight join as phases
2019-01-30 14:28:43 -08:00