Commit Graph

11 Commits (06bc7e3e0026ea25065f59f4bd305c0b7dbbc145)

Author SHA1 Message Date
Christoph Blecker 5236850989
Fix malformed JUNIT XML with shellcheck failures 2019-04-20 18:22:28 -07:00
Kenichi Omichi 08dc056480 Replace `false` with `exit 1`
Some scripts contained `false` for returning 1 to callers instead of
`exit 1` and that works like:

  $ false
  $ echo $?
  1
  $

But that made confusion in a PR review process.
So this replaces `false` with `exit 1` for long-term maintenance.
2019-04-16 23:13:00 +00:00
Bob Killen db01d68d05
Update hack/verify-shellcheck.sh to ignore ./third_party/*
The ./third_party/* directory contains scripts, libraries and
other components from external sources. These should be omitted
from lints and checks with the exception of things that are
forked and modified (located in ./third_party/forked/*) for
project related reasons.
2019-04-13 16:58:20 -04:00
Benjamin Elder 2b7cc095cc enable external sources in verify-shellcheck 2019-04-01 11:03:37 -07:00
Xiang Dai 36065c6dd7 delete all duplicate empty blanks
Signed-off-by: Xiang Dai <764524258@qq.com>
2019-02-23 10:28:04 +08:00
Kenichi Omichi 4a91b593ba Use kube::util::array_contains() in hack
The common kube::util::array_contains() is already there, so this
makes both scripts use it.
2019-02-08 23:13:48 +00:00
Kenichi Omichi c32d1acbb9 Add check-file-in-alphabetical-order for cleanup
Both verify-golint.sh and verify-shellcheck.sh have the same logic
which checks failure_file in alphabetical order.
In addition, we'd like to add another script which requires the
same logic. So this add a common function for cleanup.
2019-01-26 02:09:06 +00:00
Benjamin Elder 86a7a08af9 use host shellcheck binary when possible 2019-01-14 15:44:15 -08:00
Benjamin Elder 94fa9313ac re-use shellcheck container 2019-01-11 01:42:27 -08:00
Benjamin Elder 5c48a04c53 use shellcheck image, respect gitignore 2019-01-10 23:58:22 -08:00
Benjamin Elder feef6e515c add shellcheck lint script 2019-01-10 23:27:13 -08:00