From 8fe8ec980ed3a3b691b2ec54fd54f8e436657aa6 Mon Sep 17 00:00:00 2001 From: Tim Hockin Date: Sat, 2 Jul 2016 14:56:23 -0700 Subject: [PATCH] Cleanup a TODO from godeps -> vendor change This logs a false "error" message, so it's time to go. It was needed to ensure nobody has stale build images laying around, but that was quite a while ago, so it's probably safe now. --- build/common.sh | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/build/common.sh b/build/common.sh index 465941e7e4..864c9cd129 100755 --- a/build/common.sh +++ b/build/common.sh @@ -559,16 +559,6 @@ function kube::build::clean_images() { } function kube::build::ensure_data_container() { - # This is temporary, while last remnants of _workspace are obliterated. If - # the data container exists it might be from before the change from - # Godeps/_workspace/ to vendor/, and thereby still have a Godeps/_workspace/ - # directory in it, which trips up godep (yay godep!). Once we are confident - # that this has run ~everywhere we care about, we can remove this. - # TODO(thockin): remove this after v1.3 is cut. - if "${DOCKER[@]}" inspect "${KUBE_BUILD_DATA_CONTAINER_NAME}" \ - | grep -q "Godeps/_workspace/pkg"; then - docker rm -f "${KUBE_BUILD_DATA_CONTAINER_NAME}" - fi if ! "${DOCKER[@]}" inspect "${KUBE_BUILD_DATA_CONTAINER_NAME}" >/dev/null 2>&1; then kube::log::status "Creating data container" local -ra docker_cmd=(