diff --git a/pkg/kubectl/cmd/BUILD b/pkg/kubectl/cmd/BUILD index 38221baeb8..1821c8ec23 100644 --- a/pkg/kubectl/cmd/BUILD +++ b/pkg/kubectl/cmd/BUILD @@ -190,7 +190,6 @@ go_test( deps = [ "//pkg/api/legacyscheme:go_default_library", "//pkg/api/testapi:go_default_library", - "//pkg/api/testing:go_default_library", "//pkg/apis/core:go_default_library", "//pkg/kubectl/cmd/create:go_default_library", "//pkg/kubectl/cmd/testing:go_default_library", diff --git a/pkg/kubectl/cmd/cmd_test.go b/pkg/kubectl/cmd/cmd_test.go index 1c8081a554..a5a6a852e8 100644 --- a/pkg/kubectl/cmd/cmd_test.go +++ b/pkg/kubectl/cmd/cmd_test.go @@ -33,11 +33,8 @@ import ( corev1 "k8s.io/api/core/v1" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" "k8s.io/apimachinery/pkg/runtime" - "k8s.io/apimachinery/pkg/runtime/schema" "k8s.io/cli-runtime/pkg/genericclioptions" restclient "k8s.io/client-go/rest" - "k8s.io/kubernetes/pkg/api/testapi" - apitesting "k8s.io/kubernetes/pkg/api/testing" cmdutil "k8s.io/kubernetes/pkg/kubectl/cmd/util" "k8s.io/kubernetes/pkg/kubectl/scheme" ) @@ -60,12 +57,14 @@ func defaultClientConfig() *restclient.Config { ContentConfig: restclient.ContentConfig{ NegotiatedSerializer: scheme.Codecs, ContentType: runtime.ContentTypeJSON, - GroupVersion: &schema.GroupVersion{Version: "v1"}, + GroupVersion: &corev1.SchemeGroupVersion, }, } } func testData() (*corev1.PodList, *corev1.ServiceList, *corev1.ReplicationControllerList) { + grace := int64(30) + enableServiceLinks := corev1.DefaultEnableServiceLinks pods := &corev1.PodList{ ListMeta: metav1.ListMeta{ ResourceVersion: "15", @@ -73,11 +72,23 @@ func testData() (*corev1.PodList, *corev1.ServiceList, *corev1.ReplicationContro Items: []corev1.Pod{ { ObjectMeta: metav1.ObjectMeta{Name: "foo", Namespace: "test", ResourceVersion: "10"}, - Spec: apitesting.V1DeepEqualSafePodSpec(), + Spec: corev1.PodSpec{ + RestartPolicy: corev1.RestartPolicyAlways, + DNSPolicy: corev1.DNSClusterFirst, + TerminationGracePeriodSeconds: &grace, + SecurityContext: &corev1.PodSecurityContext{}, + EnableServiceLinks: &enableServiceLinks, + }, }, { ObjectMeta: metav1.ObjectMeta{Name: "bar", Namespace: "test", ResourceVersion: "11"}, - Spec: apitesting.V1DeepEqualSafePodSpec(), + Spec: corev1.PodSpec{ + RestartPolicy: corev1.RestartPolicyAlways, + DNSPolicy: corev1.DNSClusterFirst, + TerminationGracePeriodSeconds: &grace, + SecurityContext: &corev1.PodSecurityContext{}, + EnableServiceLinks: &enableServiceLinks, + }, }, }, } @@ -120,10 +131,6 @@ func objBody(codec runtime.Codec, obj runtime.Object) io.ReadCloser { return ioutil.NopCloser(bytes.NewReader([]byte(runtime.EncodeOrDie(codec, obj)))) } -func policyObjBody(obj runtime.Object) io.ReadCloser { - return ioutil.NopCloser(bytes.NewReader([]byte(runtime.EncodeOrDie(testapi.Policy.Codec(), obj)))) -} - func bytesBody(bodyBytes []byte) io.ReadCloser { return ioutil.NopCloser(bytes.NewReader(bodyBytes)) } diff --git a/pkg/kubectl/cmd/drain_test.go b/pkg/kubectl/cmd/drain_test.go index 2fa2e546b5..e93b4d0ed1 100644 --- a/pkg/kubectl/cmd/drain_test.go +++ b/pkg/kubectl/cmd/drain_test.go @@ -46,7 +46,6 @@ import ( "k8s.io/apimachinery/pkg/util/wait" "k8s.io/cli-runtime/pkg/genericclioptions/printers" "k8s.io/client-go/rest/fake" - "k8s.io/kubernetes/pkg/api/testapi" cmdtesting "k8s.io/kubernetes/pkg/kubectl/cmd/testing" cmdutil "k8s.io/kubernetes/pkg/kubectl/cmd/util" "k8s.io/kubernetes/pkg/kubectl/scheme" @@ -243,7 +242,6 @@ func TestDrain(t *testing.T) { Namespace: "default", CreationTimestamp: metav1.Time{Time: time.Now()}, Labels: labels, - SelfLink: testapi.Default.SelfLink("replicationcontrollers", "rc"), }, Spec: corev1.ReplicationControllerSpec{ Selector: labels, @@ -256,7 +254,6 @@ func TestDrain(t *testing.T) { Namespace: "default", CreationTimestamp: metav1.Time{Time: time.Now()}, Labels: labels, - SelfLink: testapi.Default.SelfLink("pods", "bar"), OwnerReferences: []metav1.OwnerReference{ { APIVersion: "v1", @@ -278,7 +275,6 @@ func TestDrain(t *testing.T) { Name: "ds", Namespace: "default", CreationTimestamp: metav1.Time{Time: time.Now()}, - SelfLink: testapi.Default.SelfLink("daemonsets", "ds"), }, Spec: extensionsv1beta1.DaemonSetSpec{ Selector: &metav1.LabelSelector{MatchLabels: labels}, @@ -291,7 +287,6 @@ func TestDrain(t *testing.T) { Namespace: "default", CreationTimestamp: metav1.Time{Time: time.Now()}, Labels: labels, - SelfLink: testapi.Default.SelfLink("pods", "bar"), OwnerReferences: []metav1.OwnerReference{ { APIVersion: "extensions/v1beta1", @@ -313,7 +308,6 @@ func TestDrain(t *testing.T) { Namespace: "default", CreationTimestamp: metav1.Time{Time: time.Now()}, Labels: labels, - SelfLink: testapi.Default.SelfLink("pods", "bar"), OwnerReferences: []metav1.OwnerReference{ { APIVersion: "extensions/v1beta1", @@ -338,7 +332,6 @@ func TestDrain(t *testing.T) { Namespace: "default", CreationTimestamp: metav1.Time{Time: time.Now()}, Labels: labels, - SelfLink: testapi.Default.SelfLink("pods", "bar"), OwnerReferences: []metav1.OwnerReference{ { APIVersion: "extensions/v1beta1", @@ -366,7 +359,6 @@ func TestDrain(t *testing.T) { Namespace: "default", CreationTimestamp: metav1.Time{Time: time.Now()}, Labels: labels, - SelfLink: testapi.Default.SelfLink("pods", "bar"), }, Spec: corev1.PodSpec{ NodeName: "node", @@ -378,7 +370,6 @@ func TestDrain(t *testing.T) { Name: "job", Namespace: "default", CreationTimestamp: metav1.Time{Time: time.Now()}, - SelfLink: testapi.Default.SelfLink("jobs", "job"), }, Spec: batchv1.JobSpec{ Selector: &metav1.LabelSelector{MatchLabels: labels}, @@ -391,7 +382,6 @@ func TestDrain(t *testing.T) { Namespace: "default", CreationTimestamp: metav1.Time{Time: time.Now()}, Labels: labels, - SelfLink: testapi.Default.SelfLink("pods", "bar"), OwnerReferences: []metav1.OwnerReference{ { APIVersion: "v1", @@ -419,7 +409,6 @@ func TestDrain(t *testing.T) { Namespace: "default", CreationTimestamp: metav1.Time{Time: time.Now()}, Labels: labels, - SelfLink: testapi.Default.SelfLink("pods", "bar"), OwnerReferences: []metav1.OwnerReference{ { APIVersion: "v1", @@ -450,7 +439,6 @@ func TestDrain(t *testing.T) { Namespace: "default", CreationTimestamp: metav1.Time{Time: time.Now()}, Labels: labels, - SelfLink: testapi.Default.SelfLink("replicasets", "rs"), }, Spec: extensionsv1beta1.ReplicaSetSpec{ Selector: &metav1.LabelSelector{MatchLabels: labels}, @@ -463,7 +451,6 @@ func TestDrain(t *testing.T) { Namespace: "default", CreationTimestamp: metav1.Time{Time: time.Now()}, Labels: labels, - SelfLink: testapi.Default.SelfLink("pods", "bar"), OwnerReferences: []metav1.OwnerReference{ { APIVersion: "v1", @@ -763,13 +750,13 @@ func TestDrain(t *testing.T) { case m.isFor("GET", "/namespaces/default/replicationcontrollers/rc"): return &http.Response{StatusCode: 200, Header: defaultHeader(), Body: objBody(codec, &test.rcs[0])}, nil case m.isFor("GET", "/namespaces/default/daemonsets/ds"): - return &http.Response{StatusCode: 200, Header: defaultHeader(), Body: objBody(testapi.Extensions.Codec(), &ds)}, nil + return &http.Response{StatusCode: 200, Header: defaultHeader(), Body: objBody(codec, &ds)}, nil case m.isFor("GET", "/namespaces/default/daemonsets/missing-ds"): - return &http.Response{StatusCode: 404, Header: defaultHeader(), Body: objBody(testapi.Extensions.Codec(), &extensionsv1beta1.DaemonSet{})}, nil + return &http.Response{StatusCode: 404, Header: defaultHeader(), Body: objBody(codec, &extensionsv1beta1.DaemonSet{})}, nil case m.isFor("GET", "/namespaces/default/jobs/job"): - return &http.Response{StatusCode: 200, Header: defaultHeader(), Body: objBody(testapi.Batch.Codec(), &job)}, nil + return &http.Response{StatusCode: 200, Header: defaultHeader(), Body: objBody(codec, &job)}, nil case m.isFor("GET", "/namespaces/default/replicasets/rs"): - return &http.Response{StatusCode: 200, Header: defaultHeader(), Body: objBody(testapi.Extensions.Codec(), &test.replicaSets[0])}, nil + return &http.Response{StatusCode: 200, Header: defaultHeader(), Body: objBody(codec, &test.replicaSets[0])}, nil case m.isFor("GET", "/namespaces/default/pods/bar"): return &http.Response{StatusCode: 404, Header: defaultHeader(), Body: objBody(codec, &corev1.Pod{})}, nil case m.isFor("GET", "/pods"): @@ -811,7 +798,7 @@ func TestDrain(t *testing.T) { return &http.Response{StatusCode: 204, Header: defaultHeader(), Body: objBody(codec, &test.pods[0])}, nil case m.isFor("POST", "/namespaces/default/pods/bar/eviction"): evicted = true - return &http.Response{StatusCode: 201, Header: defaultHeader(), Body: policyObjBody(&policyv1beta1.Eviction{})}, nil + return &http.Response{StatusCode: 201, Header: defaultHeader(), Body: objBody(codec, &policyv1beta1.Eviction{})}, nil default: t.Fatalf("%s: unexpected request: %v %#v\n%#v", test.description, req.Method, req.URL, req) return nil, nil