From fb4a4663212e916796c0304fa18b025992da301f Mon Sep 17 00:00:00 2001 From: Michael Fraenkel Date: Wed, 7 Sep 2016 13:25:35 -0400 Subject: [PATCH] Save stderr since it may become nil --- pkg/kubectl/cmd/run.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pkg/kubectl/cmd/run.go b/pkg/kubectl/cmd/run.go index a07eba9440..bf2f99bbd7 100644 --- a/pkg/kubectl/cmd/run.go +++ b/pkg/kubectl/cmd/run.go @@ -478,8 +478,10 @@ func handleAttachPod(f *cmdutil.Factory, c *client.Client, ns, name string, opts opts.Client = c opts.PodName = name opts.Namespace = ns + // TODO: opts.Run sets opts.Err to nil, we need to find a better way + stderr := opts.Err if err := opts.Run(); err != nil { - fmt.Fprintf(opts.Err, "Error attaching, falling back to logs: %v\n", err) + fmt.Fprintf(stderr, "Error attaching, falling back to logs: %v\n", err) req, err := f.LogsForObject(pod, &api.PodLogOptions{Container: ctrName}) if err != nil { return err