From fa6d17f400a94068b56b7d0f211f3cc9db290db6 Mon Sep 17 00:00:00 2001 From: "Bobby (Babak) Salamat" Date: Tue, 15 Jan 2019 17:03:59 -0800 Subject: [PATCH] Cleanup todo --- pkg/scheduler/core/generic_scheduler.go | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/pkg/scheduler/core/generic_scheduler.go b/pkg/scheduler/core/generic_scheduler.go index 035ef2b99e..f2086c7fac 100644 --- a/pkg/scheduler/core/generic_scheduler.go +++ b/pkg/scheduler/core/generic_scheduler.go @@ -1036,10 +1036,11 @@ func selectVictimsOnNode( } potentialVictims.Sort() // If the new pod does not fit after removing all the lower priority pods, - // we are almost done and this node is not suitable for preemption. The only condition - // that we should check is if the "pod" is failing to schedule due to pod affinity - // failure. - // TODO(bsalamat): Consider checking affinity to lower priority pods if feasible with reasonable performance. + // we are almost done and this node is not suitable for preemption. The only + // condition that we could check is if the "pod" is failing to schedule due to + // inter-pod affinity to one or more victims, but we have decided not to + // support this case for performance reasons. Having affinity to lower + // priority pods is not a recommended configuration anyway. if fits, _, err := podFitsOnNode(pod, meta, nodeInfoCopy, fitPredicates, queue, false); !fits { if err != nil { klog.Warningf("Encountered error while selecting victims on node %v: %v", nodeInfo.Node().Name, err)