From f8863791f71a0705bb751fefb736e5cf133989cb Mon Sep 17 00:00:00 2001 From: mbohlool Date: Thu, 3 Nov 2016 17:10:07 -0700 Subject: [PATCH] Add verify script federation OpenAPI spec generation --- hack/verify-federation-openapi-spec.sh | 47 ++++++++++++++++++++++++++ hooks/pre-commit | 12 +++++++ 2 files changed, 59 insertions(+) create mode 100755 hack/verify-federation-openapi-spec.sh diff --git a/hack/verify-federation-openapi-spec.sh b/hack/verify-federation-openapi-spec.sh new file mode 100755 index 0000000000..df407a0842 --- /dev/null +++ b/hack/verify-federation-openapi-spec.sh @@ -0,0 +1,47 @@ +#!/bin/bash + +# Copyright 2016 The Kubernetes Authors. +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +set -o errexit +set -o nounset +set -o pipefail + +KUBE_ROOT=$(dirname "${BASH_SOURCE}")/.. +source "${KUBE_ROOT}/hack/lib/init.sh" + +kube::golang::setup_env + +SPECROOT="${KUBE_ROOT}/federation/apis/openapi-spec" +TMP_SPECROOT="${KUBE_ROOT}/_tmp_federation/openapi-spec" +_tmp="${KUBE_ROOT}/_tmp_federation" + +mkdir -p "${_tmp}" +cp -a "${SPECROOT}" "${TMP_SPECROOT}" +trap "cp -a ${TMP_SPECROOT} ${SPECROOT}/..; rm -rf ${_tmp}" EXIT SIGINT +rm ${SPECROOT}/* + +"${KUBE_ROOT}/hack/update-federation-openapi-spec.sh" +echo "diffing ${SPECROOT} against freshly generated federation openapi spec" +ret=0 +diff -Naupr -I 'Auto generated by' "${SPECROOT}" "${TMP_SPECROOT}" || ret=$? +if [[ $ret -eq 0 ]] +then + echo "${SPECROOT} up to date." +else + echo "${SPECROOT} is out of date. Please run hack/update-federation-openapi-spec.sh" + exit 1 +fi + +# ex: ts=2 sw=2 et filetype=sh diff --git a/hooks/pre-commit b/hooks/pre-commit index 0f0138b72c..832f11f3d8 100755 --- a/hooks/pre-commit +++ b/hooks/pre-commit @@ -170,6 +170,18 @@ else fi echo "${reset}" +echo -ne "Checking for federation openapi spec that need updating... " +if ! hack/verify-federation-openapi-spec.sh > /dev/null; then + echo "${red}ERROR!" + echo "Federation OpenAPI spec needs to be updated." + echo "To regenerate the spec, run:" + echo " hack/update-federation-openapi-spec.sh" + exit_code=1 +else + echo "${green}OK" +fi +echo "${reset}" + if [[ "${exit_code}" != 0 ]]; then echo "${red}Aborting commit${reset}" fi