mirror of https://github.com/k3s-io/k3s
Merge pull request #66956 from mgdevstack/master-gc-orphandependent
Automatic merge from submit-queue (batch tested with PRs 58058, 67033, 66921, 66956). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Added comment to track deleteOptions.OrphanDependents e2e for conformance promotion in future **What this PR does / why we need it**: - Added a comment to track below mentioned e2e tests for conformance promotion in future. - Prevents additional effort to evaluate again for promotion. **E2E -** - Garbage collector should orphan pods created by rc if deleteOptions.OrphanDependents is nil **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #65427 **Special notes for your reviewer**: https://github.com/kubernetes/kubernetes/issues/65427#issuecomment-409642330 **Release note**: ```release-note NONE ``` /area conformance @kubernetes/sig-architecture-pr-reviewspull/8/head
commit
f04a7fa941
|
@ -461,6 +461,8 @@ var _ = SIGDescribe("Garbage collector", func() {
|
|||
gatherMetrics(f)
|
||||
})
|
||||
|
||||
// deleteOptions.OrphanDependents is deprecated in 1.7 and preferred to use the PropagationPolicy.
|
||||
// Discussion is tracked under https://github.com/kubernetes/kubernetes/issues/65427 to promote for conformance in future.
|
||||
It("should orphan pods created by rc if deleteOptions.OrphanDependents is nil", func() {
|
||||
clientSet := f.ClientSet
|
||||
rcClient := clientSet.CoreV1().ReplicationControllers(f.Namespace.Name)
|
||||
|
|
Loading…
Reference in New Issue