github
/
k3s
mirror of https://github.com/k3s-io/k3s
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #53364 from tcharding/kubectl-app 

Automatic merge from submit-queue (batch tested with PRs 53204, 53364, 53559, 53589, 53088). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

cmd: kubectl: remove golint_failures entry

**What this PR does / why we need it**:
       
`.golint_failures` currently has an entry for `cmd/kubectl/app`. We can lint this package and remove the entry. There is only one `golint` warning; comment on exported function Run should be of the form "Run..."
    
Fix documentation comment and remove `cmd/kubectl/app` from `.golint_failures`.

**Release note**:

```release-note
NONE
```
/sig cli
/kind cleanup
pull/6/head
Kubernetes Submit Queue 2017-10-11 15:14:40 -07:00 committed by GitHub
parent 9485ad2a45 fa2de842d0
commit efa17f5c45
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cmd/kubectl/app/kubectl.go
View File

@ -31,6 +31,8 @@ import (
WARNING: this logic is duplicated, with minor changes, in cmd/hyperkube/kubectl.go WARNING: this logic is duplicated, with minor changes, in cmd/hyperkube/kubectl.go
Any salient changes here will need to be manually reflected in that file. Any salient changes here will need to be manually reflected in that file.
*/ */
// Run runs the kubectl program (creates and executes a new cobra command).
func Run() error { func Run() error {
logs.InitLogs() logs.InitLogs()
defer logs.FlushLogs() defer logs.FlushLogs()

1
hack/.golint_failures
View File

@ -7,7 +7,6 @@ cmd/kube-proxy/app
cmd/kubeadm/app cmd/kubeadm/app
cmd/kubeadm/app/apis/kubeadm cmd/kubeadm/app/apis/kubeadm
cmd/kubeadm/app/apis/kubeadm/v1alpha1 cmd/kubeadm/app/apis/kubeadm/v1alpha1
cmd/kubectl/app
cmd/kubelet/app cmd/kubelet/app
cmd/kubelet/app/options cmd/kubelet/app/options
cmd/kubemark cmd/kubemark