github
/
k3s
mirror of https://github.com/k3s-io/k3s
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #49860 from zhangxiaoyu-zidif/fix-error-print-for-cronjob-utils-test 

Automatic merge from submit-queue (batch tested with PRs 47416, 47408, 49697, 49860, 50162)

fix error message for cronjob

**What this PR does / why we need it**:
fix error message for cronjob
expected an error would be better than unexpected lack of error.
ref: https://github.com/kubernetes/kubernetes/blob/master/cmd/genutils/genutils_test.go#L33

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```
pull/6/head
Kubernetes Submit Queue 2017-08-05 03:22:59 -07:00 committed by GitHub
parent c3f4dba513 9ada6b37c5
commit ec424949c9
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/controller/cronjob/utils_test.go
View File

@ -371,7 +371,7 @@ func TestGetRecentUnmetScheduleTimes(t *testing.T) {
now := T2.Add(10 * 24 * time.Hour) now := T2.Add(10 * 24 * time.Hour)
_, err := getRecentUnmetScheduleTimes(sj, now) _, err := getRecentUnmetScheduleTimes(sj, now)
if err == nil { if err == nil {
t.Errorf("unexpected lack of error") t.Errorf("expected an error")
} }
} }
{ {