mirror of https://github.com/k3s-io/k3s
Merge pull request #59334 from cblecker/top-dir-owners
Automatic merge from submit-queue (batch tested with PRs 55986, 59375, 59334, 59348, 58027). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Create OWNERS files for remaining subdirs of kubernetes/ **What this PR does / why we need it**: This adds OWNERS files for the remaining subdirs of kubernetes/ **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #44420 **Special notes for your reviewer**: - translations: the kubectl specific translations are being handled by sig-cli, but the rest of the files like README and test have been handled and approved mostly by @brendandburns. - third_party: this is a tricky mix of stuff like forked code.. mostly handled by the likes of @thockin, @lavalamp, or @smarterclayton for approvals. - Godep/vendor: Right now @thockin mostly approves these as there are some tricky pieces around ensuring the licenses are compliant. For these, I've created a vendor-(reviewers|approvers) aliases, and associated those with both the Godeps and vendor folders. Right now @thockin is the only person in them, but that can easily expand in the future if there is a documented process on what to look for when approving dependency bumps. **Release note**: ```release-note NONE ``` /assign thockin /cc fejtapull/6/head
commit
e81b0021b6
|
@ -0,0 +1,4 @@
|
|||
reviewers:
|
||||
- vendor-reviewers
|
||||
approvers:
|
||||
- vendor-approvers
|
|
@ -223,3 +223,7 @@ aliases:
|
|||
- piosz
|
||||
- jsafrane
|
||||
- jbeda
|
||||
vendor-reviewers:
|
||||
- thockin
|
||||
vendor-approvers:
|
||||
- thockin
|
||||
|
|
|
@ -101,7 +101,7 @@ pushd "${KUBE_ROOT}" 2>&1 > /dev/null
|
|||
ret=1
|
||||
fi
|
||||
|
||||
if ! _out="$(diff -Naupr -x "BUILD" -x "AUTHORS*" -x "CONTRIBUTORS*" vendor ${_kubetmp}/vendor)"; then
|
||||
if ! _out="$(diff -Naupr -x "BUILD" -x "OWNERS" -x "AUTHORS*" -x "CONTRIBUTORS*" vendor ${_kubetmp}/vendor)"; then
|
||||
echo "Your vendored results are different:"
|
||||
echo "${_out}"
|
||||
echo "Godeps Verify failed."
|
||||
|
|
|
@ -1,5 +1,6 @@
|
|||
// Code generated by go-bindata.
|
||||
// sources:
|
||||
// translations/OWNERS
|
||||
// translations/extract.py
|
||||
// translations/kubectl/OWNERS
|
||||
// translations/kubectl/de_DE/LC_MESSAGES/k8s.mo
|
||||
|
@ -67,6 +68,27 @@ func (fi bindataFileInfo) Sys() interface{} {
|
|||
return nil
|
||||
}
|
||||
|
||||
var _translationsOwners = []byte(`reviewers:
|
||||
- brendandburns
|
||||
approvers:
|
||||
- brendandburns
|
||||
`)
|
||||
|
||||
func translationsOwnersBytes() ([]byte, error) {
|
||||
return _translationsOwners, nil
|
||||
}
|
||||
|
||||
func translationsOwners() (*asset, error) {
|
||||
bytes, err := translationsOwnersBytes()
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
|
||||
info := bindataFileInfo{name: "translations/OWNERS", size: 0, mode: os.FileMode(0), modTime: time.Unix(0, 0)}
|
||||
a := &asset{bytes: bytes, info: info}
|
||||
return a, nil
|
||||
}
|
||||
|
||||
var _translationsExtractPy = []byte(`#!/usr/bin/env python
|
||||
|
||||
# Copyright 2017 The Kubernetes Authors.
|
||||
|
@ -19278,6 +19300,7 @@ func AssetNames() []string {
|
|||
|
||||
// _bindata is a table, holding each asset generator, mapped to its name.
|
||||
var _bindata = map[string]func() (*asset, error){
|
||||
"translations/OWNERS": translationsOwners,
|
||||
"translations/extract.py": translationsExtractPy,
|
||||
"translations/kubectl/OWNERS": translationsKubectlOwners,
|
||||
"translations/kubectl/de_DE/LC_MESSAGES/k8s.mo": translationsKubectlDe_deLc_messagesK8sMo,
|
||||
|
@ -19345,6 +19368,7 @@ type bintree struct {
|
|||
|
||||
var _bintree = &bintree{nil, map[string]*bintree{
|
||||
"translations": {nil, map[string]*bintree{
|
||||
"OWNERS": {translationsOwners, map[string]*bintree{}},
|
||||
"extract.py": {translationsExtractPy, map[string]*bintree{}},
|
||||
"kubectl": {nil, map[string]*bintree{
|
||||
"OWNERS": {translationsKubectlOwners, map[string]*bintree{}},
|
||||
|
|
|
@ -0,0 +1,8 @@
|
|||
reviewers:
|
||||
- lavalamp
|
||||
- smarterclayton
|
||||
- thockin
|
||||
approvers:
|
||||
- lavalamp
|
||||
- smarterclayton
|
||||
- thockin
|
|
@ -0,0 +1,4 @@
|
|||
reviewers:
|
||||
- brendandburns
|
||||
approvers:
|
||||
- brendandburns
|
|
@ -0,0 +1,4 @@
|
|||
reviewers:
|
||||
- vendor-reviewers
|
||||
approvers:
|
||||
- vendor-approvers
|
Loading…
Reference in New Issue