From e4fc6743bf42678b0571be48cb92c7be3a50ab04 Mon Sep 17 00:00:00 2001
From: Manuel Buil <mbuil@suse.com>
Date: Tue, 27 Feb 2024 11:15:42 +0100
Subject: [PATCH] Add an integration test for flannel-backend=none

Signed-off-by: Manuel Buil <mbuil@suse.com>
---
 .github/workflows/integration.yaml            |  2 +-
 .../flannelnone/flannelnone_int_test.go       | 86 +++++++++++++++++++
 2 files changed, 87 insertions(+), 1 deletion(-)
 create mode 100644 tests/integration/flannelnone/flannelnone_int_test.go

diff --git a/.github/workflows/integration.yaml b/.github/workflows/integration.yaml
index 35e9390abd..0f0f68fb5a 100644
--- a/.github/workflows/integration.yaml
+++ b/.github/workflows/integration.yaml
@@ -39,7 +39,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        itest: [certrotation, etcdrestore, localstorage, startup, custometcdargs, etcdsnapshot, kubeflags, longhorn, secretsencryption]
+        itest: [certrotation, etcdrestore, localstorage, startup, custometcdargs, etcdsnapshot, kubeflags, longhorn, secretsencryption, flannelnone]
       max-parallel: 3
     steps:
     - name: Checkout
diff --git a/tests/integration/flannelnone/flannelnone_int_test.go b/tests/integration/flannelnone/flannelnone_int_test.go
new file mode 100644
index 0000000000..13156cce6a
--- /dev/null
+++ b/tests/integration/flannelnone/flannelnone_int_test.go
@@ -0,0 +1,86 @@
+/*
+This test verifies that even if we use flannel-backend=none, kube-api starts correctly so that it can 
+accept the custom CNI plugin manifest. We want to catch regressions in which kube-api is unresponsive.
+To do so we check for 25s that we can consistently query kube-api. We check that pods are in pending
+state, which is what should happen if there is no cni plugin
+*/
+package integration
+
+import (
+	"os"
+	"strings"
+	"testing"
+
+	testutil "github.com/k3s-io/k3s/tests/integration"
+	. "github.com/onsi/ginkgo/v2"
+	. "github.com/onsi/gomega"
+
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+)
+
+var server *testutil.K3sServer
+var flannelNoneServerArgs = []string{
+	"--flannel-backend=none",
+}
+var testLock int
+
+var _ = BeforeSuite(func() {
+	if !testutil.IsExistingServer() {
+		var err error
+		testLock, err = testutil.K3sTestLock()
+		Expect(err).ToNot(HaveOccurred())
+		server, err = testutil.K3sStartServer(flannelNoneServerArgs...)
+		Expect(err).ToNot(HaveOccurred())
+	}
+})
+
+var _ = Describe("flannel-backend=none", Ordered, func() {
+	BeforeEach(func() {
+		if testutil.IsExistingServer() && !testutil.ServerArgsPresent(flannelNoneServerArgs) {
+			Skip("Test needs k3s server with: " + strings.Join(flannelNoneServerArgs, " "))
+		}
+	})
+	When("Pods can be queried and their status is Pending", func() {
+		It("checks pods status", func() {
+			// Wait for pods to come up before running the real test
+			Eventually(func() int {
+				pods, _ := testutil.ParsePods("kube-system", metav1.ListOptions{})
+				return len(pods)
+			}, "180s", "5s").Should(BeNumerically(">", 0))
+
+
+			pods, err := testutil.ParsePods("kube-system", metav1.ListOptions{})
+			Expect(err).NotTo(HaveOccurred())
+
+			// Pods should remain in Pending state because there is no network plugin
+			Consistently(func () bool {
+				for _, pod := range pods {
+					if !strings.Contains(string(pod.Status.Phase), "Pending") {
+						return false
+					}
+				}
+				return true
+				}, "25s").Should(BeTrue())
+			})
+		})
+})
+
+var failed bool
+var _ = AfterEach(func() {
+	failed = failed || CurrentSpecReport().Failed()
+})
+
+var _ = AfterSuite(func() {
+	if !testutil.IsExistingServer() && os.Getenv("CI") != "true" {
+		if failed {
+			testutil.K3sSaveLog(server, false)
+		}
+		Expect(testutil.K3sKillServer(server)).To(Succeed())
+		Expect(testutil.K3sCleanup(testLock, "")).To(Succeed())
+	}
+})
+
+func Test_Integrationflannelnone(t *testing.T) {
+	RegisterFailHandler(Fail)
+	RunSpecs(t, "flannel-backend=none Suite")
+}