github
/
k3s
mirror of https://github.com/k3s-io/k3s
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #70820 from seans3/kubectl-convert-deprecate 

kubectl convert: add deprecation warning for 1.13
pull/58/head
k8s-ci-robot 2018-11-09 16:22:36 -08:00 committed by GitHub
parent f49464e848 62ec499d6f
commit e3ddd8577a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
pkg/kubectl/cmd/convert/convert.go
View File

@ -134,6 +134,14 @@ func (o *ConvertOptions) Complete(f cmdutil.Factory, cmd *cobra.Command) (err er
// RunConvert implements the generic Convert command
func (o *ConvertOptions) RunConvert() error {
// Convert must be removed from kubectl, since kubectl can not depend on
// Kubernetes "internal" dependencies. These "internal" dependencies can
// not be removed from convert. Another way to convert a resource is to
// "kubectl apply" it to the cluster, then "kubectl get" at the desired version.
// Another possible solution is to make convert a plugin.
fmt.Fprintf(o.ErrOut, "kubectl convert is DEPRECATED and will be removed in a future version.\nIn order to convert, kubectl apply the object to the cluster, then kubectl get at the desired version.\n")
b := o.builder().
WithScheme(scheme.Scheme).
LocalParam(o.local)