diff --git a/cmd/kube-controller-manager/app/controllermanager.go b/cmd/kube-controller-manager/app/controllermanager.go index 2ef60426c1..980c25cd0a 100644 --- a/cmd/kube-controller-manager/app/controllermanager.go +++ b/cmd/kube-controller-manager/app/controllermanager.go @@ -39,7 +39,6 @@ import ( "k8s.io/apimachinery/pkg/util/wait" "k8s.io/apiserver/pkg/server" "k8s.io/apiserver/pkg/server/mux" - utilfeature "k8s.io/apiserver/pkg/util/feature" apiserverflag "k8s.io/apiserver/pkg/util/flag" cacheddiscovery "k8s.io/client-go/discovery/cached" "k8s.io/client-go/informers" @@ -55,7 +54,6 @@ import ( "k8s.io/kubernetes/pkg/controller" kubectrlmgrconfig "k8s.io/kubernetes/pkg/controller/apis/config" serviceaccountcontroller "k8s.io/kubernetes/pkg/controller/serviceaccount" - "k8s.io/kubernetes/pkg/features" "k8s.io/kubernetes/pkg/serviceaccount" "k8s.io/kubernetes/pkg/util/configz" utilflag "k8s.io/kubernetes/pkg/util/flag" @@ -337,7 +335,6 @@ func KnownControllers() []string { var ControllersDisabledByDefault = sets.NewString( "bootstrapsigner", "tokencleaner", - "root_ca_crt_publisher", ) const ( @@ -384,9 +381,7 @@ func NewControllerInitializers(loopMode ControllerLoopMode) map[string]InitFunc controllers["pvc-protection"] = startPVCProtectionController controllers["pv-protection"] = startPVProtectionController controllers["ttl-after-finished"] = startTTLAfterFinishedController - if utilfeature.DefaultFeatureGate.Enabled(features.TokenRequest) { - controllers["root_ca_crt_publisher"] = startRootCACertPublisher - } + controllers["root-ca-cert-publisher"] = startRootCACertPublisher return controllers } diff --git a/pkg/controller/certificates/rootcacertpublisher/BUILD b/pkg/controller/certificates/rootcacertpublisher/BUILD index 603de73b74..35f0ed8a93 100644 --- a/pkg/controller/certificates/rootcacertpublisher/BUILD +++ b/pkg/controller/certificates/rootcacertpublisher/BUILD @@ -2,7 +2,7 @@ load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") go_library( name = "go_default_library", - srcs = ["root_ca_cert_publisher.go"], + srcs = ["publisher.go"], importpath = "k8s.io/kubernetes/pkg/controller/certificates/rootcacertpublisher", visibility = ["//visibility:public"], deps = [ @@ -22,20 +22,6 @@ go_library( ], ) -go_test( - name = "go_default_test", - srcs = ["root_ca_cert_publisher_test.go"], - embed = [":go_default_library"], - deps = [ - "//pkg/controller:go_default_library", - "//staging/src/k8s.io/api/core/v1:go_default_library", - "//staging/src/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library", - "//staging/src/k8s.io/client-go/informers:go_default_library", - "//staging/src/k8s.io/client-go/kubernetes/fake:go_default_library", - "//staging/src/k8s.io/client-go/testing:go_default_library", - ], -) - filegroup( name = "package-srcs", srcs = glob(["**"]), @@ -49,3 +35,17 @@ filegroup( tags = ["automanaged"], visibility = ["//visibility:public"], ) + +go_test( + name = "go_default_test", + srcs = ["publisher_test.go"], + embed = [":go_default_library"], + deps = [ + "//pkg/controller:go_default_library", + "//staging/src/k8s.io/api/core/v1:go_default_library", + "//staging/src/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library", + "//staging/src/k8s.io/client-go/informers:go_default_library", + "//staging/src/k8s.io/client-go/kubernetes/fake:go_default_library", + "//staging/src/k8s.io/client-go/testing:go_default_library", + ], +) diff --git a/pkg/controller/certificates/rootcacertpublisher/root_ca_cert_publisher.go b/pkg/controller/certificates/rootcacertpublisher/publisher.go similarity index 97% rename from pkg/controller/certificates/rootcacertpublisher/root_ca_cert_publisher.go rename to pkg/controller/certificates/rootcacertpublisher/publisher.go index 274518afe8..79a50357c2 100644 --- a/pkg/controller/certificates/rootcacertpublisher/root_ca_cert_publisher.go +++ b/pkg/controller/certificates/rootcacertpublisher/publisher.go @@ -52,10 +52,10 @@ func NewPublisher(cmInformer coreinformers.ConfigMapInformer, nsInformer coreinf "ca.crt": string(rootCA), }, }, - queue: workqueue.NewNamedRateLimitingQueue(workqueue.DefaultControllerRateLimiter(), "root-ca-crt-publisher"), + queue: workqueue.NewNamedRateLimitingQueue(workqueue.DefaultControllerRateLimiter(), "root-ca-cert-publisher"), } if cl.CoreV1().RESTClient().GetRateLimiter() != nil { - if err := metrics.RegisterMetricAndTrackRateLimiterUsage("root_ca_crt_publisher", cl.CoreV1().RESTClient().GetRateLimiter()); err != nil { + if err := metrics.RegisterMetricAndTrackRateLimiterUsage("root_ca_cert_publisher", cl.CoreV1().RESTClient().GetRateLimiter()); err != nil { return nil, err } } diff --git a/pkg/controller/certificates/rootcacertpublisher/root_ca_cert_publisher_test.go b/pkg/controller/certificates/rootcacertpublisher/publisher_test.go similarity index 100% rename from pkg/controller/certificates/rootcacertpublisher/root_ca_cert_publisher_test.go rename to pkg/controller/certificates/rootcacertpublisher/publisher_test.go