github
/
k3s
mirror of https://github.com/k3s-io/k3s
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #24909 from pmorie/security-context-loc 

Reduce LOC in security context tests
pull/6/head
Alex Robinson 2016-05-27 10:27:55 -07:00
parent 294e49f8b9 6f940a1a78
commit d2a45f0ba5
1 changed files with 15 additions and 43 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

58
pkg/securitycontext/util_test.go
View File

@ -84,6 +84,10 @@ func compareContexts(name string, ex, ac *api.SELinuxOptions, t *testing.T) {
}
}
func containerWithUser(ptr *int64) *api.Container {
return &api.Container{SecurityContext: &api.SecurityContext{RunAsUser: ptr}}
}
func TestHaRootUID(t *testing.T) {
var nonRoot int64 = 1
var root int64 = 0
@ -96,26 +100,14 @@ func TestHaRootUID(t *testing.T) {
container: &api.Container{SecurityContext: nil},
},
"nil runAsuser": {
container: &api.Container{
SecurityContext: &api.SecurityContext{
RunAsUser: nil,
},
},
container: containerWithUser(nil),
},
"runAsUser non-root": {
container: &api.Container{
SecurityContext: &api.SecurityContext{
RunAsUser: &nonRoot,
},
},
container: containerWithUser(&nonRoot),
},
"runAsUser root": {
container: &api.Container{
SecurityContext: &api.SecurityContext{
RunAsUser: &root,
},
},
expect: true,
container: containerWithUser(&root),
expect: true,
},
}
@ -138,19 +130,11 @@ func TestHasRunAsUser(t *testing.T) {
container: &api.Container{SecurityContext: nil},
},
"nil runAsUser": {
container: &api.Container{
SecurityContext: &api.SecurityContext{
RunAsUser: nil,
},
},
container: containerWithUser(nil),
},
"valid runAsUser": {
container: &api.Container{
SecurityContext: &api.SecurityContext{
RunAsUser: &runAsUser,
},
},
expect: true,
container: containerWithUser(&runAsUser),
expect: true,
},
}
@ -174,26 +158,14 @@ func TestHasRootRunAsUser(t *testing.T) {
container: &api.Container{SecurityContext: nil},
},
"nil runAsuser": {
container: &api.Container{
SecurityContext: &api.SecurityContext{
RunAsUser: nil,
},
},
container: containerWithUser(nil),
},
"runAsUser non-root": {
container: &api.Container{
SecurityContext: &api.SecurityContext{
RunAsUser: &nonRoot,
},
},
container: containerWithUser(&nonRoot),
},
"runAsUser root": {
container: &api.Container{
SecurityContext: &api.SecurityContext{
RunAsUser: &root,
},
},
expect: true,
container: containerWithUser(&root),
expect: true,
},
}