From d1480cd8dfe9edc5109d6825b9df67ef96af9079 Mon Sep 17 00:00:00 2001 From: AdoHe Date: Sat, 7 May 2016 10:06:13 -0400 Subject: [PATCH] fix rollout nil panice issue --- pkg/kubectl/history.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/pkg/kubectl/history.go b/pkg/kubectl/history.go index 09b8e6b972..529da21faf 100644 --- a/pkg/kubectl/history.go +++ b/pkg/kubectl/history.go @@ -76,7 +76,10 @@ func (h *DeploymentHistoryViewer) History(namespace, name string) (HistoryInfo, if err != nil { return historyInfo, fmt.Errorf("failed to retrieve new replica set from deployment %s: %v", name, err) } - allRSs := append(allOldRSs, newRS) + allRSs := allOldRSs + if newRS != nil { + allRSs = append(allRSs, newRS) + } for _, rs := range allRSs { v, err := deploymentutil.Revision(rs) if err != nil {