From d0b259597a757b7d30b30f063ba032cef291ceac Mon Sep 17 00:00:00 2001 From: Aaron Crickenberger Date: Fri, 10 Aug 2018 12:51:04 -0700 Subject: [PATCH] Use OWNERS-based labeling for kind/api-change This replaces the following path-label munger config, except we're using kind/api-change for everything instead of two different kind/ labels ``` ^pkg/api/([^/]+/)?types.go$ kind/api-change ^pkg/api/([^/]+/)?register.go$ kind/new-api ^pkg/apis/[^/]+/([^/]+/)?types.go$ kind/api-change ^pkg/apis/[^/]+/([^/]+/)?register.go$ kind/new-api ``` --- pkg/api/OWNERS | 19 ++++++++-- pkg/apis/OWNERS | 99 +++++++++++++++++++++++++++---------------------- 2 files changed, 70 insertions(+), 48 deletions(-) diff --git a/pkg/api/OWNERS b/pkg/api/OWNERS index 8f7783f9f0..a75c3ce229 100644 --- a/pkg/api/OWNERS +++ b/pkg/api/OWNERS @@ -1,4 +1,15 @@ -approvers: -- api-approvers -reviewers: -- api-reviewers +# See the OWNERS docs at https://go.k8s.io/owners + +filters: + ".*": + approvers: + - api-approvers + reviewers: + - api-reviewers + + # examples: + # pkg/api/types.go + # pkg/api/*/register.go + "([^/]+/)?(register|types)\\.go$": + labels: + - kind/api-change diff --git a/pkg/apis/OWNERS b/pkg/apis/OWNERS index 180d60f9ef..f2e2bb7475 100644 --- a/pkg/apis/OWNERS +++ b/pkg/apis/OWNERS @@ -1,44 +1,55 @@ -approvers: -- erictune -- lavalamp -- smarterclayton -- thockin -- liggitt -# - bgrant0607 # manual escalations only -reviewers: -- lavalamp -- smarterclayton -- wojtek-t -- deads2k -- yujuhong -- brendandburns -- derekwaynecarr -- caesarxuchao -- vishh -- mikedanese -- liggitt -- nikhiljindal -- gmarek -- erictune -- pmorie -- sttts -- dchen1107 -- saad-ali -- luxas -- janetkuo -- justinsb -- pwittrock -- ncdc -- tallclair -- yifan-gu -- eparis -- mwielgus -- feiskyer -- soltysh -- piosz -- dims -- errordeveloper -- madhusudancs -- krousey -- rootfs -- jszczepkowski +# See the OWNERS docs at https://go.k8s.io/owners + +filters: + ".*": + approvers: + - erictune + - lavalamp + - smarterclayton + - thockin + - liggitt + # - bgrant0607 # manual escalations only + reviewers: + - lavalamp + - smarterclayton + - wojtek-t + - deads2k + - yujuhong + - brendandburns + - derekwaynecarr + - caesarxuchao + - vishh + - mikedanese + - liggitt + - nikhiljindal + - gmarek + - erictune + - pmorie + - sttts + - dchen1107 + - saad-ali + - luxas + - janetkuo + - justinsb + - pwittrock + - ncdc + - tallclair + - yifan-gu + - eparis + - mwielgus + - feiskyer + - soltysh + - piosz + - dims + - errordeveloper + - madhusudancs + - krousey + - rootfs + - jszczepkowski + + # examples: + # pkg/apis/*/types.go + # pkg/apis/*/*/types.go + "[^/]+/([^/]+/)?(register|types)\\.go$": + labels: + - kind/api-change