From c55f47c4c987c94d0e360a33781fb114b056c2b2 Mon Sep 17 00:00:00 2001 From: Clayton Coleman Date: Tue, 12 Jul 2016 23:43:12 -0400 Subject: [PATCH] Fail correctly in go-to-protobuf We need to return earlier. --- cmd/libs/go2idl/go-to-protobuf/protobuf/cmd.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/cmd/libs/go2idl/go-to-protobuf/protobuf/cmd.go b/cmd/libs/go2idl/go-to-protobuf/protobuf/cmd.go index 33438b01b1..fd852d65be 100644 --- a/cmd/libs/go2idl/go-to-protobuf/protobuf/cmd.go +++ b/cmd/libs/go2idl/go-to-protobuf/protobuf/cmd.go @@ -179,13 +179,13 @@ func Run(g *Generator) { }, "public", ) - c.Verify = g.Common.VerifyOnly - c.FileTypes["protoidl"] = NewProtoFile() - if err != nil { log.Fatalf("Failed making a context: %v", err) } + c.Verify = g.Common.VerifyOnly + c.FileTypes["protoidl"] = NewProtoFile() + if err := protobufNames.AssignTypesToPackages(c); err != nil { log.Fatalf("Failed to identify Common types: %v", err) }