mirror of https://github.com/k3s-io/k3s
Merge pull request #44114 from copejon/remove-flaky-from-pv-tests
Automatic merge from submit-queue Remove [Flaky] from presistent volume NFS tests. **What this PR does / why we need it**: PV e2e test flaked because of a lack of isolation of test objects (PVs, claims). The common symptoms being volume-mounting pods timing out or an unexpected number of unbound claims being detected. PR #43645 Introduced the selector labels to test objects that restricted binds to within each "testspace". To accomplish this the test namespace was set as a label for all PVs and selector for all Claims. This allows each test to act as if it's isolated while still creating and binding PVs in parallel w/ other tests. This has been tested in parallel on both 3-node gci and debian clusters as `--ginkgo.focus="\[Volume\]" --ginkgo.skip="\[Disruptive\]|\[Feature.*\]|\[Serial\]"` with out signs of flakiness. cc @jeffvance ```release-note NONE ```pull/6/head
commit
bddc308ba2
|
@ -111,7 +111,7 @@ var _ = framework.KubeDescribe("PersistentVolumes [Volume]", func() {
|
|||
|
||||
// Testing configurations of a single a PV/PVC pair, multiple evenly paired PVs/PVCs,
|
||||
// and multiple unevenly paired PV/PVCs
|
||||
framework.KubeDescribe("PersistentVolumes:NFS[Flaky]", func() {
|
||||
framework.KubeDescribe("PersistentVolumes:NFS", func() {
|
||||
|
||||
var (
|
||||
nfsServerPod *v1.Pod
|
||||
|
@ -260,7 +260,7 @@ var _ = framework.KubeDescribe("PersistentVolumes [Volume]", func() {
|
|||
// This It() tests a scenario where a PV is written to by a Pod, recycled, then the volume checked
|
||||
// for files. If files are found, the checking Pod fails, failing the test. Otherwise, the pod
|
||||
// (and test) succeed.
|
||||
It("should test that a PV becomes Available and is clean after the PVC is deleted. [Volume] [Flaky]", func() {
|
||||
It("should test that a PV becomes Available and is clean after the PVC is deleted. [Volume]", func() {
|
||||
By("Writing to the volume.")
|
||||
pod := framework.MakeWritePod(ns, pvc)
|
||||
pod, err := c.CoreV1().Pods(ns).Create(pod)
|
||||
|
|
Loading…
Reference in New Issue