From b475cdf7fcad2ba33078fd6ab958a95f5308acd4 Mon Sep 17 00:00:00 2001 From: yanghaichao12 Date: Sat, 23 Feb 2019 03:02:11 -0500 Subject: [PATCH] Fix typos change SupportsPreemption change comment again --- pkg/scheduler/core/extender.go | 6 +++--- pkg/scheduler/factory/factory.go | 2 +- pkg/scheduler/internal/cache/cache_test.go | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/pkg/scheduler/core/extender.go b/pkg/scheduler/core/extender.go index d3830d047a..5f1c306b50 100644 --- a/pkg/scheduler/core/extender.go +++ b/pkg/scheduler/core/extender.go @@ -114,7 +114,7 @@ func NewHTTPExtender(config *schedulerapi.ExtenderConfig) (algorithm.SchedulerEx }, nil } -// Name returns extenderURL to identifies the extender. +// Name returns extenderURL to identify the extender. func (h *HTTPExtender) Name() string { return h.extenderURL } @@ -125,8 +125,8 @@ func (h *HTTPExtender) IsIgnorable() bool { return h.ignorable } -// SupportsPreemption returns if a extender support preemption. -// A extender should have preempt verb defined and enabled its own node cache. +// SupportsPreemption returns true if an extender supports preemption. +// An extender should have preempt verb defined and enabled its own node cache. func (h *HTTPExtender) SupportsPreemption() bool { return len(h.preemptVerb) > 0 } diff --git a/pkg/scheduler/factory/factory.go b/pkg/scheduler/factory/factory.go index b95746c7aa..3838950314 100644 --- a/pkg/scheduler/factory/factory.go +++ b/pkg/scheduler/factory/factory.go @@ -706,7 +706,7 @@ func MakeDefaultErrorFunc(client clientset.Interface, backoff *util.PodBackoff, } } -// nodeEnumerator allows a cache.Poller to enumerate items in an v1.NodeList +// nodeEnumerator allows a cache.Poller to enumerate items in a v1.NodeList type nodeEnumerator struct { *v1.NodeList } diff --git a/pkg/scheduler/internal/cache/cache_test.go b/pkg/scheduler/internal/cache/cache_test.go index 1964b00e1b..2edafa04b6 100644 --- a/pkg/scheduler/internal/cache/cache_test.go +++ b/pkg/scheduler/internal/cache/cache_test.go @@ -879,7 +879,7 @@ func TestForgetPod(t *testing.T) { } // getResourceRequest returns the resource request of all containers in Pods; -// excuding initContainers. +// excluding initContainers. func getResourceRequest(pod *v1.Pod) v1.ResourceList { result := &schedulernodeinfo.Resource{} for _, container := range pod.Spec.Containers {