From 38387aec0db3eda3a7debb4558a223ac92a41389 Mon Sep 17 00:00:00 2001 From: Wojciech Tyczynski Date: Tue, 20 Feb 2018 12:17:39 +0100 Subject: [PATCH] Fix race in healthchecking etcds leading to crashes --- .../k8s.io/apiserver/pkg/server/storage/storage_factory.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/staging/src/k8s.io/apiserver/pkg/server/storage/storage_factory.go b/staging/src/k8s.io/apiserver/pkg/server/storage/storage_factory.go index 89f617f7de..50c0682546 100644 --- a/staging/src/k8s.io/apiserver/pkg/server/storage/storage_factory.go +++ b/staging/src/k8s.io/apiserver/pkg/server/storage/storage_factory.go @@ -321,8 +321,10 @@ func (s *DefaultStorageFactory) Backends() []Backend { backends := []Backend{} for server := range servers { backends = append(backends, Backend{ - Server: server, - TLSConfig: tlsConfig, + Server: server, + // We can't share TLSConfig across different backends to avoid races. + // For more details see: http://pr.k8s.io/59338 + TLSConfig: tlsConfig.Clone(), }) } return backends