From a835d5bdd2747f3e799ab470bd2e2f14ee0fb52a Mon Sep 17 00:00:00 2001
From: Shiyang Wang <shiywang@redhat.com>
Date: Tue, 8 Aug 2017 14:37:52 +0800
Subject: [PATCH] Add unittests for GenerateLink

---
 .../apiserver/pkg/endpoints/handlers/BUILD    |   7 +-
 .../pkg/endpoints/handlers/namer_test.go      | 116 ++++++++++++++++++
 2 files changed, 122 insertions(+), 1 deletion(-)
 create mode 100644 staging/src/k8s.io/apiserver/pkg/endpoints/handlers/namer_test.go

diff --git a/staging/src/k8s.io/apiserver/pkg/endpoints/handlers/BUILD b/staging/src/k8s.io/apiserver/pkg/endpoints/handlers/BUILD
index d6d39bbe48..3b59060d09 100644
--- a/staging/src/k8s.io/apiserver/pkg/endpoints/handlers/BUILD
+++ b/staging/src/k8s.io/apiserver/pkg/endpoints/handlers/BUILD
@@ -10,13 +10,18 @@ load(
 
 go_test(
     name = "go_default_test",
-    srcs = ["rest_test.go"],
+    srcs = [
+        "namer_test.go",
+        "rest_test.go",
+    ],
     library = ":go_default_library",
     tags = ["automanaged"],
     deps = [
         "//vendor/github.com/evanphx/json-patch:go_default_library",
+        "//vendor/k8s.io/api/core/v1:go_default_library",
         "//vendor/k8s.io/apimachinery/pkg/api/equality:go_default_library",
         "//vendor/k8s.io/apimachinery/pkg/api/errors:go_default_library",
+        "//vendor/k8s.io/apimachinery/pkg/api/meta:go_default_library",
         "//vendor/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library",
         "//vendor/k8s.io/apimachinery/pkg/runtime:go_default_library",
         "//vendor/k8s.io/apimachinery/pkg/runtime/schema:go_default_library",
diff --git a/staging/src/k8s.io/apiserver/pkg/endpoints/handlers/namer_test.go b/staging/src/k8s.io/apiserver/pkg/endpoints/handlers/namer_test.go
new file mode 100644
index 0000000000..15c8818931
--- /dev/null
+++ b/staging/src/k8s.io/apiserver/pkg/endpoints/handlers/namer_test.go
@@ -0,0 +1,116 @@
+/*
+Copyright 2017 The Kubernetes Authors.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package handlers
+
+import (
+	"testing"
+
+	"k8s.io/api/core/v1"
+	"k8s.io/apimachinery/pkg/api/meta"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"k8s.io/apimachinery/pkg/runtime"
+	"k8s.io/apiserver/pkg/endpoints/request"
+)
+
+func TestGenerateLink(t *testing.T) {
+	testCases := []struct {
+		name          string
+		requestInfo   *request.RequestInfo
+		obj           runtime.Object
+		expect        string
+		expectErr     bool
+		clusterScoped bool
+	}{
+		{
+			name: "obj has more priority than requestInfo",
+			requestInfo: &request.RequestInfo{
+				Name:      "should-not-use",
+				Namespace: "should-not-use",
+				Resource:  "pod",
+			},
+			obj:           &v1.Pod{ObjectMeta: metav1.ObjectMeta{Name: "should-use", Namespace: "should-use"}},
+			expect:        "/api/v1/should-use/pod/should-use",
+			expectErr:     false,
+			clusterScoped: false,
+		},
+		{
+			name: "hit errEmptyName",
+			requestInfo: &request.RequestInfo{
+				Name:      "should-use",
+				Namespace: "should-use",
+				Resource:  "pod",
+			},
+			obj:           &v1.Pod{ObjectMeta: metav1.ObjectMeta{Namespace: "should-not-use"}},
+			expect:        "/api/v1/should-use/pod/should-use",
+			expectErr:     false,
+			clusterScoped: false,
+		},
+		{
+			name: "use namespace of requestInfo if obj namespace is empty",
+			requestInfo: &request.RequestInfo{
+				Name:      "should-not-use",
+				Namespace: "should-use",
+				Resource:  "pod",
+			},
+			obj:           &v1.Pod{ObjectMeta: metav1.ObjectMeta{Name: "should-use"}},
+			expect:        "/api/v1/should-use/pod/should-use",
+			expectErr:     false,
+			clusterScoped: false,
+		},
+		{
+			name: "hit error",
+			requestInfo: &request.RequestInfo{
+				Name:      "",
+				Namespace: "",
+				Resource:  "pod",
+			},
+			obj:           &v1.Pod{ObjectMeta: metav1.ObjectMeta{}},
+			expect:        "name must be provided",
+			expectErr:     true,
+			clusterScoped: false,
+		},
+		{
+			name: "cluster scoped",
+			requestInfo: &request.RequestInfo{
+				Name:      "only-name",
+				Namespace: "should-not-use",
+				Resource:  "pod",
+			},
+			obj:           &v1.Pod{ObjectMeta: metav1.ObjectMeta{}},
+			expect:        "/api/v1/only-name",
+			expectErr:     false,
+			clusterScoped: true,
+		},
+	}
+
+	for _, test := range testCases {
+		n := ContextBasedNaming{
+			SelfLinker:         meta.NewAccessor(),
+			SelfLinkPathPrefix: "/api/v1/",
+			ClusterScoped:      test.clusterScoped,
+		}
+		uri, err := n.GenerateLink(test.requestInfo, test.obj)
+
+		if uri != test.expect && err.Error() != test.expect {
+			if test.expectErr {
+				t.Fatalf("%s: unexpected non-error: %v", test.name, err)
+			} else {
+				t.Fatalf("%s: expected: %v, but got: %v", test.name, test.expect, uri)
+			}
+		}
+	}
+}