github
/
k3s
mirror of https://github.com/k3s-io/k3s
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Add PR merge policy for RC. 

Link to ok-to-merge label
pull/6/head
goltermann 2015-06-23 11:46:19 -07:00
parent 207c53b7e6
commit a3cb27df96
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
docs/devel/pull-requests.md
View File

@ -15,5 +15,17 @@ We want to limit the total number of PRs in flight to:
* Remove old PRs that would be difficult to rebase as the underlying code has changed over time
* Encourage code velocity
RC to v1.0 Pull Requests
------------------------
Between the first RC build (~6/22) and v1.0, we will adopt a higher bar for PR merges. For v1.0 to be a stable release, we need to ensure that any fixes going in are very well tested and have a low risk of breaking anything. Refactors and complex changes will be rejected in favor of more strategic and smaller workarounds.
These PRs require:
* A risk assessment by the code author in the PR. This should outline which parts of the code are being touched, the risk of regression, and complexity of the code.
* Two LGTMs from experienced reviewers.
Once those requirements are met, they will be labeled [ok-to-merge](https://github.com/GoogleCloudPlatform/kubernetes/pulls?utf8=%E2%9C%93&q=is%3Aopen+is%3Apr+label%3Aok-to-merge) and can be merged.
These restrictions will be relaxed after v1.0 is released.
[![Analytics](https://kubernetes-site.appspot.com/UA-36037335-10/GitHub/docs/devel/pull-requests.md?pixel)]()