github
/
k3s
mirror of https://github.com/k3s-io/k3s
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #45039 from shyamjvs/report-metrics-grabber-error 

Automatic merge from submit-queue (batch tested with PRs 42740, 44980, 45039, 41627, 45044)

Log the error (if any) in e2e metrics gathering step

Because why not.

Ref https://github.com/kubernetes/kubernetes/issues/45038

cc @wojtek-t @gmarek
pull/6/head
Kubernetes Submit Queue 2017-04-27 13:27:04 -07:00 committed by GitHub
parent a984a7ed09 87bfad85b1
commit a3c4d9d603
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/e2e/framework/framework.go
View File

@ -327,11 +327,11 @@ func (f *Framework) AfterEach() {
// TODO: enable Scheduler and ControllerManager metrics grabbing when Master's Kubelet will be registered.
grabber, err := metrics.NewMetricsGrabber(f.ClientSet, true, false, false, true)
if err != nil {
Logf("Failed to create MetricsGrabber. Skipping metrics gathering.")
Logf("Failed to create MetricsGrabber (skipping metrics gathering): %v", err)
} else {
received, err := grabber.Grab()
if err != nil {
Logf("MetricsGrabber failed grab metrics. Skipping metrics gathering.")
Logf("MetricsGrabber failed to grab metrics (skipping metrics gathering): %v", err)
} else {
summaries = append(summaries, (*MetricsForE2E)(&received))
}