Minor cleanup. #7572

pull/6/head
Robert Rati 2015-05-14 14:54:22 -04:00
parent 9caee9ad16
commit 9e06132ed3
2 changed files with 3 additions and 1 deletions

View File

@ -81,13 +81,14 @@ var _ = Describe("Density", func() {
Failf("Couldn't delete ns %s", err) Failf("Couldn't delete ns %s", err)
} }
expectNoError(writePerfData(c, uuid, "after"))
// Verify latency metrics // Verify latency metrics
// TODO: Update threshold to 1s once we reach this goal // TODO: Update threshold to 1s once we reach this goal
// TODO: We should reset metrics before the test. Currently previous tests influence latency metrics. // TODO: We should reset metrics before the test. Currently previous tests influence latency metrics.
highLatencyRequests, err := HighLatencyRequests(c, 10*time.Second, util.NewStringSet("events")) highLatencyRequests, err := HighLatencyRequests(c, 10*time.Second, util.NewStringSet("events"))
expectNoError(err) expectNoError(err)
Expect(highLatencyRequests).NotTo(BeNumerically(">", 0)) Expect(highLatencyRequests).NotTo(BeNumerically(">", 0))
expectNoError(writePerfData(c, uuid, "after"))
}) })
// Tests with "Skipped" substring in their name will be skipped when running // Tests with "Skipped" substring in their name will be skipped when running

View File

@ -534,6 +534,7 @@ func RunRC(c *client.Client, name string, ns, image string, replicas int, podSta
} }
} }
}(stop, name, ns, label) }(stop, name, ns, label)
defer close(stop)
By(fmt.Sprintf("Making sure all %d replicas of rc %s in namespace %s exist", replicas, name, ns)) By(fmt.Sprintf("Making sure all %d replicas of rc %s in namespace %s exist", replicas, name, ns))
failCount := 5 failCount := 5