Address shell-related comments.

pull/8/head
Katharine Berry 2018-08-31 17:07:25 -07:00
parent 13d1961d2b
commit 9b790dab7d
2 changed files with 5 additions and 3 deletions

1
.gitignore vendored
View File

@ -111,6 +111,7 @@ kubernetes.tar.gz
# TODO(thockin): uncomment this when we stop committing the generated files. # TODO(thockin): uncomment this when we stop committing the generated files.
#zz_generated.* #zz_generated.*
zz_generated.openapi.go zz_generated.openapi.go
zz_generated_*_test.go
# make-related metadata # make-related metadata
/.make/ /.make/

View File

@ -463,7 +463,7 @@ kube::golang::path_for_coverage_dummy_test() {
local package="$1" local package="$1"
local path="${KUBE_GOPATH}/src/${package}" local path="${KUBE_GOPATH}/src/${package}"
local name=$(basename "${package}") local name=$(basename "${package}")
echo "$path/zz_autogenerated_${name}_test.go" echo "$path/zz_generated_${name}_test.go"
} }
# Argument: the name of a Kubernetes package (e.g. k8s.io/kubernetes/cmd/kube-scheduler). # Argument: the name of a Kubernetes package (e.g. k8s.io/kubernetes/cmd/kube-scheduler).
@ -504,8 +504,9 @@ kube::golang::delete_coverage_dummy_test() {
} }
# Arguments: a list of kubernetes packages to build. # Arguments: a list of kubernetes packages to build.
# Expected variables: build_args should be set to an array of Go build arguments. # Expected variables: ${build_args} should be set to an array of Go build arguments.
# In addition, the standard build globals are assumed. # In addition, ${package} and ${platform} should have been set earlier, and if
# ${build_with_coverage} is set, coverage instrumentation will be enabled.
# #
# Invokes Go to actually build some packages. If coverage is disabled, simply invokes # Invokes Go to actually build some packages. If coverage is disabled, simply invokes
# go install. If coverage is enabled, builds covered binaries using go test, temporarily # go install. If coverage is enabled, builds covered binaries using go test, temporarily