From 998147de59c6c11d3d968990810d7ec69c07f7f8 Mon Sep 17 00:00:00 2001
From: danielqsj <qsj.daniel@gmail.com>
Date: Mon, 11 Feb 2019 16:50:19 +0800
Subject: [PATCH] fix shellcheck in
 pkg/kubectl/cmd/edit/testdata/record_testcase.sh

---
 hack/.shellcheck_failures                        | 1 -
 pkg/kubectl/cmd/edit/testdata/record_testcase.sh | 4 ++--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/hack/.shellcheck_failures b/hack/.shellcheck_failures
index d1538e293a..c3c767f27a 100644
--- a/hack/.shellcheck_failures
+++ b/hack/.shellcheck_failures
@@ -119,7 +119,6 @@
 ./hack/verify-test-images.sh
 ./hack/verify-test-owners.sh
 ./hack/verify-typecheck.sh
-./pkg/kubectl/cmd/edit/testdata/record_testcase.sh
 ./test/cmd/apply.sh
 ./test/cmd/apps.sh
 ./test/cmd/authorization.sh
diff --git a/pkg/kubectl/cmd/edit/testdata/record_testcase.sh b/pkg/kubectl/cmd/edit/testdata/record_testcase.sh
index c7685c4d3b..541d98175b 100755
--- a/pkg/kubectl/cmd/edit/testdata/record_testcase.sh
+++ b/pkg/kubectl/cmd/edit/testdata/record_testcase.sh
@@ -25,7 +25,7 @@ fi
 
 # Clean up the test server
 function cleanup {
-    if [[ ! -z "${pid-}" ]]; then
+    if [[ -n "${pid-}" ]]; then
         echo "Stopping recording server (${pid})"
         # kill the process `go run` launched
         pkill -P "${pid}"
@@ -36,7 +36,7 @@ function cleanup {
 
 testcase="${1}"
 
-test_root="$(dirname "${BASH_SOURCE}")"
+test_root="$(dirname "${BASH_SOURCE[0]}")"
 testcase_dir="${test_root}/testcase-${testcase}"
 mkdir -p "${testcase_dir}"