github
/
k3s
mirror of https://github.com/k3s-io/k3s
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #40342 from louyihua/remove_warning 

Automatic merge from submit-queue (batch tested with PRs 40111, 40368, 40342, 40274, 39443)

Eliminate "Unknown service type: ExternalName"

When creating an ExternalName service, rest.go still generate the warning message "Unknown service type: ExternalName". This should be eliminated as this type of service is supported now.
pull/6/head
Kubernetes Submit Queue 2017-01-31 19:18:41 -08:00 committed by GitHub
parent fd13413ba7 352d64ab0d
commit 8fe7a2decb
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/registry/core/service/rest.go
View File

@ -557,6 +557,8 @@ func shouldAssignNodePorts(service *api.Service) bool {
return true
case api.ServiceTypeClusterIP:
return false
case api.ServiceTypeExternalName:
return false
default:
glog.Errorf("Unknown service type: %v", service.Spec.Type)
return false