From 8bdb67639fb52972554602976fd1d444a980aafc Mon Sep 17 00:00:00 2001 From: Jeff Grafton Date: Wed, 11 Apr 2018 18:49:38 -0700 Subject: [PATCH] Add pointer comments --- build/bindata.bzl | 3 ++- hack/generate-bindata.sh | 4 ++++ pkg/generated/BUILD | 1 + test/e2e/generated/BUILD | 1 + 4 files changed, 8 insertions(+), 1 deletion(-) diff --git a/build/bindata.bzl b/build/bindata.bzl index 056082d56f..f21f42e577 100644 --- a/build/bindata.bzl +++ b/build/bindata.bzl @@ -12,7 +12,8 @@ # See the License for the specific language governing permissions and # limitations under the License. -# genrule wrapper around the go-bindata utility. +# Genrule wrapper around the go-bindata utility. +# IMPORTANT: Any changes to this rule may also require changes to hack/generate-bindata.sh. def go_bindata( name, srcs, outs, compress=True, diff --git a/hack/generate-bindata.sh b/hack/generate-bindata.sh index 72da6fcffd..9cf605098a 100755 --- a/hack/generate-bindata.sh +++ b/hack/generate-bindata.sh @@ -41,6 +41,8 @@ pushd "${KUBE_ROOT}" >/dev/null # These are files for e2e tests. BINDATA_OUTPUT="test/e2e/generated/bindata.go" +# IMPORTANT: if you make any changes to these arguments, you must also update +# test/e2e/generated/BUILD and/or build/bindata.bzl. go-bindata -nometadata -o "${BINDATA_OUTPUT}.tmp" -pkg generated \ -ignore .jpg -ignore .png -ignore .md -ignore 'BUILD(\.bazel)?' \ "test/e2e/testing-manifests/..." \ @@ -63,6 +65,8 @@ rm -f "${BINDATA_OUTPUT}.tmp" # These are files for runtime code BINDATA_OUTPUT="pkg/generated/bindata.go" +# IMPORTANT: if you make any changes to these arguments, you must also update +# pkg/generated/BUILD and/or build/bindata.bzl. go-bindata -nometadata -nocompress -o "${BINDATA_OUTPUT}.tmp" -pkg generated \ -ignore .jpg -ignore .png -ignore .md -ignore 'BUILD(\.bazel)?' \ "translations/..." diff --git a/pkg/generated/BUILD b/pkg/generated/BUILD index 0f7747bb73..35ecbd7de3 100644 --- a/pkg/generated/BUILD +++ b/pkg/generated/BUILD @@ -6,6 +6,7 @@ load( ) load("//build:bindata.bzl", "go_bindata") +# IMPORTANT: if you make any changes here, you must also update hack/generate-bindata.sh. go_bindata( name = "bindata", srcs = [ diff --git a/test/e2e/generated/BUILD b/test/e2e/generated/BUILD index 1451f45a84..250b668226 100644 --- a/test/e2e/generated/BUILD +++ b/test/e2e/generated/BUILD @@ -19,6 +19,7 @@ go_library( ], ) +# IMPORTANT: if you make any changes here, you must also update hack/generate-bindata.sh. go_bindata( name = "bindata", srcs = [