From 8fef7221a16b757c02cd9fbcd3a40f2237ef070f Mon Sep 17 00:00:00 2001 From: PingWang Date: Fri, 22 Feb 2019 16:48:00 +0800 Subject: [PATCH] Code cleanup and refactoring Signed-off-by: PingWang --- cmd/kubeadm/app/preflight/checks.go | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/cmd/kubeadm/app/preflight/checks.go b/cmd/kubeadm/app/preflight/checks.go index 9406cef528..5509c7d80d 100644 --- a/cmd/kubeadm/app/preflight/checks.go +++ b/cmd/kubeadm/app/preflight/checks.go @@ -1070,7 +1070,7 @@ func RunChecks(checks []Checker, ww io.Writer, ignorePreflightErrors sets.String Name string Errors []error } - found := []checkErrors{} + var errsBuffer bytes.Buffer for _, c := range checks { name := c.Name() @@ -1085,18 +1085,12 @@ func RunChecks(checks []Checker, ww io.Writer, ignorePreflightErrors sets.String for _, w := range warnings { io.WriteString(ww, fmt.Sprintf("\t[WARNING %s]: %v\n", name, w)) } - if len(errs) > 0 { - found = append(found, checkErrors{Name: name, Errors: errs}) + for _, i := range errs { + errsBuffer.WriteString(fmt.Sprintf("\t[ERROR %s]: %v\n", name, i.Error())) } } - if len(found) > 0 { - var errs bytes.Buffer - for _, c := range found { - for _, i := range c.Errors { - errs.WriteString(fmt.Sprintf("\t[ERROR %s]: %v\n", c.Name, i.Error())) - } - } - return &Error{Msg: errs.String()} + if errsBuffer.Len() > 0 { + return &Error{Msg: errsBuffer.String()} } return nil }