From 826b61c76d35ce0e611d70950cf99c292e87afd0 Mon Sep 17 00:00:00 2001 From: saadali Date: Tue, 13 Jan 2015 21:51:45 -0800 Subject: [PATCH] Address nits from PR #3423 --- pkg/kubelet/config/config.go | 4 +++- pkg/kubelet/types.go | 2 +- pkg/standalone/standalone.go | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/pkg/kubelet/config/config.go b/pkg/kubelet/config/config.go index e446055822..0e8f7cd5d6 100644 --- a/pkg/kubelet/config/config.go +++ b/pkg/kubelet/config/config.go @@ -76,7 +76,9 @@ func (c *PodConfig) Channel(source string) chan<- interface{} { return c.mux.Channel(source) } -func (c *PodConfig) SourceSeen(source string) bool { +// IsSourceSeen returns true if the specified source string has previously +// been marked as seen. +func (c *PodConfig) IsSourceSeen(source string) bool { if c.pods == nil { return false } diff --git a/pkg/kubelet/types.go b/pkg/kubelet/types.go index 884380ce80..5bf978d77d 100644 --- a/pkg/kubelet/types.go +++ b/pkg/kubelet/types.go @@ -81,7 +81,7 @@ func ParsePodFullName(podFullName string) (podName, podNamespace string, podAnno expectedNumFields := 3 actualNumFields := len(parts) if actualNumFields != expectedNumFields { - glog.Warningf("found a podFullName (%q) with too few fields: expected %d, actual %d.", podFullName, expectedNumFields, actualNumFields) + glog.Errorf("found a podFullName (%q) with too few fields: expected %d, actual %d.", podFullName, expectedNumFields, actualNumFields) return } podName = parts[0] diff --git a/pkg/standalone/standalone.go b/pkg/standalone/standalone.go index d32fbb4821..fa8e740d81 100644 --- a/pkg/standalone/standalone.go +++ b/pkg/standalone/standalone.go @@ -274,7 +274,7 @@ func createAndInitKubelet(kc *KubeletConfig, pc *config.PodConfig) (*kubelet.Kub kc.RegistryBurst, kc.MinimumGCAge, kc.MaxContainerCount, - pc.SourceSeen, + pc.IsSourceSeen, kc.ClusterDomain, net.IP(kc.ClusterDNS))