From 6aaeb209eb93af22fcad6f81e11be21ccf794d72 Mon Sep 17 00:00:00 2001 From: zhangmingld Date: Fri, 21 Sep 2018 10:19:35 +0800 Subject: [PATCH 1/2] fix some typo --- pkg/scheduler/factory/factory.go | 4 ++-- pkg/scheduler/scheduler.go | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/pkg/scheduler/factory/factory.go b/pkg/scheduler/factory/factory.go index dfffc75e05..905e909d4a 100644 --- a/pkg/scheduler/factory/factory.go +++ b/pkg/scheduler/factory/factory.go @@ -131,7 +131,7 @@ type configFactory struct { // Handles volume binding decisions volumeBinder *volumebinder.VolumeBinder - // always check all predicates even if the middle of one predicate fails. + // Always check all predicates even if the middle of one predicate fails. alwaysCheckAllPredicates bool // Disable pod preemption or not. @@ -162,7 +162,7 @@ type ConfigFactoryArgs struct { BindTimeoutSeconds int64 } -// NewConfigFactory initializes the default implementation of a Configurator To encourage eventual privatization of the struct type, we only +// NewConfigFactory initializes the default implementation of a Configurator. To encourage eventual privatization of the struct type, we only // return the interface. func NewConfigFactory(args *ConfigFactoryArgs) scheduler.Configurator { stopEverything := make(chan struct{}) diff --git a/pkg/scheduler/scheduler.go b/pkg/scheduler/scheduler.go index 3d836b6ee5..051a399c49 100644 --- a/pkg/scheduler/scheduler.go +++ b/pkg/scheduler/scheduler.go @@ -186,7 +186,7 @@ func (sched *Scheduler) Run() { go wait.Until(sched.scheduleOne, 0, sched.config.StopEverything) } -// Config return scheduler's config pointer. It is exposed for testing purposes. +// Config returns scheduler's config pointer. It is exposed for testing purposes. func (sched *Scheduler) Config() *Config { return sched.config } From 3648f7333725992b97e1a39defbb500c1492f668 Mon Sep 17 00:00:00 2001 From: zhangmingld Date: Fri, 21 Sep 2018 10:20:21 +0800 Subject: [PATCH 2/2] fix some typo --- cmd/kube-scheduler/app/options/options.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/kube-scheduler/app/options/options.go b/cmd/kube-scheduler/app/options/options.go index 20768465ec..f35c173687 100644 --- a/cmd/kube-scheduler/app/options/options.go +++ b/cmd/kube-scheduler/app/options/options.go @@ -205,7 +205,7 @@ func (o *Options) Config() (*schedulerappconfig.Config, error) { return nil, err } - // prepare kube clients. + // Prepare kube clients. client, leaderElectionClient, eventClient, err := createClients(c.ComponentConfig.ClientConnection, o.Master, c.ComponentConfig.LeaderElection.RenewDeadline.Duration) if err != nil { return nil, err