Remove host command sniffing from CanSupport(..)

pull/6/head
childsb 2016-02-23 17:13:14 -06:00
parent c1bd13ec4b
commit 7fed6f9f47
3 changed files with 3 additions and 22 deletions

View File

@ -59,15 +59,8 @@ func (plugin *fcPlugin) CanSupport(spec *volume.Spec) bool {
if (spec.Volume != nil && spec.Volume.FC == nil) || (spec.PersistentVolume != nil && spec.PersistentVolume.Spec.FC == nil) {
return false
}
// TODO: turn this into a func so CanSupport can be unit tested without
// having to make system calls
// see if /sys/class/fc_transport is there, which indicates fc is connected
_, err := plugin.execCommand("ls", []string{"/sys/class/fc_transport"})
if err == nil {
return true
}
return false
return true
}
func (plugin *fcPlugin) GetAccessModes() []api.PersistentVolumeAccessMode {

View File

@ -59,15 +59,8 @@ func (plugin *iscsiPlugin) CanSupport(spec *volume.Spec) bool {
if (spec.Volume != nil && spec.Volume.ISCSI == nil) || (spec.PersistentVolume != nil && spec.PersistentVolume.Spec.ISCSI == nil) {
return false
}
// TODO: turn this into a func so CanSupport can be unit tested without
// having to make system calls
// see if iscsiadm is there
_, err := plugin.execCommand("iscsiadm", []string{"-h"})
if err == nil {
return true
}
return false
return true
}
func (plugin *iscsiPlugin) GetAccessModes() []api.PersistentVolumeAccessMode {

View File

@ -58,13 +58,8 @@ func (plugin *rbdPlugin) CanSupport(spec *volume.Spec) bool {
if (spec.Volume != nil && spec.Volume.RBD == nil) || (spec.PersistentVolume != nil && spec.PersistentVolume.Spec.RBD == nil) {
return false
}
// see if rbd is there
_, err := plugin.execCommand("rbd", []string{"-h"})
if err == nil {
return true
}
return false
return true
}
func (plugin *rbdPlugin) GetAccessModes() []api.PersistentVolumeAccessMode {