diff --git a/cmd/kubeadm/app/phases/certs/certs.go b/cmd/kubeadm/app/phases/certs/certs.go index f620c22b5e..de8a29e27d 100644 --- a/cmd/kubeadm/app/phases/certs/certs.go +++ b/cmd/kubeadm/app/phases/certs/certs.go @@ -328,7 +328,7 @@ type certKeyLocation struct { } // SharedCertificateExists verifies if the shared certificates - the certificates that must be -// equal across masters: ca.key, ca.crt, sa.key, sa.pub + etcd/ca.key, etcd/ca.crt if local/stacked etcd +// equal across control-plane nodes: ca.key, ca.crt, sa.key, sa.pub + etcd/ca.key, etcd/ca.crt if local/stacked etcd func SharedCertificateExists(cfg *kubeadmapi.ClusterConfiguration) (bool, error) { if err := validateCACertAndKey(certKeyLocation{cfg.CertificatesDir, kubeadmconstants.CACertAndKeyBaseName, "", "CA"}); err != nil { diff --git a/cmd/kubeadm/app/phases/etcd/local_test.go b/cmd/kubeadm/app/phases/etcd/local_test.go index c5474088a6..aac26a7ea9 100644 --- a/cmd/kubeadm/app/phases/etcd/local_test.go +++ b/cmd/kubeadm/app/phases/etcd/local_test.go @@ -31,7 +31,7 @@ import ( ) func TestGetEtcdPodSpec(t *testing.T) { - // Creates a Master Configuration + // Creates a ClusterConfiguration cfg := &kubeadmapi.ClusterConfiguration{ KubernetesVersion: "v1.7.0", Etcd: kubeadmapi.Etcd{ diff --git a/cmd/kubeadm/app/phases/kubeconfig/doc.go b/cmd/kubeadm/app/phases/kubeconfig/doc.go index 3389ab78ac..f8d5afa12f 100644 --- a/cmd/kubeadm/app/phases/kubeconfig/doc.go +++ b/cmd/kubeadm/app/phases/kubeconfig/doc.go @@ -22,7 +22,7 @@ package kubeconfig INPUTS: From InitConfiguration - The Master API Server endpoint (AdvertiseAddress + BindPort) is required so the kubeconfig file knows where to find the master + The API Server endpoint (AdvertiseAddress + BindPort) is required so the kubeconfig file knows where to find the control-plane The KubernetesDir path is required for knowing where to put the kubeconfig files The PKIPath is required for knowing where all certificates should be stored diff --git a/cmd/kubeadm/app/phases/kubeconfig/kubeconfig_test.go b/cmd/kubeadm/app/phases/kubeconfig/kubeconfig_test.go index 83d159a303..f48e3db90c 100644 --- a/cmd/kubeadm/app/phases/kubeconfig/kubeconfig_test.go +++ b/cmd/kubeadm/app/phases/kubeconfig/kubeconfig_test.go @@ -45,7 +45,7 @@ func TestGetKubeConfigSpecsFailsIfCADoesntExists(t *testing.T) { tmpdir := testutil.SetupTempDir(t) defer os.RemoveAll(tmpdir) - // Creates a Master Configuration pointing to the pkidir folder + // Creates an InitConfiguration pointing to the pkidir folder cfg := &kubeadmapi.InitConfiguration{ ClusterConfiguration: kubeadmapi.ClusterConfiguration{ CertificatesDir: tmpdir, @@ -66,7 +66,7 @@ func TestGetKubeConfigSpecs(t *testing.T) { // Adds a pki folder with a ca certs to the temp folder pkidir := testutil.SetupPkiDirWithCertificateAuthorithy(t, tmpdir) - // Creates Master Configurations pointing to the pkidir folder + // Creates InitConfigurations pointing to the pkidir folder cfgs := []*kubeadmapi.InitConfiguration{ { LocalAPIEndpoint: kubeadmapi.APIEndpoint{AdvertiseAddress: "1.2.3.4", BindPort: 1234}, @@ -305,7 +305,7 @@ func TestCreateKubeconfigFilesAndWrappers(t *testing.T) { // Adds a pki folder with a ca certs to the temp folder pkidir := testutil.SetupPkiDirWithCertificateAuthorithy(t, tmpdir) - // Creates a Master Configuration pointing to the pkidir folder + // Creates an InitConfiguration pointing to the pkidir folder cfg := &kubeadmapi.InitConfiguration{ LocalAPIEndpoint: kubeadmapi.APIEndpoint{AdvertiseAddress: "1.2.3.4", BindPort: 1234}, ClusterConfiguration: kubeadmapi.ClusterConfiguration{ @@ -335,7 +335,7 @@ func TestWriteKubeConfigFailsIfCADoesntExists(t *testing.T) { tmpdir := testutil.SetupTempDir(t) defer os.RemoveAll(tmpdir) - // Creates a Master Configuration pointing to the tmpdir folder + // Creates an InitConfiguration pointing to the tmpdir folder cfg := &kubeadmapi.InitConfiguration{ ClusterConfiguration: kubeadmapi.ClusterConfiguration{ CertificatesDir: tmpdir, @@ -382,7 +382,7 @@ func TestWriteKubeConfig(t *testing.T) { t.Fatalf("couldn't retrieve ca cert: %v", err) } - // Creates a Master Configuration pointing to the pkidir folder + // Creates an InitConfiguration pointing to the pkidir folder cfg := &kubeadmapi.InitConfiguration{ LocalAPIEndpoint: kubeadmapi.APIEndpoint{AdvertiseAddress: "1.2.3.4", BindPort: 1234}, ClusterConfiguration: kubeadmapi.ClusterConfiguration{