From 983ff4381f78f39e2b5f36c29a971c7948ffcc88 Mon Sep 17 00:00:00 2001 From: Jeff Grafton Date: Thu, 21 Sep 2017 14:53:41 -0700 Subject: [PATCH 1/7] Remove orphaned rules --- build/root/BUILD.root | 25 +------------------------ staging/BUILD | 11 ----------- 2 files changed, 1 insertion(+), 35 deletions(-) diff --git a/build/root/BUILD.root b/build/root/BUILD.root index 7411c8cdf5..56627f257d 100644 --- a/build/root/BUILD.root +++ b/build/root/BUILD.root @@ -5,7 +5,7 @@ package(default_visibility = ["//visibility:public"]) -load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_prefix") +load("@io_bazel_rules_go//go:def.bzl", "go_prefix") load("@io_kubernetes_build//defs:build.bzl", "gcs_upload") go_prefix("k8s.io/kubernetes") @@ -80,26 +80,3 @@ genrule( cmd = "grep ^STABLE_BUILD_SCM_REVISION bazel-out/stable-status.txt | awk '{print $$2}' >$@", stamp = 1, ) - -go_library( - name = "go_default_library", - srcs = [ - "generated.pb.go", - "types.go", - ], - deps = [ - "//vendor/github.com/gogo/protobuf/proto:go_default_library", - "//vendor/github.com/gogo/protobuf/sortkeys:go_default_library", - "//vendor/k8s.io/apimachinery/pkg/api/resource:go_default_library", - "//vendor/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library", - "//vendor/k8s.io/apimachinery/pkg/runtime:go_default_library", - "//vendor/k8s.io/apimachinery/pkg/types:go_default_library", - "//vendor/k8s.io/apimachinery/pkg/util/intstr:go_default_library", - ], -) - -filegroup( - name = "go_default_library_protos", - srcs = ["generated.proto"], - visibility = ["//visibility:public"], -) diff --git a/staging/BUILD b/staging/BUILD index 97d0c67659..2d834c734c 100644 --- a/staging/BUILD +++ b/staging/BUILD @@ -6,17 +6,6 @@ load( "go_library", ) -go_binary( - name = "staging", - library = ":go_default_library", -) - -go_library( - name = "go_default_library", - srcs = ["godeps-json-updater.go"], - deps = ["//vendor/github.com/spf13/pflag:go_default_library"], -) - filegroup( name = "package-srcs", srcs = glob(["**"]), From 532bd482dfbe25c6fc970d2175f7e02fec2fc8c0 Mon Sep 17 00:00:00 2001 From: Jeff Grafton Date: Thu, 21 Sep 2017 14:53:56 -0700 Subject: [PATCH 2/7] Use buildozer to remove deprecated automanaged tags --- cmd/kubeadm/app/phases/addons/dns/BUILD | 2 -- cmd/kubeadm/app/phases/addons/proxy/BUILD | 1 - cmd/kubeadm/app/phases/etcd/BUILD | 2 -- cmd/kubeadm/app/util/staticpod/BUILD | 2 -- pkg/api/v1/validation/BUILD | 1 - pkg/apis/batch/v1beta1/BUILD | 2 -- pkg/capabilities/BUILD | 1 - pkg/controller/cloud/BUILD | 1 - pkg/controller/volume/expand/BUILD | 1 - pkg/controller/volume/expand/cache/BUILD | 1 - pkg/kubeapiserver/admission/util/BUILD | 1 - pkg/kubectl/apps/BUILD | 1 - pkg/kubectl/cmd/util/openapi/testing/BUILD | 1 - pkg/kubectl/cmd/util/openapi/validation/BUILD | 2 -- pkg/kubectl/util/hash/BUILD | 2 -- pkg/kubectl/validation/BUILD | 2 -- pkg/kubelet/apis/deviceplugin/v1alpha1/BUILD | 1 - pkg/kubelet/apis/kubeletconfig/BUILD | 1 - pkg/kubelet/apis/kubeletconfig/v1alpha1/BUILD | 1 - pkg/kubelet/apis/kubeletconfig/validation/BUILD | 1 - pkg/kubelet/deviceplugin/BUILD | 1 - pkg/proxy/ipvs/BUILD | 2 -- pkg/util/ipvs/BUILD | 2 -- pkg/util/ipvs/testing/BUILD | 1 - plugin/pkg/admission/eventratelimit/BUILD | 2 -- plugin/pkg/admission/eventratelimit/apis/eventratelimit/BUILD | 1 - .../admission/eventratelimit/apis/eventratelimit/install/BUILD | 1 - .../admission/eventratelimit/apis/eventratelimit/v1alpha1/BUILD | 1 - .../eventratelimit/apis/eventratelimit/validation/BUILD | 2 -- plugin/pkg/admission/persistentvolume/resize/BUILD | 2 -- plugin/pkg/admission/priority/BUILD | 2 -- staging/src/k8s.io/api/batch/v1beta1/BUILD | 1 - .../apiextensions-apiserver/pkg/apiserver/validation/BUILD | 1 - staging/src/k8s.io/apiserver/pkg/apis/audit/v1beta1/BUILD | 1 - .../src/k8s.io/apiserver/pkg/authentication/token/cache/BUILD | 2 -- .../src/k8s.io/apiserver/pkg/authentication/token/union/BUILD | 2 -- staging/src/k8s.io/client-go/informers/batch/v1beta1/BUILD | 1 - .../src/k8s.io/client-go/kubernetes/typed/batch/v1beta1/BUILD | 1 - .../k8s.io/client-go/kubernetes/typed/batch/v1beta1/fake/BUILD | 1 - staging/src/k8s.io/client-go/listers/batch/v1beta1/BUILD | 1 - staging/src/k8s.io/client-go/tools/pager/BUILD | 1 - test/e2e/auth/BUILD | 1 - test/e2e/scheduling/BUILD | 1 - test/images/nonewprivs/BUILD | 2 -- test/images/pets/peer-finder/BUILD | 2 -- test/utils/image/BUILD | 1 - vendor/github.com/vishvananda/netns/BUILD | 1 - 47 files changed, 64 deletions(-) diff --git a/cmd/kubeadm/app/phases/addons/dns/BUILD b/cmd/kubeadm/app/phases/addons/dns/BUILD index 22622cc9fa..b59b7bc768 100644 --- a/cmd/kubeadm/app/phases/addons/dns/BUILD +++ b/cmd/kubeadm/app/phases/addons/dns/BUILD @@ -15,7 +15,6 @@ go_test( "versions_test.go", ], library = ":go_default_library", - tags = ["automanaged"], deps = [ "//cmd/kubeadm/app/util:go_default_library", "//pkg/api:go_default_library", @@ -34,7 +33,6 @@ go_library( "manifests.go", "versions.go", ], - tags = ["automanaged"], deps = [ "//cmd/kubeadm/app/apis/kubeadm:go_default_library", "//cmd/kubeadm/app/constants:go_default_library", diff --git a/cmd/kubeadm/app/phases/addons/proxy/BUILD b/cmd/kubeadm/app/phases/addons/proxy/BUILD index 95e6ecc493..5eabcbce95 100644 --- a/cmd/kubeadm/app/phases/addons/proxy/BUILD +++ b/cmd/kubeadm/app/phases/addons/proxy/BUILD @@ -10,7 +10,6 @@ go_test( name = "go_default_test", srcs = ["proxy_test.go"], library = ":go_default_library", - tags = ["automanaged"], deps = [ "//cmd/kubeadm/app/util:go_default_library", "//pkg/api:go_default_library", diff --git a/cmd/kubeadm/app/phases/etcd/BUILD b/cmd/kubeadm/app/phases/etcd/BUILD index ba43cd2aff..8eef06d6d0 100644 --- a/cmd/kubeadm/app/phases/etcd/BUILD +++ b/cmd/kubeadm/app/phases/etcd/BUILD @@ -12,7 +12,6 @@ go_test( name = "go_default_test", srcs = ["local_test.go"], library = ":go_default_library", - tags = ["automanaged"], deps = [ "//cmd/kubeadm/app/apis/kubeadm:go_default_library", "//cmd/kubeadm/app/constants:go_default_library", @@ -23,7 +22,6 @@ go_test( go_library( name = "go_default_library", srcs = ["local.go"], - tags = ["automanaged"], deps = [ "//cmd/kubeadm/app/apis/kubeadm:go_default_library", "//cmd/kubeadm/app/constants:go_default_library", diff --git a/cmd/kubeadm/app/util/staticpod/BUILD b/cmd/kubeadm/app/util/staticpod/BUILD index c6d7379b2f..a2bf2379c8 100644 --- a/cmd/kubeadm/app/util/staticpod/BUILD +++ b/cmd/kubeadm/app/util/staticpod/BUILD @@ -12,7 +12,6 @@ go_test( name = "go_default_test", srcs = ["utils_test.go"], library = ":go_default_library", - tags = ["automanaged"], deps = [ "//vendor/k8s.io/api/core/v1:go_default_library", "//vendor/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library", @@ -23,7 +22,6 @@ go_test( go_library( name = "go_default_library", srcs = ["utils.go"], - tags = ["automanaged"], deps = [ "//cmd/kubeadm/app/constants:go_default_library", "//pkg/kubelet/types:go_default_library", diff --git a/pkg/api/v1/validation/BUILD b/pkg/api/v1/validation/BUILD index 14612044e1..a0725403fc 100644 --- a/pkg/api/v1/validation/BUILD +++ b/pkg/api/v1/validation/BUILD @@ -38,7 +38,6 @@ go_test( name = "go_default_test", srcs = ["validation_test.go"], library = ":go_default_library", - tags = ["automanaged"], deps = [ "//vendor/k8s.io/api/core/v1:go_default_library", "//vendor/k8s.io/apimachinery/pkg/api/resource:go_default_library", diff --git a/pkg/apis/batch/v1beta1/BUILD b/pkg/apis/batch/v1beta1/BUILD index 7e9649f8ef..4eed77c24e 100644 --- a/pkg/apis/batch/v1beta1/BUILD +++ b/pkg/apis/batch/v1beta1/BUILD @@ -18,7 +18,6 @@ go_library( "zz_generated.conversion.go", "zz_generated.defaults.go", ], - tags = ["automanaged"], deps = [ "//pkg/api:go_default_library", "//pkg/api/v1:go_default_library", @@ -36,7 +35,6 @@ go_library( go_test( name = "go_default_xtest", srcs = ["defaults_test.go"], - tags = ["automanaged"], deps = [ ":go_default_library", "//pkg/api:go_default_library", diff --git a/pkg/capabilities/BUILD b/pkg/capabilities/BUILD index 33b71a8239..cd93c24bcc 100644 --- a/pkg/capabilities/BUILD +++ b/pkg/capabilities/BUILD @@ -18,7 +18,6 @@ go_test( name = "go_default_test", srcs = ["capabilities_test.go"], library = ":go_default_library", - tags = ["automanaged"], ) filegroup( diff --git a/pkg/controller/cloud/BUILD b/pkg/controller/cloud/BUILD index 541f863885..6722be705c 100644 --- a/pkg/controller/cloud/BUILD +++ b/pkg/controller/cloud/BUILD @@ -12,7 +12,6 @@ go_library( "node_controller.go", "pvlcontroller.go", ], - tags = ["automanaged"], deps = [ "//pkg/api/v1/node:go_default_library", "//pkg/cloudprovider:go_default_library", diff --git a/pkg/controller/volume/expand/BUILD b/pkg/controller/volume/expand/BUILD index b68223bee8..f108657eb8 100644 --- a/pkg/controller/volume/expand/BUILD +++ b/pkg/controller/volume/expand/BUILD @@ -14,7 +14,6 @@ go_library( "pvc_populator.go", "sync_volume_resize.go", ], - tags = ["automanaged"], deps = [ "//pkg/cloudprovider:go_default_library", "//pkg/controller:go_default_library", diff --git a/pkg/controller/volume/expand/cache/BUILD b/pkg/controller/volume/expand/cache/BUILD index f07d34a020..5d5a52d2c8 100644 --- a/pkg/controller/volume/expand/cache/BUILD +++ b/pkg/controller/volume/expand/cache/BUILD @@ -11,7 +11,6 @@ load( go_library( name = "go_default_library", srcs = ["volume_resize_map.go"], - tags = ["automanaged"], deps = [ "//pkg/controller/volume/expand/util:go_default_library", "//pkg/util/strings:go_default_library", diff --git a/pkg/kubeapiserver/admission/util/BUILD b/pkg/kubeapiserver/admission/util/BUILD index 33a6ab2bde..f4a9768963 100644 --- a/pkg/kubeapiserver/admission/util/BUILD +++ b/pkg/kubeapiserver/admission/util/BUILD @@ -10,7 +10,6 @@ load( go_library( name = "go_default_library", srcs = ["initializer.go"], - tags = ["automanaged"], deps = [ "//vendor/k8s.io/apimachinery/pkg/api/meta:go_default_library", "//vendor/k8s.io/apimachinery/pkg/util/initialization:go_default_library", diff --git a/pkg/kubectl/apps/BUILD b/pkg/kubectl/apps/BUILD index 5869823376..693b8b8e93 100644 --- a/pkg/kubectl/apps/BUILD +++ b/pkg/kubectl/apps/BUILD @@ -11,7 +11,6 @@ load( go_library( name = "go_default_library", srcs = ["kind_visitor.go"], - tags = ["automanaged"], deps = ["//vendor/k8s.io/apimachinery/pkg/runtime/schema:go_default_library"], ) diff --git a/pkg/kubectl/cmd/util/openapi/testing/BUILD b/pkg/kubectl/cmd/util/openapi/testing/BUILD index 9fed9f861b..f683c363b0 100644 --- a/pkg/kubectl/cmd/util/openapi/testing/BUILD +++ b/pkg/kubectl/cmd/util/openapi/testing/BUILD @@ -10,7 +10,6 @@ load( go_library( name = "go_default_library", srcs = ["openapi.go"], - tags = ["automanaged"], deps = [ "//vendor/github.com/googleapis/gnostic/OpenAPIv2:go_default_library", "//vendor/github.com/googleapis/gnostic/compiler:go_default_library", diff --git a/pkg/kubectl/cmd/util/openapi/validation/BUILD b/pkg/kubectl/cmd/util/openapi/validation/BUILD index 77b98f39bb..f55d5119c3 100644 --- a/pkg/kubectl/cmd/util/openapi/validation/BUILD +++ b/pkg/kubectl/cmd/util/openapi/validation/BUILD @@ -15,7 +15,6 @@ go_library( "types.go", "validation.go", ], - tags = ["automanaged"], deps = [ "//pkg/api:go_default_library", "//pkg/api/util:go_default_library", @@ -34,7 +33,6 @@ go_test( "validation_test.go", ], data = ["//api/openapi-spec:swagger-spec"], - tags = ["automanaged"], deps = [ ":go_default_library", "//pkg/api/testapi:go_default_library", diff --git a/pkg/kubectl/util/hash/BUILD b/pkg/kubectl/util/hash/BUILD index 30f5802f70..1249577fde 100644 --- a/pkg/kubectl/util/hash/BUILD +++ b/pkg/kubectl/util/hash/BUILD @@ -12,14 +12,12 @@ go_test( name = "go_default_test", srcs = ["hash_test.go"], library = ":go_default_library", - tags = ["automanaged"], deps = ["//pkg/api:go_default_library"], ) go_library( name = "go_default_library", srcs = ["hash.go"], - tags = ["automanaged"], deps = ["//pkg/api:go_default_library"], ) diff --git a/pkg/kubectl/validation/BUILD b/pkg/kubectl/validation/BUILD index 3b2de79ad2..e5443452a2 100644 --- a/pkg/kubectl/validation/BUILD +++ b/pkg/kubectl/validation/BUILD @@ -34,7 +34,6 @@ go_test( "//api/swagger-spec", ], library = ":go_default_library", - tags = ["automanaged"], deps = [ "//pkg/api:go_default_library", "//pkg/api/testapi:go_default_library", @@ -51,7 +50,6 @@ go_test( go_library( name = "go_default_library", srcs = ["schema.go"], - tags = ["automanaged"], visibility = ["//build/visible_to:pkg_kubectl_validation_CONSUMERS"], deps = [ "//pkg/api/util:go_default_library", diff --git a/pkg/kubelet/apis/deviceplugin/v1alpha1/BUILD b/pkg/kubelet/apis/deviceplugin/v1alpha1/BUILD index 07e26b69b1..c43100a21f 100644 --- a/pkg/kubelet/apis/deviceplugin/v1alpha1/BUILD +++ b/pkg/kubelet/apis/deviceplugin/v1alpha1/BUILD @@ -13,7 +13,6 @@ go_library( "api.pb.go", "constants.go", ], - tags = ["automanaged"], deps = [ "//vendor/github.com/gogo/protobuf/gogoproto:go_default_library", "//vendor/github.com/gogo/protobuf/proto:go_default_library", diff --git a/pkg/kubelet/apis/kubeletconfig/BUILD b/pkg/kubelet/apis/kubeletconfig/BUILD index 07c85a597d..4428c8bd63 100644 --- a/pkg/kubelet/apis/kubeletconfig/BUILD +++ b/pkg/kubelet/apis/kubeletconfig/BUILD @@ -15,7 +15,6 @@ go_library( "types.go", "zz_generated.deepcopy.go", ], - tags = ["automanaged"], deps = [ "//pkg/api:go_default_library", "//vendor/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library", diff --git a/pkg/kubelet/apis/kubeletconfig/v1alpha1/BUILD b/pkg/kubelet/apis/kubeletconfig/v1alpha1/BUILD index 0618be7f13..ef43b6f3ff 100644 --- a/pkg/kubelet/apis/kubeletconfig/v1alpha1/BUILD +++ b/pkg/kubelet/apis/kubeletconfig/v1alpha1/BUILD @@ -18,7 +18,6 @@ go_library( "zz_generated.deepcopy.go", "zz_generated.defaults.go", ], - tags = ["automanaged"], deps = [ "//pkg/api:go_default_library", "//pkg/kubelet/apis/kubeletconfig:go_default_library", diff --git a/pkg/kubelet/apis/kubeletconfig/validation/BUILD b/pkg/kubelet/apis/kubeletconfig/validation/BUILD index 432212ea3e..7803606382 100644 --- a/pkg/kubelet/apis/kubeletconfig/validation/BUILD +++ b/pkg/kubelet/apis/kubeletconfig/validation/BUILD @@ -11,7 +11,6 @@ load( go_library( name = "go_default_library", srcs = ["validation.go"], - tags = ["automanaged"], deps = [ "//pkg/kubelet/apis/kubeletconfig:go_default_library", "//pkg/kubelet/cm:go_default_library", diff --git a/pkg/kubelet/deviceplugin/BUILD b/pkg/kubelet/deviceplugin/BUILD index db841b8a99..31e2a9fe33 100644 --- a/pkg/kubelet/deviceplugin/BUILD +++ b/pkg/kubelet/deviceplugin/BUILD @@ -17,7 +17,6 @@ go_library( "types.go", "utils.go", ], - tags = ["automanaged"], deps = [ "//pkg/api/v1/helper:go_default_library", "//pkg/kubelet/apis/deviceplugin/v1alpha1:go_default_library", diff --git a/pkg/proxy/ipvs/BUILD b/pkg/proxy/ipvs/BUILD index bab8f9af83..1655b41b29 100644 --- a/pkg/proxy/ipvs/BUILD +++ b/pkg/proxy/ipvs/BUILD @@ -17,7 +17,6 @@ go_test( "//conditions:default": [], }), library = ":go_default_library", - tags = ["automanaged"], deps = select({ "@io_bazel_rules_go//go/platform:linux_amd64": [ "//pkg/api:go_default_library", @@ -42,7 +41,6 @@ go_test( go_library( name = "go_default_library", srcs = ["proxier.go"], - tags = ["automanaged"], deps = [ "//pkg/api:go_default_library", "//pkg/api/helper:go_default_library", diff --git a/pkg/util/ipvs/BUILD b/pkg/util/ipvs/BUILD index 2a565b7d3b..e5f488de45 100644 --- a/pkg/util/ipvs/BUILD +++ b/pkg/util/ipvs/BUILD @@ -19,7 +19,6 @@ go_test( "//conditions:default": [], }), library = ":go_default_library", - tags = ["automanaged"], deps = select({ "@io_bazel_rules_go//go/platform:linux_amd64": [ "//vendor/github.com/docker/libnetwork/ipvs:go_default_library", @@ -42,7 +41,6 @@ go_library( ], "//conditions:default": [], }), - tags = ["automanaged"], deps = [ "//vendor/k8s.io/utils/exec:go_default_library", ] + select({ diff --git a/pkg/util/ipvs/testing/BUILD b/pkg/util/ipvs/testing/BUILD index 199a106878..36608dc347 100644 --- a/pkg/util/ipvs/testing/BUILD +++ b/pkg/util/ipvs/testing/BUILD @@ -10,7 +10,6 @@ load( go_library( name = "go_default_library", srcs = ["fake.go"], - tags = ["automanaged"], deps = ["//pkg/util/ipvs:go_default_library"], ) diff --git a/plugin/pkg/admission/eventratelimit/BUILD b/plugin/pkg/admission/eventratelimit/BUILD index e2b9f31d81..d4b15fe825 100644 --- a/plugin/pkg/admission/eventratelimit/BUILD +++ b/plugin/pkg/admission/eventratelimit/BUILD @@ -15,7 +15,6 @@ go_test( "cache_test.go", ], library = ":go_default_library", - tags = ["automanaged"], deps = [ "//pkg/api:go_default_library", "//plugin/pkg/admission/eventratelimit/apis/eventratelimit:go_default_library", @@ -39,7 +38,6 @@ go_library( "doc.go", "limitenforcer.go", ], - tags = ["automanaged"], deps = [ "//pkg/api:go_default_library", "//plugin/pkg/admission/eventratelimit/apis/eventratelimit:go_default_library", diff --git a/plugin/pkg/admission/eventratelimit/apis/eventratelimit/BUILD b/plugin/pkg/admission/eventratelimit/apis/eventratelimit/BUILD index 5c30dafeae..d486f88813 100644 --- a/plugin/pkg/admission/eventratelimit/apis/eventratelimit/BUILD +++ b/plugin/pkg/admission/eventratelimit/apis/eventratelimit/BUILD @@ -15,7 +15,6 @@ go_library( "types.go", "zz_generated.deepcopy.go", ], - tags = ["automanaged"], deps = [ "//vendor/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library", "//vendor/k8s.io/apimachinery/pkg/conversion:go_default_library", diff --git a/plugin/pkg/admission/eventratelimit/apis/eventratelimit/install/BUILD b/plugin/pkg/admission/eventratelimit/apis/eventratelimit/install/BUILD index a5d67e1170..75251ed6f6 100644 --- a/plugin/pkg/admission/eventratelimit/apis/eventratelimit/install/BUILD +++ b/plugin/pkg/admission/eventratelimit/apis/eventratelimit/install/BUILD @@ -10,7 +10,6 @@ load( go_library( name = "go_default_library", srcs = ["install.go"], - tags = ["automanaged"], deps = [ "//plugin/pkg/admission/eventratelimit/apis/eventratelimit:go_default_library", "//plugin/pkg/admission/eventratelimit/apis/eventratelimit/v1alpha1:go_default_library", diff --git a/plugin/pkg/admission/eventratelimit/apis/eventratelimit/v1alpha1/BUILD b/plugin/pkg/admission/eventratelimit/apis/eventratelimit/v1alpha1/BUILD index ec318571dd..94912ab762 100644 --- a/plugin/pkg/admission/eventratelimit/apis/eventratelimit/v1alpha1/BUILD +++ b/plugin/pkg/admission/eventratelimit/apis/eventratelimit/v1alpha1/BUILD @@ -18,7 +18,6 @@ go_library( "zz_generated.deepcopy.go", "zz_generated.defaults.go", ], - tags = ["automanaged"], deps = [ "//plugin/pkg/admission/eventratelimit/apis/eventratelimit:go_default_library", "//vendor/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library", diff --git a/plugin/pkg/admission/eventratelimit/apis/eventratelimit/validation/BUILD b/plugin/pkg/admission/eventratelimit/apis/eventratelimit/validation/BUILD index 551eb5f51d..1d06cbb0bd 100644 --- a/plugin/pkg/admission/eventratelimit/apis/eventratelimit/validation/BUILD +++ b/plugin/pkg/admission/eventratelimit/apis/eventratelimit/validation/BUILD @@ -11,7 +11,6 @@ load( go_library( name = "go_default_library", srcs = ["validation.go"], - tags = ["automanaged"], deps = [ "//plugin/pkg/admission/eventratelimit/apis/eventratelimit:go_default_library", "//vendor/k8s.io/apimachinery/pkg/util/validation/field:go_default_library", @@ -35,6 +34,5 @@ go_test( name = "go_default_test", srcs = ["validation_test.go"], library = ":go_default_library", - tags = ["automanaged"], deps = ["//plugin/pkg/admission/eventratelimit/apis/eventratelimit:go_default_library"], ) diff --git a/plugin/pkg/admission/persistentvolume/resize/BUILD b/plugin/pkg/admission/persistentvolume/resize/BUILD index 37289faba6..f7db08d0af 100644 --- a/plugin/pkg/admission/persistentvolume/resize/BUILD +++ b/plugin/pkg/admission/persistentvolume/resize/BUILD @@ -12,7 +12,6 @@ go_test( name = "go_default_test", srcs = ["admission_test.go"], library = ":go_default_library", - tags = ["automanaged"], deps = [ "//pkg/api:go_default_library", "//pkg/apis/storage:go_default_library", @@ -29,7 +28,6 @@ go_test( go_library( name = "go_default_library", srcs = ["admission.go"], - tags = ["automanaged"], deps = [ "//pkg/api:go_default_library", "//pkg/api/helper:go_default_library", diff --git a/plugin/pkg/admission/priority/BUILD b/plugin/pkg/admission/priority/BUILD index 2217543459..05f328be1e 100644 --- a/plugin/pkg/admission/priority/BUILD +++ b/plugin/pkg/admission/priority/BUILD @@ -12,7 +12,6 @@ go_test( name = "go_default_test", srcs = ["admission_test.go"], library = ":go_default_library", - tags = ["automanaged"], deps = [ "//pkg/api:go_default_library", "//pkg/apis/scheduling:go_default_library", @@ -29,7 +28,6 @@ go_test( go_library( name = "go_default_library", srcs = ["admission.go"], - tags = ["automanaged"], deps = [ "//pkg/api:go_default_library", "//pkg/apis/scheduling:go_default_library", diff --git a/staging/src/k8s.io/api/batch/v1beta1/BUILD b/staging/src/k8s.io/api/batch/v1beta1/BUILD index d421dd6227..4924d154d7 100644 --- a/staging/src/k8s.io/api/batch/v1beta1/BUILD +++ b/staging/src/k8s.io/api/batch/v1beta1/BUILD @@ -17,7 +17,6 @@ go_library( "types_swagger_doc_generated.go", "zz_generated.deepcopy.go", ], - tags = ["automanaged"], deps = [ "//vendor/github.com/gogo/protobuf/proto:go_default_library", "//vendor/k8s.io/api/batch/v1:go_default_library", diff --git a/staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/validation/BUILD b/staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/validation/BUILD index b64622758b..72f9652b9b 100644 --- a/staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/validation/BUILD +++ b/staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/validation/BUILD @@ -10,7 +10,6 @@ load( go_library( name = "go_default_library", srcs = ["validation.go"], - tags = ["automanaged"], deps = [ "//vendor/github.com/go-openapi/spec:go_default_library", "//vendor/github.com/go-openapi/validate:go_default_library", diff --git a/staging/src/k8s.io/apiserver/pkg/apis/audit/v1beta1/BUILD b/staging/src/k8s.io/apiserver/pkg/apis/audit/v1beta1/BUILD index a08dd171a9..889d9c9997 100644 --- a/staging/src/k8s.io/apiserver/pkg/apis/audit/v1beta1/BUILD +++ b/staging/src/k8s.io/apiserver/pkg/apis/audit/v1beta1/BUILD @@ -18,7 +18,6 @@ go_library( "zz_generated.deepcopy.go", "zz_generated.defaults.go", ], - tags = ["automanaged"], deps = [ "//vendor/github.com/gogo/protobuf/proto:go_default_library", "//vendor/k8s.io/api/authentication/v1:go_default_library", diff --git a/staging/src/k8s.io/apiserver/pkg/authentication/token/cache/BUILD b/staging/src/k8s.io/apiserver/pkg/authentication/token/cache/BUILD index 3384859f72..252bdcc884 100644 --- a/staging/src/k8s.io/apiserver/pkg/authentication/token/cache/BUILD +++ b/staging/src/k8s.io/apiserver/pkg/authentication/token/cache/BUILD @@ -15,7 +15,6 @@ go_test( "cached_token_authenticator_test.go", ], library = ":go_default_library", - tags = ["automanaged"], deps = [ "//vendor/github.com/pborman/uuid:go_default_library", "//vendor/k8s.io/apimachinery/pkg/util/clock:go_default_library", @@ -31,7 +30,6 @@ go_library( "cache_striped.go", "cached_token_authenticator.go", ], - tags = ["automanaged"], deps = [ "//vendor/k8s.io/apimachinery/pkg/util/cache:go_default_library", "//vendor/k8s.io/apimachinery/pkg/util/clock:go_default_library", diff --git a/staging/src/k8s.io/apiserver/pkg/authentication/token/union/BUILD b/staging/src/k8s.io/apiserver/pkg/authentication/token/union/BUILD index 7a6b23db96..9178946cef 100644 --- a/staging/src/k8s.io/apiserver/pkg/authentication/token/union/BUILD +++ b/staging/src/k8s.io/apiserver/pkg/authentication/token/union/BUILD @@ -12,14 +12,12 @@ go_test( name = "go_default_test", srcs = ["unionauth_test.go"], library = ":go_default_library", - tags = ["automanaged"], deps = ["//vendor/k8s.io/apiserver/pkg/authentication/user:go_default_library"], ) go_library( name = "go_default_library", srcs = ["union.go"], - tags = ["automanaged"], deps = [ "//vendor/k8s.io/apimachinery/pkg/util/errors:go_default_library", "//vendor/k8s.io/apiserver/pkg/authentication/authenticator:go_default_library", diff --git a/staging/src/k8s.io/client-go/informers/batch/v1beta1/BUILD b/staging/src/k8s.io/client-go/informers/batch/v1beta1/BUILD index e917e1d4ee..3a202199b8 100644 --- a/staging/src/k8s.io/client-go/informers/batch/v1beta1/BUILD +++ b/staging/src/k8s.io/client-go/informers/batch/v1beta1/BUILD @@ -13,7 +13,6 @@ go_library( "cronjob.go", "interface.go", ], - tags = ["automanaged"], deps = [ "//vendor/k8s.io/api/batch/v1beta1:go_default_library", "//vendor/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library", diff --git a/staging/src/k8s.io/client-go/kubernetes/typed/batch/v1beta1/BUILD b/staging/src/k8s.io/client-go/kubernetes/typed/batch/v1beta1/BUILD index 9d1e3aee05..c9a1e4c871 100644 --- a/staging/src/k8s.io/client-go/kubernetes/typed/batch/v1beta1/BUILD +++ b/staging/src/k8s.io/client-go/kubernetes/typed/batch/v1beta1/BUILD @@ -15,7 +15,6 @@ go_library( "doc.go", "generated_expansion.go", ], - tags = ["automanaged"], deps = [ "//vendor/k8s.io/api/batch/v1beta1:go_default_library", "//vendor/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library", diff --git a/staging/src/k8s.io/client-go/kubernetes/typed/batch/v1beta1/fake/BUILD b/staging/src/k8s.io/client-go/kubernetes/typed/batch/v1beta1/fake/BUILD index c9265a5ed4..31f4cdd4a5 100644 --- a/staging/src/k8s.io/client-go/kubernetes/typed/batch/v1beta1/fake/BUILD +++ b/staging/src/k8s.io/client-go/kubernetes/typed/batch/v1beta1/fake/BUILD @@ -14,7 +14,6 @@ go_library( "fake_batch_client.go", "fake_cronjob.go", ], - tags = ["automanaged"], deps = [ "//vendor/k8s.io/api/batch/v1beta1:go_default_library", "//vendor/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library", diff --git a/staging/src/k8s.io/client-go/listers/batch/v1beta1/BUILD b/staging/src/k8s.io/client-go/listers/batch/v1beta1/BUILD index 8d2a39f3fc..ab06f2466f 100644 --- a/staging/src/k8s.io/client-go/listers/batch/v1beta1/BUILD +++ b/staging/src/k8s.io/client-go/listers/batch/v1beta1/BUILD @@ -13,7 +13,6 @@ go_library( "cronjob.go", "expansion_generated.go", ], - tags = ["automanaged"], deps = [ "//vendor/k8s.io/api/batch/v1beta1:go_default_library", "//vendor/k8s.io/apimachinery/pkg/api/errors:go_default_library", diff --git a/staging/src/k8s.io/client-go/tools/pager/BUILD b/staging/src/k8s.io/client-go/tools/pager/BUILD index e7b95c40da..e3cda4d5a5 100644 --- a/staging/src/k8s.io/client-go/tools/pager/BUILD +++ b/staging/src/k8s.io/client-go/tools/pager/BUILD @@ -11,7 +11,6 @@ load( go_library( name = "go_default_library", srcs = ["pager.go"], - tags = ["automanaged"], deps = [ "//vendor/golang.org/x/net/context:go_default_library", "//vendor/k8s.io/apimachinery/pkg/api/errors:go_default_library", diff --git a/test/e2e/auth/BUILD b/test/e2e/auth/BUILD index c91db0004d..a50958bda9 100644 --- a/test/e2e/auth/BUILD +++ b/test/e2e/auth/BUILD @@ -16,7 +16,6 @@ go_library( "node_authz.go", "service_accounts.go", ], - tags = ["automanaged"], deps = [ "//pkg/util/version:go_default_library", "//plugin/pkg/admission/serviceaccount:go_default_library", diff --git a/test/e2e/scheduling/BUILD b/test/e2e/scheduling/BUILD index 5a45a42a9c..7567684199 100644 --- a/test/e2e/scheduling/BUILD +++ b/test/e2e/scheduling/BUILD @@ -66,7 +66,6 @@ go_test( name = "go_default_test", srcs = ["taints_test.go"], library = ":go_default_library", - tags = ["automanaged"], deps = [ "//test/e2e/framework:go_default_library", "//test/utils:go_default_library", diff --git a/test/images/nonewprivs/BUILD b/test/images/nonewprivs/BUILD index 83b38d5c55..112e9e5824 100644 --- a/test/images/nonewprivs/BUILD +++ b/test/images/nonewprivs/BUILD @@ -11,13 +11,11 @@ load( go_binary( name = "nonewprivs", library = ":go_default_library", - tags = ["automanaged"], ) go_library( name = "go_default_library", srcs = ["nnp.go"], - tags = ["automanaged"], ) filegroup( diff --git a/test/images/pets/peer-finder/BUILD b/test/images/pets/peer-finder/BUILD index c62754211b..b0fd1e7442 100644 --- a/test/images/pets/peer-finder/BUILD +++ b/test/images/pets/peer-finder/BUILD @@ -11,13 +11,11 @@ load( go_binary( name = "peer-finder", library = ":go_default_library", - tags = ["automanaged"], ) go_library( name = "go_default_library", srcs = ["peer-finder.go"], - tags = ["automanaged"], deps = ["//vendor/k8s.io/apimachinery/pkg/util/sets:go_default_library"], ) diff --git a/test/utils/image/BUILD b/test/utils/image/BUILD index b3aa96f571..439e6f0ca3 100644 --- a/test/utils/image/BUILD +++ b/test/utils/image/BUILD @@ -10,7 +10,6 @@ load( go_library( name = "go_default_library", srcs = ["manifest.go"], - tags = ["automanaged"], ) filegroup( diff --git a/vendor/github.com/vishvananda/netns/BUILD b/vendor/github.com/vishvananda/netns/BUILD index 47eb850f9b..2e80a54131 100644 --- a/vendor/github.com/vishvananda/netns/BUILD +++ b/vendor/github.com/vishvananda/netns/BUILD @@ -18,7 +18,6 @@ go_library( ], "//conditions:default": [], }), - tags = ["automanaged"], ) filegroup( From 02fb4200dcdf8636eac5953d04b2c4af912f443b Mon Sep 17 00:00:00 2001 From: Jeff Grafton Date: Thu, 21 Sep 2017 14:54:29 -0700 Subject: [PATCH 3/7] Use buildozer to delete licenses() rules --- cmd/kubeadm/app/phases/addons/dns/BUILD | 2 -- cmd/kubeadm/app/phases/etcd/BUILD | 2 -- cmd/kubeadm/app/util/staticpod/BUILD | 2 -- pkg/apis/batch/v1beta1/BUILD | 2 -- pkg/controller/volume/expand/BUILD | 2 -- pkg/controller/volume/expand/cache/BUILD | 2 -- pkg/kubeapiserver/admission/util/BUILD | 2 -- pkg/kubectl/apps/BUILD | 2 -- pkg/kubectl/cmd/util/openapi/testing/BUILD | 2 -- pkg/kubectl/cmd/util/openapi/validation/BUILD | 2 -- pkg/kubectl/util/hash/BUILD | 2 -- pkg/kubectl/validation/BUILD | 2 -- pkg/kubelet/apis/deviceplugin/v1alpha1/BUILD | 2 -- pkg/kubelet/apis/kubeletconfig/BUILD | 2 -- pkg/kubelet/apis/kubeletconfig/v1alpha1/BUILD | 2 -- pkg/kubelet/apis/kubeletconfig/validation/BUILD | 2 -- pkg/kubelet/deviceplugin/BUILD | 2 -- pkg/proxy/ipvs/BUILD | 2 -- pkg/util/ipvs/BUILD | 2 -- pkg/util/ipvs/testing/BUILD | 2 -- plugin/pkg/admission/eventratelimit/BUILD | 2 -- plugin/pkg/admission/eventratelimit/apis/eventratelimit/BUILD | 2 -- .../admission/eventratelimit/apis/eventratelimit/install/BUILD | 2 -- .../admission/eventratelimit/apis/eventratelimit/v1alpha1/BUILD | 2 -- .../eventratelimit/apis/eventratelimit/validation/BUILD | 2 -- plugin/pkg/admission/persistentvolume/resize/BUILD | 2 -- plugin/pkg/admission/priority/BUILD | 2 -- staging/src/k8s.io/api/batch/v1beta1/BUILD | 2 -- .../apiextensions-apiserver/pkg/apiserver/validation/BUILD | 2 -- staging/src/k8s.io/apiserver/pkg/apis/audit/v1beta1/BUILD | 2 -- .../src/k8s.io/apiserver/pkg/authentication/token/cache/BUILD | 2 -- .../src/k8s.io/apiserver/pkg/authentication/token/union/BUILD | 2 -- staging/src/k8s.io/client-go/informers/batch/v1beta1/BUILD | 2 -- .../src/k8s.io/client-go/kubernetes/typed/batch/v1beta1/BUILD | 2 -- .../k8s.io/client-go/kubernetes/typed/batch/v1beta1/fake/BUILD | 2 -- staging/src/k8s.io/client-go/listers/batch/v1beta1/BUILD | 2 -- staging/src/k8s.io/client-go/tools/pager/BUILD | 2 -- test/e2e/auth/BUILD | 2 -- test/images/nonewprivs/BUILD | 2 -- test/images/pets/peer-finder/BUILD | 2 -- test/utils/image/BUILD | 2 -- vendor/github.com/vishvananda/netns/BUILD | 2 -- 42 files changed, 84 deletions(-) diff --git a/cmd/kubeadm/app/phases/addons/dns/BUILD b/cmd/kubeadm/app/phases/addons/dns/BUILD index b59b7bc768..88be71b714 100644 --- a/cmd/kubeadm/app/phases/addons/dns/BUILD +++ b/cmd/kubeadm/app/phases/addons/dns/BUILD @@ -1,7 +1,5 @@ package(default_visibility = ["//visibility:public"]) -licenses(["notice"]) - load( "@io_bazel_rules_go//go:def.bzl", "go_library", diff --git a/cmd/kubeadm/app/phases/etcd/BUILD b/cmd/kubeadm/app/phases/etcd/BUILD index 8eef06d6d0..f2e1af1a4f 100644 --- a/cmd/kubeadm/app/phases/etcd/BUILD +++ b/cmd/kubeadm/app/phases/etcd/BUILD @@ -1,7 +1,5 @@ package(default_visibility = ["//visibility:public"]) -licenses(["notice"]) - load( "@io_bazel_rules_go//go:def.bzl", "go_library", diff --git a/cmd/kubeadm/app/util/staticpod/BUILD b/cmd/kubeadm/app/util/staticpod/BUILD index a2bf2379c8..41bf1d79b7 100644 --- a/cmd/kubeadm/app/util/staticpod/BUILD +++ b/cmd/kubeadm/app/util/staticpod/BUILD @@ -1,7 +1,5 @@ package(default_visibility = ["//visibility:public"]) -licenses(["notice"]) - load( "@io_bazel_rules_go//go:def.bzl", "go_library", diff --git a/pkg/apis/batch/v1beta1/BUILD b/pkg/apis/batch/v1beta1/BUILD index 4eed77c24e..1d8296b67a 100644 --- a/pkg/apis/batch/v1beta1/BUILD +++ b/pkg/apis/batch/v1beta1/BUILD @@ -1,7 +1,5 @@ package(default_visibility = ["//visibility:public"]) -licenses(["notice"]) - load( "@io_bazel_rules_go//go:def.bzl", "go_library", diff --git a/pkg/controller/volume/expand/BUILD b/pkg/controller/volume/expand/BUILD index f108657eb8..83b6ae14ce 100644 --- a/pkg/controller/volume/expand/BUILD +++ b/pkg/controller/volume/expand/BUILD @@ -1,7 +1,5 @@ package(default_visibility = ["//visibility:public"]) -licenses(["notice"]) - load( "@io_bazel_rules_go//go:def.bzl", "go_library", diff --git a/pkg/controller/volume/expand/cache/BUILD b/pkg/controller/volume/expand/cache/BUILD index 5d5a52d2c8..54d55cfb69 100644 --- a/pkg/controller/volume/expand/cache/BUILD +++ b/pkg/controller/volume/expand/cache/BUILD @@ -1,7 +1,5 @@ package(default_visibility = ["//visibility:public"]) -licenses(["notice"]) - load( "@io_bazel_rules_go//go:def.bzl", "go_library", diff --git a/pkg/kubeapiserver/admission/util/BUILD b/pkg/kubeapiserver/admission/util/BUILD index f4a9768963..6ea0e57583 100644 --- a/pkg/kubeapiserver/admission/util/BUILD +++ b/pkg/kubeapiserver/admission/util/BUILD @@ -1,7 +1,5 @@ package(default_visibility = ["//visibility:public"]) -licenses(["notice"]) - load( "@io_bazel_rules_go//go:def.bzl", "go_library", diff --git a/pkg/kubectl/apps/BUILD b/pkg/kubectl/apps/BUILD index 693b8b8e93..7562719a73 100644 --- a/pkg/kubectl/apps/BUILD +++ b/pkg/kubectl/apps/BUILD @@ -1,7 +1,5 @@ package(default_visibility = ["//visibility:public"]) -licenses(["notice"]) - load( "@io_bazel_rules_go//go:def.bzl", "go_library", diff --git a/pkg/kubectl/cmd/util/openapi/testing/BUILD b/pkg/kubectl/cmd/util/openapi/testing/BUILD index f683c363b0..665c1675e1 100644 --- a/pkg/kubectl/cmd/util/openapi/testing/BUILD +++ b/pkg/kubectl/cmd/util/openapi/testing/BUILD @@ -1,7 +1,5 @@ package(default_visibility = ["//visibility:public"]) -licenses(["notice"]) - load( "@io_bazel_rules_go//go:def.bzl", "go_library", diff --git a/pkg/kubectl/cmd/util/openapi/validation/BUILD b/pkg/kubectl/cmd/util/openapi/validation/BUILD index f55d5119c3..5b39cd9e5b 100644 --- a/pkg/kubectl/cmd/util/openapi/validation/BUILD +++ b/pkg/kubectl/cmd/util/openapi/validation/BUILD @@ -1,7 +1,5 @@ package(default_visibility = ["//visibility:public"]) -licenses(["notice"]) - load( "@io_bazel_rules_go//go:def.bzl", "go_library", diff --git a/pkg/kubectl/util/hash/BUILD b/pkg/kubectl/util/hash/BUILD index 1249577fde..cb61f2c2b7 100644 --- a/pkg/kubectl/util/hash/BUILD +++ b/pkg/kubectl/util/hash/BUILD @@ -1,7 +1,5 @@ package(default_visibility = ["//visibility:public"]) -licenses(["notice"]) - load( "@io_bazel_rules_go//go:def.bzl", "go_library", diff --git a/pkg/kubectl/validation/BUILD b/pkg/kubectl/validation/BUILD index e5443452a2..4366dca98b 100644 --- a/pkg/kubectl/validation/BUILD +++ b/pkg/kubectl/validation/BUILD @@ -1,5 +1,3 @@ -licenses(["notice"]) - load( "@io_bazel_rules_go//go:def.bzl", "go_library", diff --git a/pkg/kubelet/apis/deviceplugin/v1alpha1/BUILD b/pkg/kubelet/apis/deviceplugin/v1alpha1/BUILD index c43100a21f..c39b090d13 100644 --- a/pkg/kubelet/apis/deviceplugin/v1alpha1/BUILD +++ b/pkg/kubelet/apis/deviceplugin/v1alpha1/BUILD @@ -1,7 +1,5 @@ package(default_visibility = ["//visibility:public"]) -licenses(["notice"]) - load( "@io_bazel_rules_go//go:def.bzl", "go_library", diff --git a/pkg/kubelet/apis/kubeletconfig/BUILD b/pkg/kubelet/apis/kubeletconfig/BUILD index 4428c8bd63..eae42730f8 100644 --- a/pkg/kubelet/apis/kubeletconfig/BUILD +++ b/pkg/kubelet/apis/kubeletconfig/BUILD @@ -1,7 +1,5 @@ package(default_visibility = ["//visibility:public"]) -licenses(["notice"]) - load( "@io_bazel_rules_go//go:def.bzl", "go_library", diff --git a/pkg/kubelet/apis/kubeletconfig/v1alpha1/BUILD b/pkg/kubelet/apis/kubeletconfig/v1alpha1/BUILD index ef43b6f3ff..b26e82ea70 100644 --- a/pkg/kubelet/apis/kubeletconfig/v1alpha1/BUILD +++ b/pkg/kubelet/apis/kubeletconfig/v1alpha1/BUILD @@ -1,7 +1,5 @@ package(default_visibility = ["//visibility:public"]) -licenses(["notice"]) - load( "@io_bazel_rules_go//go:def.bzl", "go_library", diff --git a/pkg/kubelet/apis/kubeletconfig/validation/BUILD b/pkg/kubelet/apis/kubeletconfig/validation/BUILD index 7803606382..9154d0c18c 100644 --- a/pkg/kubelet/apis/kubeletconfig/validation/BUILD +++ b/pkg/kubelet/apis/kubeletconfig/validation/BUILD @@ -1,7 +1,5 @@ package(default_visibility = ["//visibility:public"]) -licenses(["notice"]) - load( "@io_bazel_rules_go//go:def.bzl", "go_library", diff --git a/pkg/kubelet/deviceplugin/BUILD b/pkg/kubelet/deviceplugin/BUILD index 31e2a9fe33..1544cbcb8c 100644 --- a/pkg/kubelet/deviceplugin/BUILD +++ b/pkg/kubelet/deviceplugin/BUILD @@ -1,7 +1,5 @@ package(default_visibility = ["//visibility:public"]) -licenses(["notice"]) - load( "@io_bazel_rules_go//go:def.bzl", "go_library", diff --git a/pkg/proxy/ipvs/BUILD b/pkg/proxy/ipvs/BUILD index 1655b41b29..4322d01fc0 100644 --- a/pkg/proxy/ipvs/BUILD +++ b/pkg/proxy/ipvs/BUILD @@ -1,7 +1,5 @@ package(default_visibility = ["//visibility:public"]) -licenses(["notice"]) - load( "@io_bazel_rules_go//go:def.bzl", "go_library", diff --git a/pkg/util/ipvs/BUILD b/pkg/util/ipvs/BUILD index e5f488de45..5853ebb8d3 100644 --- a/pkg/util/ipvs/BUILD +++ b/pkg/util/ipvs/BUILD @@ -1,7 +1,5 @@ package(default_visibility = ["//visibility:public"]) -licenses(["notice"]) - load( "@io_bazel_rules_go//go:def.bzl", "go_library", diff --git a/pkg/util/ipvs/testing/BUILD b/pkg/util/ipvs/testing/BUILD index 36608dc347..6789e58f13 100644 --- a/pkg/util/ipvs/testing/BUILD +++ b/pkg/util/ipvs/testing/BUILD @@ -1,7 +1,5 @@ package(default_visibility = ["//visibility:public"]) -licenses(["notice"]) - load( "@io_bazel_rules_go//go:def.bzl", "go_library", diff --git a/plugin/pkg/admission/eventratelimit/BUILD b/plugin/pkg/admission/eventratelimit/BUILD index d4b15fe825..3b72f71598 100644 --- a/plugin/pkg/admission/eventratelimit/BUILD +++ b/plugin/pkg/admission/eventratelimit/BUILD @@ -1,7 +1,5 @@ package(default_visibility = ["//visibility:public"]) -licenses(["notice"]) - load( "@io_bazel_rules_go//go:def.bzl", "go_library", diff --git a/plugin/pkg/admission/eventratelimit/apis/eventratelimit/BUILD b/plugin/pkg/admission/eventratelimit/apis/eventratelimit/BUILD index d486f88813..8126630d66 100644 --- a/plugin/pkg/admission/eventratelimit/apis/eventratelimit/BUILD +++ b/plugin/pkg/admission/eventratelimit/apis/eventratelimit/BUILD @@ -1,7 +1,5 @@ package(default_visibility = ["//visibility:public"]) -licenses(["notice"]) - load( "@io_bazel_rules_go//go:def.bzl", "go_library", diff --git a/plugin/pkg/admission/eventratelimit/apis/eventratelimit/install/BUILD b/plugin/pkg/admission/eventratelimit/apis/eventratelimit/install/BUILD index 75251ed6f6..6bf1fb44c8 100644 --- a/plugin/pkg/admission/eventratelimit/apis/eventratelimit/install/BUILD +++ b/plugin/pkg/admission/eventratelimit/apis/eventratelimit/install/BUILD @@ -1,7 +1,5 @@ package(default_visibility = ["//visibility:public"]) -licenses(["notice"]) - load( "@io_bazel_rules_go//go:def.bzl", "go_library", diff --git a/plugin/pkg/admission/eventratelimit/apis/eventratelimit/v1alpha1/BUILD b/plugin/pkg/admission/eventratelimit/apis/eventratelimit/v1alpha1/BUILD index 94912ab762..eab591002f 100644 --- a/plugin/pkg/admission/eventratelimit/apis/eventratelimit/v1alpha1/BUILD +++ b/plugin/pkg/admission/eventratelimit/apis/eventratelimit/v1alpha1/BUILD @@ -1,7 +1,5 @@ package(default_visibility = ["//visibility:public"]) -licenses(["notice"]) - load( "@io_bazel_rules_go//go:def.bzl", "go_library", diff --git a/plugin/pkg/admission/eventratelimit/apis/eventratelimit/validation/BUILD b/plugin/pkg/admission/eventratelimit/apis/eventratelimit/validation/BUILD index 1d06cbb0bd..695f20b2d4 100644 --- a/plugin/pkg/admission/eventratelimit/apis/eventratelimit/validation/BUILD +++ b/plugin/pkg/admission/eventratelimit/apis/eventratelimit/validation/BUILD @@ -1,7 +1,5 @@ package(default_visibility = ["//visibility:public"]) -licenses(["notice"]) - load( "@io_bazel_rules_go//go:def.bzl", "go_library", diff --git a/plugin/pkg/admission/persistentvolume/resize/BUILD b/plugin/pkg/admission/persistentvolume/resize/BUILD index f7db08d0af..859b651350 100644 --- a/plugin/pkg/admission/persistentvolume/resize/BUILD +++ b/plugin/pkg/admission/persistentvolume/resize/BUILD @@ -1,7 +1,5 @@ package(default_visibility = ["//visibility:public"]) -licenses(["notice"]) - load( "@io_bazel_rules_go//go:def.bzl", "go_library", diff --git a/plugin/pkg/admission/priority/BUILD b/plugin/pkg/admission/priority/BUILD index 05f328be1e..e0354a801d 100644 --- a/plugin/pkg/admission/priority/BUILD +++ b/plugin/pkg/admission/priority/BUILD @@ -1,7 +1,5 @@ package(default_visibility = ["//visibility:public"]) -licenses(["notice"]) - load( "@io_bazel_rules_go//go:def.bzl", "go_library", diff --git a/staging/src/k8s.io/api/batch/v1beta1/BUILD b/staging/src/k8s.io/api/batch/v1beta1/BUILD index 4924d154d7..9bec42868b 100644 --- a/staging/src/k8s.io/api/batch/v1beta1/BUILD +++ b/staging/src/k8s.io/api/batch/v1beta1/BUILD @@ -1,7 +1,5 @@ package(default_visibility = ["//visibility:public"]) -licenses(["notice"]) - load( "@io_bazel_rules_go//go:def.bzl", "go_library", diff --git a/staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/validation/BUILD b/staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/validation/BUILD index 72f9652b9b..3d6cbab9b0 100644 --- a/staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/validation/BUILD +++ b/staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/validation/BUILD @@ -1,7 +1,5 @@ package(default_visibility = ["//visibility:public"]) -licenses(["notice"]) - load( "@io_bazel_rules_go//go:def.bzl", "go_library", diff --git a/staging/src/k8s.io/apiserver/pkg/apis/audit/v1beta1/BUILD b/staging/src/k8s.io/apiserver/pkg/apis/audit/v1beta1/BUILD index 889d9c9997..1d1843f5a8 100644 --- a/staging/src/k8s.io/apiserver/pkg/apis/audit/v1beta1/BUILD +++ b/staging/src/k8s.io/apiserver/pkg/apis/audit/v1beta1/BUILD @@ -1,7 +1,5 @@ package(default_visibility = ["//visibility:public"]) -licenses(["notice"]) - load( "@io_bazel_rules_go//go:def.bzl", "go_library", diff --git a/staging/src/k8s.io/apiserver/pkg/authentication/token/cache/BUILD b/staging/src/k8s.io/apiserver/pkg/authentication/token/cache/BUILD index 252bdcc884..674e59041d 100644 --- a/staging/src/k8s.io/apiserver/pkg/authentication/token/cache/BUILD +++ b/staging/src/k8s.io/apiserver/pkg/authentication/token/cache/BUILD @@ -1,7 +1,5 @@ package(default_visibility = ["//visibility:public"]) -licenses(["notice"]) - load( "@io_bazel_rules_go//go:def.bzl", "go_library", diff --git a/staging/src/k8s.io/apiserver/pkg/authentication/token/union/BUILD b/staging/src/k8s.io/apiserver/pkg/authentication/token/union/BUILD index 9178946cef..c3c0131e7e 100644 --- a/staging/src/k8s.io/apiserver/pkg/authentication/token/union/BUILD +++ b/staging/src/k8s.io/apiserver/pkg/authentication/token/union/BUILD @@ -1,7 +1,5 @@ package(default_visibility = ["//visibility:public"]) -licenses(["notice"]) - load( "@io_bazel_rules_go//go:def.bzl", "go_library", diff --git a/staging/src/k8s.io/client-go/informers/batch/v1beta1/BUILD b/staging/src/k8s.io/client-go/informers/batch/v1beta1/BUILD index 3a202199b8..57fb433270 100644 --- a/staging/src/k8s.io/client-go/informers/batch/v1beta1/BUILD +++ b/staging/src/k8s.io/client-go/informers/batch/v1beta1/BUILD @@ -1,7 +1,5 @@ package(default_visibility = ["//visibility:public"]) -licenses(["notice"]) - load( "@io_bazel_rules_go//go:def.bzl", "go_library", diff --git a/staging/src/k8s.io/client-go/kubernetes/typed/batch/v1beta1/BUILD b/staging/src/k8s.io/client-go/kubernetes/typed/batch/v1beta1/BUILD index c9a1e4c871..e1af5b705b 100644 --- a/staging/src/k8s.io/client-go/kubernetes/typed/batch/v1beta1/BUILD +++ b/staging/src/k8s.io/client-go/kubernetes/typed/batch/v1beta1/BUILD @@ -1,7 +1,5 @@ package(default_visibility = ["//visibility:public"]) -licenses(["notice"]) - load( "@io_bazel_rules_go//go:def.bzl", "go_library", diff --git a/staging/src/k8s.io/client-go/kubernetes/typed/batch/v1beta1/fake/BUILD b/staging/src/k8s.io/client-go/kubernetes/typed/batch/v1beta1/fake/BUILD index 31f4cdd4a5..230412aacf 100644 --- a/staging/src/k8s.io/client-go/kubernetes/typed/batch/v1beta1/fake/BUILD +++ b/staging/src/k8s.io/client-go/kubernetes/typed/batch/v1beta1/fake/BUILD @@ -1,7 +1,5 @@ package(default_visibility = ["//visibility:public"]) -licenses(["notice"]) - load( "@io_bazel_rules_go//go:def.bzl", "go_library", diff --git a/staging/src/k8s.io/client-go/listers/batch/v1beta1/BUILD b/staging/src/k8s.io/client-go/listers/batch/v1beta1/BUILD index ab06f2466f..2713e70e61 100644 --- a/staging/src/k8s.io/client-go/listers/batch/v1beta1/BUILD +++ b/staging/src/k8s.io/client-go/listers/batch/v1beta1/BUILD @@ -1,7 +1,5 @@ package(default_visibility = ["//visibility:public"]) -licenses(["notice"]) - load( "@io_bazel_rules_go//go:def.bzl", "go_library", diff --git a/staging/src/k8s.io/client-go/tools/pager/BUILD b/staging/src/k8s.io/client-go/tools/pager/BUILD index e3cda4d5a5..5b22978c89 100644 --- a/staging/src/k8s.io/client-go/tools/pager/BUILD +++ b/staging/src/k8s.io/client-go/tools/pager/BUILD @@ -1,7 +1,5 @@ package(default_visibility = ["//visibility:public"]) -licenses(["notice"]) - load( "@io_bazel_rules_go//go:def.bzl", "go_library", diff --git a/test/e2e/auth/BUILD b/test/e2e/auth/BUILD index a50958bda9..894022940f 100644 --- a/test/e2e/auth/BUILD +++ b/test/e2e/auth/BUILD @@ -1,7 +1,5 @@ package(default_visibility = ["//visibility:public"]) -licenses(["notice"]) - load( "@io_bazel_rules_go//go:def.bzl", "go_library", diff --git a/test/images/nonewprivs/BUILD b/test/images/nonewprivs/BUILD index 112e9e5824..b484ac3ee2 100644 --- a/test/images/nonewprivs/BUILD +++ b/test/images/nonewprivs/BUILD @@ -1,7 +1,5 @@ package(default_visibility = ["//visibility:public"]) -licenses(["notice"]) - load( "@io_bazel_rules_go//go:def.bzl", "go_binary", diff --git a/test/images/pets/peer-finder/BUILD b/test/images/pets/peer-finder/BUILD index b0fd1e7442..dcd1a71f55 100644 --- a/test/images/pets/peer-finder/BUILD +++ b/test/images/pets/peer-finder/BUILD @@ -1,7 +1,5 @@ package(default_visibility = ["//visibility:public"]) -licenses(["notice"]) - load( "@io_bazel_rules_go//go:def.bzl", "go_binary", diff --git a/test/utils/image/BUILD b/test/utils/image/BUILD index 439e6f0ca3..a31c569b25 100644 --- a/test/utils/image/BUILD +++ b/test/utils/image/BUILD @@ -1,7 +1,5 @@ package(default_visibility = ["//visibility:public"]) -licenses(["notice"]) - load( "@io_bazel_rules_go//go:def.bzl", "go_library", diff --git a/vendor/github.com/vishvananda/netns/BUILD b/vendor/github.com/vishvananda/netns/BUILD index 2e80a54131..d88da4d5ab 100644 --- a/vendor/github.com/vishvananda/netns/BUILD +++ b/vendor/github.com/vishvananda/netns/BUILD @@ -1,7 +1,5 @@ package(default_visibility = ["//visibility:public"]) -licenses(["notice"]) - load( "@io_bazel_rules_go//go:def.bzl", "go_library", From 04b0468464a87415a828f3c2e2e0d5fdf7d0d4cd Mon Sep 17 00:00:00 2001 From: Jeff Grafton Date: Thu, 21 Sep 2017 15:07:59 -0700 Subject: [PATCH 4/7] add tags to e2e and integration tests --- test/e2e/BUILD | 1 + test/e2e/chaosmonkey/BUILD | 1 + test/e2e/scheduling/BUILD | 1 + test/e2e_node/BUILD | 2 +- test/e2e_node/system/BUILD | 1 + test/integration/deployment/BUILD | 1 + 6 files changed, 6 insertions(+), 1 deletion(-) diff --git a/test/e2e/BUILD b/test/e2e/BUILD index 426e495790..59572bc5e7 100644 --- a/test/e2e/BUILD +++ b/test/e2e/BUILD @@ -10,6 +10,7 @@ go_test( name = "go_default_test", srcs = ["e2e_test.go"], library = ":go_default_library", + tags = ["e2e"], deps = [ "//test/e2e/apimachinery:go_default_library", "//test/e2e/apps:go_default_library", diff --git a/test/e2e/chaosmonkey/BUILD b/test/e2e/chaosmonkey/BUILD index f0b34e6d54..dbdbd78fa0 100644 --- a/test/e2e/chaosmonkey/BUILD +++ b/test/e2e/chaosmonkey/BUILD @@ -16,6 +16,7 @@ go_test( name = "go_default_test", srcs = ["chaosmonkey_test.go"], library = ":go_default_library", + tags = ["e2e"], ) filegroup( diff --git a/test/e2e/scheduling/BUILD b/test/e2e/scheduling/BUILD index 7567684199..a1fcac6342 100644 --- a/test/e2e/scheduling/BUILD +++ b/test/e2e/scheduling/BUILD @@ -66,6 +66,7 @@ go_test( name = "go_default_test", srcs = ["taints_test.go"], library = ":go_default_library", + tags = ["e2e"], deps = [ "//test/e2e/framework:go_default_library", "//test/utils:go_default_library", diff --git a/test/e2e_node/BUILD b/test/e2e_node/BUILD index e83a046452..8f8fb228d6 100644 --- a/test/e2e_node/BUILD +++ b/test/e2e_node/BUILD @@ -112,7 +112,7 @@ go_test( "//conditions:default": [], }), library = ":go_default_library", - tags = ["integration"], + tags = ["e2e"], deps = [ "//pkg/api:go_default_library", "//pkg/api/v1/node:go_default_library", diff --git a/test/e2e_node/system/BUILD b/test/e2e_node/system/BUILD index 67dfe7d6c2..d3641f52b5 100644 --- a/test/e2e_node/system/BUILD +++ b/test/e2e_node/system/BUILD @@ -38,6 +38,7 @@ go_test( "package_validator_test.go", ], library = ":go_default_library", + tags = ["e2e"], deps = [ "//vendor/github.com/docker/docker/api/types:go_default_library", "//vendor/github.com/stretchr/testify/assert:go_default_library", diff --git a/test/integration/deployment/BUILD b/test/integration/deployment/BUILD index 1262c07501..ea03c5d858 100644 --- a/test/integration/deployment/BUILD +++ b/test/integration/deployment/BUILD @@ -14,6 +14,7 @@ go_test( "main_test.go", ], library = ":go_default_library", + tags = ["integration"], deps = [ "//pkg/controller/deployment/util:go_default_library", "//test/integration/framework:go_default_library", From c4455eeac81cd4482b90ee7e649273179a4a28ff Mon Sep 17 00:00:00 2001 From: Jeff Grafton Date: Thu, 21 Sep 2017 15:18:36 -0700 Subject: [PATCH 5/7] Tag broken examples test as manual --- examples/BUILD | 1 + 1 file changed, 1 insertion(+) diff --git a/examples/BUILD b/examples/BUILD index 0f28a3505d..512177489c 100644 --- a/examples/BUILD +++ b/examples/BUILD @@ -32,6 +32,7 @@ go_library( go_test( name = "go_default_xtest", srcs = ["examples_test.go"], + tags = ["manual"], # this test is broken and examples in-tree is deprecated deps = [ "//pkg/api:go_default_library", "//pkg/api/testapi:go_default_library", From f1953c4f537b970c7ea4bbecf2f7bd75073e309c Mon Sep 17 00:00:00 2001 From: Jeff Grafton Date: Thu, 21 Sep 2017 15:22:34 -0700 Subject: [PATCH 6/7] bazel: use autogenerated all-srcs rules instead of manually-curated sources rules --- examples/BUILD | 7 ------- test/e2e/generated/BUILD | 8 ++++---- test/e2e/testing-manifests/BUILD | 7 ------- test/fixtures/BUILD | 7 ------- test/images/BUILD | 7 ------- 5 files changed, 4 insertions(+), 32 deletions(-) diff --git a/examples/BUILD b/examples/BUILD index 512177489c..53fd6e7786 100644 --- a/examples/BUILD +++ b/examples/BUILD @@ -17,13 +17,6 @@ filegroup( ], ) -filegroup( - name = "sources", - srcs = glob([ - "**/*", - ]), -) - go_library( name = "go_default_library", srcs = ["doc.go"], diff --git a/test/e2e/generated/BUILD b/test/e2e/generated/BUILD index 706fad8a7a..8e395be655 100644 --- a/test/e2e/generated/BUILD +++ b/test/e2e/generated/BUILD @@ -20,10 +20,10 @@ go_library( genrule( name = "bindata", srcs = [ - "//examples:sources", - "//test/images:sources", - "//test/fixtures:sources", - "//test/e2e/testing-manifests:sources", + "//examples:all-srcs", + "//test/images:all-srcs", + "//test/fixtures:all-srcs", + "//test/e2e/testing-manifests:all-srcs", ], outs = ["bindata.go"], cmd = """ diff --git a/test/e2e/testing-manifests/BUILD b/test/e2e/testing-manifests/BUILD index a9e9b9c401..7e76248ad9 100644 --- a/test/e2e/testing-manifests/BUILD +++ b/test/e2e/testing-manifests/BUILD @@ -1,12 +1,5 @@ package(default_visibility = ["//visibility:public"]) -filegroup( - name = "sources", - srcs = glob([ - "**/*", - ]), -) - filegroup( name = "package-srcs", srcs = glob(["**"]), diff --git a/test/fixtures/BUILD b/test/fixtures/BUILD index 0529b21829..0dd30f3070 100644 --- a/test/fixtures/BUILD +++ b/test/fixtures/BUILD @@ -9,13 +9,6 @@ filegroup( ]), ) -filegroup( - name = "sources", - srcs = glob([ - "**/*", - ]), -) - filegroup( name = "package-srcs", srcs = glob(["**"]), diff --git a/test/images/BUILD b/test/images/BUILD index c39d264524..73e9ce74a6 100644 --- a/test/images/BUILD +++ b/test/images/BUILD @@ -1,12 +1,5 @@ package(default_visibility = ["//visibility:public"]) -filegroup( - name = "sources", - srcs = glob([ - "**/*", - ]), -) - filegroup( name = "package-srcs", srcs = glob(["**"]), From 6bf7fc351424b2d4eaba27798b4f67e1f268ad5a Mon Sep 17 00:00:00 2001 From: Jeff Grafton Date: Thu, 21 Sep 2017 14:52:54 -0700 Subject: [PATCH 7/7] bazel: build/test almost everything --- build/root/BUILD.root | 1 + build/root/Makefile | 12 ++++++++++-- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/build/root/BUILD.root b/build/root/BUILD.root index 56627f257d..a56e731655 100644 --- a/build/root/BUILD.root +++ b/build/root/BUILD.root @@ -29,6 +29,7 @@ gcs_upload( "//build/release-tars:release-tars-and-hashes", "//cluster/gce:gcs-release-artifacts-and-hashes", ], + tags = ["manual"], upload_paths = { "//:_binary-artifacts-and-hashes": "bin/linux/amd64", "//build/release-tars:release-tars-and-hashes": "", diff --git a/build/root/Makefile b/build/root/Makefile index ffed29909c..83bf9ac2e6 100644 --- a/build/root/Makefile +++ b/build/root/Makefile @@ -521,8 +521,9 @@ endef bazel-build: @echo "$$BAZEL_BUILD_HELP_INFO" else +# Some things in vendor don't build due to empty target lists for cross-platform rules. bazel-build: - bazel build //cmd/... //hack/... //pkg/... //federation/... //plugin/... //third_party/... //examples/... //test/... //vendor/k8s.io/... + bazel build -- //... -//vendor/... endif @@ -536,8 +537,15 @@ endef bazel-test: @echo "$$BAZEL_TEST_HELP_INFO" else +# //hack:verify-all is a manual target. +# We don't want to build any of the release artifacts when running tests. +# Some things in vendor don't build due to empty target lists for cross-platform rules. bazel-test: - bazel test --test_tag_filters=-integration --flaky_test_attempts=3 //cmd/... //pkg/... //federation/... //plugin/... //third_party/... //hack/... //hack:verify-all //vendor/k8s.io/... + bazel test --build_tag_filters=-e2e,-integration --test_tag_filters=-e2e,-integration --flaky_test_attempts=3 -- \ + //... \ + //hack:verify-all \ + -//build/... \ + -//vendor/... endif ifeq ($(PRINT_HELP),y)