From 2d701e8ac807979d6be2ffd03852ed793e335255 Mon Sep 17 00:00:00 2001 From: magicwang-cn Date: Thu, 4 Feb 2016 11:07:00 +0800 Subject: [PATCH] bug fix in unversion request --- pkg/client/unversioned/request.go | 1 + pkg/client/unversioned/request_test.go | 10 ++++++++-- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/pkg/client/unversioned/request.go b/pkg/client/unversioned/request.go index 3789cdccd2..7f0bc185c0 100644 --- a/pkg/client/unversioned/request.go +++ b/pkg/client/unversioned/request.go @@ -642,6 +642,7 @@ func (r *Request) Watch() (watch.Interface, error) { return nil, err } if resp.StatusCode != http.StatusOK { + defer resp.Body.Close() if result := r.transformResponse(resp, req); result.err != nil { return nil, result.err } diff --git a/pkg/client/unversioned/request_test.go b/pkg/client/unversioned/request_test.go index e0823a7909..2b5bf6d297 100644 --- a/pkg/client/unversioned/request_test.go +++ b/pkg/client/unversioned/request_test.go @@ -477,7 +477,10 @@ func TestRequestWatch(t *testing.T) { Request: &Request{ content: ContentConfig{GroupVersion: testapi.Default.GroupVersion(), Codec: testapi.Default.Codec()}, client: clientFunc(func(req *http.Request) (*http.Response, error) { - return &http.Response{StatusCode: http.StatusForbidden}, nil + return &http.Response{ + StatusCode: http.StatusForbidden, + Body: ioutil.NopCloser(bytes.NewReader([]byte{})), + }, nil }), baseURL: &url.URL{}, }, @@ -490,7 +493,10 @@ func TestRequestWatch(t *testing.T) { Request: &Request{ content: ContentConfig{GroupVersion: testapi.Default.GroupVersion(), Codec: testapi.Default.Codec()}, client: clientFunc(func(req *http.Request) (*http.Response, error) { - return &http.Response{StatusCode: http.StatusUnauthorized}, nil + return &http.Response{ + StatusCode: http.StatusUnauthorized, + Body: ioutil.NopCloser(bytes.NewReader([]byte{})), + }, nil }), baseURL: &url.URL{}, },